From: "Theodore Ts'o" <tytso@mit.edu>
To: Jeff Layton <jlayton@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
open list <linux-kernel@vger.kernel.org>,
"<linux-fsdevel@vger.kernel.org>" <linux-fsdevel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
xfs <linux-xfs@vger.kernel.org>,
"open list:NFS, SUNRPC, AND..." <linux-nfs@vger.kernel.org>,
linux-btrfs <linux-btrfs@vger.kernel.org>,
linux-integrity <linux-integrity@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: [GIT PULL] inode->i_version rework for v4.16
Date: Tue, 30 Jan 2018 10:15:43 -0500 [thread overview]
Message-ID: <20180130151543.GB8351@thunk.org> (raw)
In-Reply-To: <1517313948.3658.8.camel@redhat.com>
On Tue, Jan 30, 2018 at 07:05:48AM -0500, Jeff Layton wrote:
>
> I want to make sure I understand what's actually broken here thoug. Is
> it only broken when the two values are more than 2**63 apart, or is
> there something else more fundamentally wrong here?
The other problem is that returning a s64 (or a u64) is extremely
inefficient on a 32-bit platform. So in general, it's better to avoid
returning a 64-bit type unless it's really necessary....
- Ted
next prev parent reply other threads:[~2018-01-30 16:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 12:26 [GIT PULL] inode->i_version rework for v4.16 Jeff Layton
2018-01-29 21:50 ` Linus Torvalds
2018-01-29 21:51 ` Linus Torvalds
2018-01-30 12:05 ` Jeff Layton
2018-01-30 15:15 ` Theodore Ts'o [this message]
2018-01-30 16:36 ` Linus Torvalds
2018-01-30 16:36 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180130151543.GB8351@thunk.org \
--to=tytso@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=jlayton@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.