From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2] drm/edid: use true and false for boolean values Date: Tue, 30 Jan 2018 17:19:46 +0200 Message-ID: <20180130151946.GC5453@intel.com> References: <20180130100528.GA7154@training> <20180130150927.3fm5kotyp6vqugaf@art_vandelay> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 017F06E987 for ; Tue, 30 Jan 2018 15:19:50 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180130150927.3fm5kotyp6vqugaf@art_vandelay> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean Paul Cc: "Gustavo A. R. Silva" , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, "Gustavo A. R. Silva" , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBKYW4gMzAsIDIwMTggYXQgMTA6MDk6MjdBTSAtMDUwMCwgU2VhbiBQYXVsIHdyb3Rl Ogo+IE9uIFR1ZSwgSmFuIDMwLCAyMDE4IGF0IDA0OjA1OjI4QU0gLTA2MDAsIEd1c3Rhdm8gQS4g Ui4gU2lsdmEgd3JvdGU6Cj4gPiBBc3NpZ24gdHJ1ZSBvciBmYWxzZSB0byBib29sZWFuIHZhcmlh YmxlcyBpbnN0ZWFkIG9mIGFuIGludGVnZXIgdmFsdWUuCj4gPiAKPiA+IFRoaXMgaXNzdWUgd2Fz IGRldGVjdGVkIHdpdGggdGhlIGhlbHAgb2YgQ29jY2luZWxsZS4KPiAKPiBJIHN1cHBvc2UgeW91 IGNvdWxkIGFsc28gZml4IHVwIHRoZSBvdGhlciBwcmVmZXJyZWQgYXNzaWdubWVudCBieSBhZGRp bmcgISEKPiB0byB0aGUgYml0d2lzZSAmIG9wZXJhdGlvbi4KCkFzc2lnbmluZyA+MSB0byBhIGJv b2wgaXMgd2VsbCBkZWZpbmVkLiBObyBuZWVkIHRvIGNsdXR0ZXIgdGhlIGNvZGUgd2l0aAohISBp bW8uCgo+IAo+IEl0J3MgYWxzbyBoZWxwZnVsIHRvIHBvc3QgdGhlIHNwYXRjaCBpbiB0aGUgY29t bWl0IG1lc3NhZ2Ugc28gb3RoZXJzIGNhbgo+IHJlcGxpY2F0ZSB5b3VyIHJlc3VsdCAodGhpcyBj YXNlIGlzIHByZXR0eSB0cml2aWFsLCBzbyBsZXNzIGltcG9ydGFudCkuCj4gCj4gU2Vhbgo+IAo+ ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBHdXN0YXZvIEEuIFIuIFNpbHZhIDxndXN0YXZvQGVtYmVk ZGVkb3IuY29tPgo+ID4gLS0tCj4gPiBDaGFuZ2VzIGluIHYyOgo+ID4gIC0gVXNlIHRydWUgZm9y IGJvb2xlYW4gdmFsdWUgaW4gYWRkX2RldGFpbGVkX21vZGUgYXMgc3VnZ2VzdGVkIGJ5IERhbmll bAo+ID4gICAgVmV0dGVyLgo+ID4gIC0gVXBkYXRlIHN1YmplY3QuCj4gPiAKPiA+ICBkcml2ZXJz L2dwdS9kcm0vZHJtX2VkaWQuYyB8IDQgKystLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2Vy dGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vZHJtX2VkaWQuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZWRpZC5jCj4gPiBpbmRleCBk ZGQ1Mzc5Li5iMWNiMjYyIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9lZGlk LmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZWRpZC5jCj4gPiBAQCAtMjc2Nyw3ICsy NzY3LDcgQEAgZG9fZGV0YWlsZWRfbW9kZShzdHJ1Y3QgZGV0YWlsZWRfdGltaW5nICp0aW1pbmcs IHZvaWQgKmMpCj4gPiAgCj4gPiAgCQlkcm1fbW9kZV9wcm9iZWRfYWRkKGNsb3N1cmUtPmNvbm5l Y3RvciwgbmV3bW9kZSk7Cj4gPiAgCQljbG9zdXJlLT5tb2RlcysrOwo+ID4gLQkJY2xvc3VyZS0+ cHJlZmVycmVkID0gMDsKPiA+ICsJCWNsb3N1cmUtPnByZWZlcnJlZCA9IGZhbHNlOwo+ID4gIAl9 Cj4gPiAgfQo+ID4gIAo+ID4gQEAgLTI3ODQsNyArMjc4NCw3IEBAIGFkZF9kZXRhaWxlZF9tb2Rl cyhzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLCBzdHJ1Y3QgZWRpZCAqZWRpZCwKPiA+ ICAJc3RydWN0IGRldGFpbGVkX21vZGVfY2xvc3VyZSBjbG9zdXJlID0gewo+ID4gIAkJLmNvbm5l Y3RvciA9IGNvbm5lY3RvciwKPiA+ICAJCS5lZGlkID0gZWRpZCwKPiA+IC0JCS5wcmVmZXJyZWQg PSAxLAo+ID4gKwkJLnByZWZlcnJlZCA9IHRydWUsCj4gPiAgCQkucXVpcmtzID0gcXVpcmtzLAo+ ID4gIAl9Owo+ID4gIAo+ID4gLS0gCj4gPiAyLjcuNAo+ID4gCj4gCj4gLS0gCj4gU2VhbiBQYXVs LCBTb2Z0d2FyZSBFbmdpbmVlciwgR29vZ2xlIC8gQ2hyb21pdW0gT1MKPiBfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKCi0tIApWaWxsZSBTeXJqw6Rs w6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752749AbeA3PTv (ORCPT ); Tue, 30 Jan 2018 10:19:51 -0500 Received: from mga18.intel.com ([134.134.136.126]:32965 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751433AbeA3PTu (ORCPT ); Tue, 30 Jan 2018 10:19:50 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,435,1511856000"; d="scan'208";a="27468696" Date: Tue, 30 Jan 2018 17:19:46 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Sean Paul Cc: "Gustavo A. R. Silva" , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter , "Gustavo A. R. Silva" Subject: Re: [PATCH v2] drm/edid: use true and false for boolean values Message-ID: <20180130151946.GC5453@intel.com> References: <20180130100528.GA7154@training> <20180130150927.3fm5kotyp6vqugaf@art_vandelay> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180130150927.3fm5kotyp6vqugaf@art_vandelay> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 30, 2018 at 10:09:27AM -0500, Sean Paul wrote: > On Tue, Jan 30, 2018 at 04:05:28AM -0600, Gustavo A. R. Silva wrote: > > Assign true or false to boolean variables instead of an integer value. > > > > This issue was detected with the help of Coccinelle. > > I suppose you could also fix up the other preferred assignment by adding !! > to the bitwise & operation. Assigning >1 to a bool is well defined. No need to clutter the code with !! imo. > > It's also helpful to post the spatch in the commit message so others can > replicate your result (this case is pretty trivial, so less important). > > Sean > > > > > Signed-off-by: Gustavo A. R. Silva > > --- > > Changes in v2: > > - Use true for boolean value in add_detailed_mode as suggested by Daniel > > Vetter. > > - Update subject. > > > > drivers/gpu/drm/drm_edid.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > > index ddd5379..b1cb262 100644 > > --- a/drivers/gpu/drm/drm_edid.c > > +++ b/drivers/gpu/drm/drm_edid.c > > @@ -2767,7 +2767,7 @@ do_detailed_mode(struct detailed_timing *timing, void *c) > > > > drm_mode_probed_add(closure->connector, newmode); > > closure->modes++; > > - closure->preferred = 0; > > + closure->preferred = false; > > } > > } > > > > @@ -2784,7 +2784,7 @@ add_detailed_modes(struct drm_connector *connector, struct edid *edid, > > struct detailed_mode_closure closure = { > > .connector = connector, > > .edid = edid, > > - .preferred = 1, > > + .preferred = true, > > .quirks = quirks, > > }; > > > > -- > > 2.7.4 > > > > -- > Sean Paul, Software Engineer, Google / Chromium OS > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ville Syrjälä Intel OTC