From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2] drm/edid: use true and false for boolean values Date: Tue, 30 Jan 2018 17:31:53 +0100 Message-ID: <20180130163153.GT25930@phenom.ffwll.local> References: <20180130100528.GA7154@training> <20180130150927.3fm5kotyp6vqugaf@art_vandelay> <20180130151946.GC5453@intel.com> <20180130160244.p24of44jgib3botq@art_vandelay> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id A58046EAAF for ; Tue, 30 Jan 2018 16:31:57 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id r71so2422039wmd.1 for ; Tue, 30 Jan 2018 08:31:57 -0800 (PST) Content-Disposition: inline In-Reply-To: <20180130160244.p24of44jgib3botq@art_vandelay> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean Paul Cc: "Gustavo A. R. Silva" , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, "Gustavo A. R. Silva" , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBKYW4gMzAsIDIwMTggYXQgMTE6MDI6NDRBTSAtMDUwMCwgU2VhbiBQYXVsIHdyb3Rl Ogo+IE9uIFR1ZSwgSmFuIDMwLCAyMDE4IGF0IDA1OjE5OjQ2UE0gKzAyMDAsIFZpbGxlIFN5cmrD pGzDpCB3cm90ZToKPiA+IE9uIFR1ZSwgSmFuIDMwLCAyMDE4IGF0IDEwOjA5OjI3QU0gLTA1MDAs IFNlYW4gUGF1bCB3cm90ZToKPiA+ID4gT24gVHVlLCBKYW4gMzAsIDIwMTggYXQgMDQ6MDU6MjhB TSAtMDYwMCwgR3VzdGF2byBBLiBSLiBTaWx2YSB3cm90ZToKPiA+ID4gPiBBc3NpZ24gdHJ1ZSBv ciBmYWxzZSB0byBib29sZWFuIHZhcmlhYmxlcyBpbnN0ZWFkIG9mIGFuIGludGVnZXIgdmFsdWUu Cj4gPiA+ID4gCj4gPiA+ID4gVGhpcyBpc3N1ZSB3YXMgZGV0ZWN0ZWQgd2l0aCB0aGUgaGVscCBv ZiBDb2NjaW5lbGxlLgo+ID4gPiAKPiA+ID4gSSBzdXBwb3NlIHlvdSBjb3VsZCBhbHNvIGZpeCB1 cCB0aGUgb3RoZXIgcHJlZmVycmVkIGFzc2lnbm1lbnQgYnkgYWRkaW5nICEhCj4gPiA+IHRvIHRo ZSBiaXR3aXNlICYgb3BlcmF0aW9uLgo+ID4gCj4gPiBBc3NpZ25pbmcgPjEgdG8gYSBib29sIGlz IHdlbGwgZGVmaW5lZC4gTm8gbmVlZCB0byBjbHV0dGVyIHRoZSBjb2RlIHdpdGgKPiA+ICEhIGlt by4KPiAKPiBUaGVyZSBhcmUgZXhhbXBsZXMgb2YgYm90aCBpbiB0aGUgZmlsZSBhbHJlYWR5LiBJ IGRvbid0IGhhdmUgc3Ryb25nIGZlZWxpbmdzCj4gZWl0aGVyIHdheS4KClllYWgsIEkgYXBwbGll ZCB0aGlzIG9uZSBmb3Igbm93LCB3ZSBjYW4gZG8gbW9yZSBjb2xvciBjaG9pY2UgZGlzY3Vzc2lv bnMKd2l0aCBmb2xsb3cgdXBzIDotKQoKVGhhbmtzIGZvciB0aGUgcGF0Y2guCi1EYW5pZWwKCj4g Cj4gU2VhCj4gCj4gPiAKPiA+ID4gCj4gPiA+IEl0J3MgYWxzbyBoZWxwZnVsIHRvIHBvc3QgdGhl IHNwYXRjaCBpbiB0aGUgY29tbWl0IG1lc3NhZ2Ugc28gb3RoZXJzIGNhbgo+ID4gPiByZXBsaWNh dGUgeW91ciByZXN1bHQgKHRoaXMgY2FzZSBpcyBwcmV0dHkgdHJpdmlhbCwgc28gbGVzcyBpbXBv cnRhbnQpLgo+ID4gPiAKPiA+ID4gU2Vhbgo+ID4gPiAKPiA+ID4gPiAKPiA+ID4gPiBTaWduZWQt b2ZmLWJ5OiBHdXN0YXZvIEEuIFIuIFNpbHZhIDxndXN0YXZvQGVtYmVkZGVkb3IuY29tPgo+ID4g PiA+IC0tLQo+ID4gPiA+IENoYW5nZXMgaW4gdjI6Cj4gPiA+ID4gIC0gVXNlIHRydWUgZm9yIGJv b2xlYW4gdmFsdWUgaW4gYWRkX2RldGFpbGVkX21vZGUgYXMgc3VnZ2VzdGVkIGJ5IERhbmllbAo+ ID4gPiA+ICAgIFZldHRlci4KPiA+ID4gPiAgLSBVcGRhdGUgc3ViamVjdC4KPiA+ID4gPiAKPiA+ ID4gPiAgZHJpdmVycy9ncHUvZHJtL2RybV9lZGlkLmMgfCA0ICsrLS0KPiA+ID4gPiAgMSBmaWxl IGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiA+ID4gPiAKPiA+ID4g PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9lZGlkLmMgYi9kcml2ZXJzL2dwdS9k cm0vZHJtX2VkaWQuYwo+ID4gPiA+IGluZGV4IGRkZDUzNzkuLmIxY2IyNjIgMTAwNjQ0Cj4gPiA+ ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9lZGlkLmMKPiA+ID4gPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vZHJtX2VkaWQuYwo+ID4gPiA+IEBAIC0yNzY3LDcgKzI3NjcsNyBAQCBkb19kZXRh aWxlZF9tb2RlKHN0cnVjdCBkZXRhaWxlZF90aW1pbmcgKnRpbWluZywgdm9pZCAqYykKPiA+ID4g PiAgCj4gPiA+ID4gIAkJZHJtX21vZGVfcHJvYmVkX2FkZChjbG9zdXJlLT5jb25uZWN0b3IsIG5l d21vZGUpOwo+ID4gPiA+ICAJCWNsb3N1cmUtPm1vZGVzKys7Cj4gPiA+ID4gLQkJY2xvc3VyZS0+ cHJlZmVycmVkID0gMDsKPiA+ID4gPiArCQljbG9zdXJlLT5wcmVmZXJyZWQgPSBmYWxzZTsKPiA+ ID4gPiAgCX0KPiA+ID4gPiAgfQo+ID4gPiA+ICAKPiA+ID4gPiBAQCAtMjc4NCw3ICsyNzg0LDcg QEAgYWRkX2RldGFpbGVkX21vZGVzKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsIHN0 cnVjdCBlZGlkICplZGlkLAo+ID4gPiA+ICAJc3RydWN0IGRldGFpbGVkX21vZGVfY2xvc3VyZSBj bG9zdXJlID0gewo+ID4gPiA+ICAJCS5jb25uZWN0b3IgPSBjb25uZWN0b3IsCj4gPiA+ID4gIAkJ LmVkaWQgPSBlZGlkLAo+ID4gPiA+IC0JCS5wcmVmZXJyZWQgPSAxLAo+ID4gPiA+ICsJCS5wcmVm ZXJyZWQgPSB0cnVlLAo+ID4gPiA+ICAJCS5xdWlya3MgPSBxdWlya3MsCj4gPiA+ID4gIAl9Owo+ ID4gPiA+ICAKPiA+ID4gPiAtLSAKPiA+ID4gPiAyLjcuNAo+ID4gPiA+IAo+ID4gPiAKPiA+ID4g LS0gCj4gPiA+IFNlYW4gUGF1bCwgU29mdHdhcmUgRW5naW5lZXIsIEdvb2dsZSAvIENocm9taXVt IE9TCj4gPiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Cj4gPiA+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiA+ID4gZHJpLWRldmVsQGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwo+ID4gPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo+ID4gCj4gPiAtLSAKPiA+IFZpbGxlIFN5cmrDpGzDpAo+ID4gSW50 ZWwgT1RDCj4gCj4gLS0gCj4gU2VhbiBQYXVsLCBTb2Z0d2FyZSBFbmdpbmVlciwgR29vZ2xlIC8g Q2hyb21pdW0gT1MKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWwKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jw b3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753355AbeA3Qb6 (ORCPT ); Tue, 30 Jan 2018 11:31:58 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:54440 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752962AbeA3Qb5 (ORCPT ); Tue, 30 Jan 2018 11:31:57 -0500 X-Google-Smtp-Source: AH8x224UYll/qj6mdsmPWDBlSVPTH95JcwjbEmWekdk0JDwPGs+R3yYnG9iHIefy17G3M3wG7F6+1Q== Date: Tue, 30 Jan 2018 17:31:53 +0100 From: Daniel Vetter To: Sean Paul Cc: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , "Gustavo A. R. Silva" , David Airlie , "Gustavo A. R. Silva" , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter Subject: Re: [PATCH v2] drm/edid: use true and false for boolean values Message-ID: <20180130163153.GT25930@phenom.ffwll.local> Mail-Followup-To: Sean Paul , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , "Gustavo A. R. Silva" , David Airlie , "Gustavo A. R. Silva" , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter References: <20180130100528.GA7154@training> <20180130150927.3fm5kotyp6vqugaf@art_vandelay> <20180130151946.GC5453@intel.com> <20180130160244.p24of44jgib3botq@art_vandelay> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180130160244.p24of44jgib3botq@art_vandelay> X-Operating-System: Linux phenom 4.14.0-1-amd64 User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 30, 2018 at 11:02:44AM -0500, Sean Paul wrote: > On Tue, Jan 30, 2018 at 05:19:46PM +0200, Ville Syrjälä wrote: > > On Tue, Jan 30, 2018 at 10:09:27AM -0500, Sean Paul wrote: > > > On Tue, Jan 30, 2018 at 04:05:28AM -0600, Gustavo A. R. Silva wrote: > > > > Assign true or false to boolean variables instead of an integer value. > > > > > > > > This issue was detected with the help of Coccinelle. > > > > > > I suppose you could also fix up the other preferred assignment by adding !! > > > to the bitwise & operation. > > > > Assigning >1 to a bool is well defined. No need to clutter the code with > > !! imo. > > There are examples of both in the file already. I don't have strong feelings > either way. Yeah, I applied this one for now, we can do more color choice discussions with follow ups :-) Thanks for the patch. -Daniel > > Sea > > > > > > > > > It's also helpful to post the spatch in the commit message so others can > > > replicate your result (this case is pretty trivial, so less important). > > > > > > Sean > > > > > > > > > > > Signed-off-by: Gustavo A. R. Silva > > > > --- > > > > Changes in v2: > > > > - Use true for boolean value in add_detailed_mode as suggested by Daniel > > > > Vetter. > > > > - Update subject. > > > > > > > > drivers/gpu/drm/drm_edid.c | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > > > > index ddd5379..b1cb262 100644 > > > > --- a/drivers/gpu/drm/drm_edid.c > > > > +++ b/drivers/gpu/drm/drm_edid.c > > > > @@ -2767,7 +2767,7 @@ do_detailed_mode(struct detailed_timing *timing, void *c) > > > > > > > > drm_mode_probed_add(closure->connector, newmode); > > > > closure->modes++; > > > > - closure->preferred = 0; > > > > + closure->preferred = false; > > > > } > > > > } > > > > > > > > @@ -2784,7 +2784,7 @@ add_detailed_modes(struct drm_connector *connector, struct edid *edid, > > > > struct detailed_mode_closure closure = { > > > > .connector = connector, > > > > .edid = edid, > > > > - .preferred = 1, > > > > + .preferred = true, > > > > .quirks = quirks, > > > > }; > > > > > > > > -- > > > > 2.7.4 > > > > > > > > > > -- > > > Sean Paul, Software Engineer, Google / Chromium OS > > > _______________________________________________ > > > dri-devel mailing list > > > dri-devel@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > > -- > > Ville Syrjälä > > Intel OTC > > -- > Sean Paul, Software Engineer, Google / Chromium OS > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch