From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: [PATCH] drm: Print the pid when debug logging an ioctl error. Date: Tue, 30 Jan 2018 13:56:43 -0800 Message-ID: <20180130215643.11016-1-eric@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 436C66E06F for ; Wed, 31 Jan 2018 00:18:17 +0000 (UTC) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org V2hlbiB3ZSBkZWJ1ZyBwcmludCB3aGF0IGlvY3RsIHdlJ3JlIGNhbGxpbmcgaW50bywgd2UgaW5j bHVkZSB0aGUgcGlkLgpJZiB5b3UgaGF2ZSBtdWx0aXBsZSBwcm9jZXNzZXMgcmVuZGVyaW5nIHNp bXVsYXRhbmVvdXNseSwgdGhlIGVycm9yCnJldHVybiBhbHNvIG5lZWRzIHRoZSBwaWQgc28geW91 IGNhbiBzZWUgd2hpY2ggb2YgdGhlIGlvY3RsIGNhbGxzIHdhcwp0aGUgb25lIHRvIGZhaWwuCgpT aWduZWQtb2ZmLWJ5OiBFcmljIEFuaG9sdCA8ZXJpY0BhbmhvbHQubmV0PgotLS0KIGRyaXZlcnMv Z3B1L2RybS9kcm1faW9jdGwuYyB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigr KSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1faW9jdGwu YyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1faW9jdGwuYwppbmRleCBhOWFlNmRkMmQ1OTMuLjM4YzMw MjYwNzczOCAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9pb2N0bC5jCisrKyBiL2Ry aXZlcnMvZ3B1L2RybS9kcm1faW9jdGwuYwpAQCAtODQyLDcgKzg0Miw3IEBAIGxvbmcgZHJtX2lv Y3RsKHN0cnVjdCBmaWxlICpmaWxwLAogCWlmIChrZGF0YSAhPSBzdGFja19rZGF0YSkKIAkJa2Zy ZWUoa2RhdGEpOwogCWlmIChyZXRjb2RlKQotCQlEUk1fREVCVUcoInJldCA9ICVkXG4iLCByZXRj b2RlKTsKKwkJRFJNX0RFQlVHKCJwaWQ9JWQsIHJldCA9ICVkXG4iLCB0YXNrX3BpZF9ucihjdXJy ZW50KSwgcmV0Y29kZSk7CiAJcmV0dXJuIHJldGNvZGU7CiB9CiBFWFBPUlRfU1lNQk9MKGRybV9p b2N0bCk7Ci0tIAoyLjE1LjAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753561AbeAaASR (ORCPT ); Tue, 30 Jan 2018 19:18:17 -0500 Received: from anholt.net ([50.246.234.109]:55826 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752303AbeAaASQ (ORCPT ); Tue, 30 Jan 2018 19:18:16 -0500 From: Eric Anholt To: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, Eric Anholt Subject: [PATCH] drm: Print the pid when debug logging an ioctl error. Date: Tue, 30 Jan 2018 13:56:43 -0800 Message-Id: <20180130215643.11016-1-eric@anholt.net> X-Mailer: git-send-email 2.15.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When we debug print what ioctl we're calling into, we include the pid. If you have multiple processes rendering simulataneously, the error return also needs the pid so you can see which of the ioctl calls was the one to fail. Signed-off-by: Eric Anholt --- drivers/gpu/drm/drm_ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c index a9ae6dd2d593..38c302607738 100644 --- a/drivers/gpu/drm/drm_ioctl.c +++ b/drivers/gpu/drm/drm_ioctl.c @@ -842,7 +842,7 @@ long drm_ioctl(struct file *filp, if (kdata != stack_kdata) kfree(kdata); if (retcode) - DRM_DEBUG("ret = %d\n", retcode); + DRM_DEBUG("pid=%d, ret = %d\n", task_pid_nr(current), retcode); return retcode; } EXPORT_SYMBOL(drm_ioctl); -- 2.15.0