From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Change host locale from C to en_US.UTF-8 for reproducable builds
Date: Tue, 30 Jan 2018 23:38:07 +0100 [thread overview]
Message-ID: <20180130233807.3bb4b570@windsurf.home> (raw)
In-Reply-To: <20180128112205.15275-1-julius@kriukas.lt>
Hello,
On Sun, 28 Jan 2018 13:22:05 +0200, Julius Kriukas wrote:
> When BR2_REPRODUCIBLE is enabled building systemd fails with error:
>
> [1/1080] Generating systemd.bg.catalog with a meson_exe.py custom command.
> FAILED: catalog/systemd.bg.catalog
> /buildroot/output/host/bin/python3 /buildroot/output/host/bin/meson --internal exe /buildroot/output/build/systemd-236/build/meson-private/meson_exe_sed_232a0623cc7ce2cd67ec72ed784b76307102ed76.dat
> Warning: You are using 'ANSI_X3.4-1968' which is not a Unicode-compatible locale.
> You might see errors if you use UTF-8 strings as filenames, as strings, or as file contents.
> Please switch to a UTF-8 locale for your platform.
> ...
> UnicodeDecodeError: 'ascii' codec can't decode byte 0xd0 in position 1079: ordinal not in range(128)
> package/pkg-generic.mk:247: recipe for target '/buildroot/output/build/systemd-236/.stamp_built' failed
> make: *** [/buildroot/output/build/systemd-236/.stamp_built] Error 1
>
> Other packages using meson build system might fail as well.
>
> This patch changes default host system locale from C to en_US.UTF-8 to
> fix this issue. Any Unicode-compatible locale would be suitable here.
>
> Signed-off-by: Julius Kriukas <julius@kriukas.lt>
Thanks for your patch! I was about to apply it, but one issue I see is
that we have no guarantee that en_US.UTF-8 is available.
support/dependencies/dependencies.sh checks that we have at least one
UTF-8 locale available if BR2_NEEDS_HOST_UTF8_LOCALE=y, but:
- BR2_NEEDS_HOST_UTF8_LOCALE is only selected when a uClibc toolchain
is being built
- it only ensures one UTF-8 locale is available, not specifically
en_US.UTF-8
Perhaps we need another BR2_NEEDS_HOST_EN_US_UTF8_LOCALE, which would
be used by support/dependencies/dependencies.sh to ensure that
en_US.UTF-8 is available. This new option would be selected by
BR2_REPRODUCIBLE.
Arnout, Peter, Yann? Thoughts?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2018-01-30 22:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-28 11:22 [Buildroot] [PATCH 1/1] Change host locale from C to en_US.UTF-8 for reproducable builds Julius Kriukas
2018-01-30 22:38 ` Thomas Petazzoni [this message]
2018-01-31 21:34 ` Julius Kriukas
2018-01-31 21:36 ` [Buildroot] [PATCH v2] " Julius Kriukas
2018-02-04 15:19 ` Yann E. MORIN
2018-02-06 16:32 ` Thomas Petazzoni
2018-02-12 21:34 ` [Buildroot] [PATCH v3] systemd: switch to en_US.UTF-8 locale when building Julius Kriukas
2018-02-17 18:06 ` John Keeping
2018-02-22 23:02 ` Julius Kriukas
2018-02-22 23:00 ` [Buildroot] [PATCH v4] " Julius Kriukas
2018-02-28 21:31 ` Yann E. MORIN
2018-02-28 22:13 ` Thomas Petazzoni
2018-03-01 18:06 ` Yann E. MORIN
2018-03-01 18:50 ` Peter Korsgaard
2018-03-01 19:12 ` Yann E. MORIN
2018-03-01 20:04 ` Peter Korsgaard
2018-03-02 21:45 ` Thomas Petazzoni
[not found] ` <87vaecbsf2.fsf@paral.in>
2018-03-04 9:01 ` Yann E. MORIN
2018-02-23 9:06 ` [Buildroot] [PATCH v3] " Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180130233807.3bb4b570@windsurf.home \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.