From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Colin King <colin.king@canonical.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvdimm@lists.01.org
Subject: Re: [PATCH] libnvdimm, namespace: remove redundant initialization of 'nd_mapping'
Date: Tue, 30 Jan 2018 23:50:18 +0000 [thread overview]
Message-ID: <20180130235018.GE23836@linux.intel.com> (raw)
In-Reply-To: <20180130174707.4921-1-colin.king@canonical.com>
On Tue, Jan 30, 2018 at 05:47:07PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer nd_mapping is being initialized to a value that is never read,
> instead it is being updated to a new value in all the cases where it
> is being read afterwards, hence the initialization is redundant and
> can be removed.
>
> Cleans up clang warning:
> drivers/nvdimm/namespace_devs.c:2411:21: warning: Value stored to
> 'nd_mapping' during its initialization is never rea
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Sure, this looks good. Thanks.
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Colin King <colin.king@canonical.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvdimm@lists.01.org
Subject: Re: [PATCH] libnvdimm, namespace: remove redundant initialization of 'nd_mapping'
Date: Tue, 30 Jan 2018 16:50:18 -0700 [thread overview]
Message-ID: <20180130235018.GE23836@linux.intel.com> (raw)
In-Reply-To: <20180130174707.4921-1-colin.king@canonical.com>
On Tue, Jan 30, 2018 at 05:47:07PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer nd_mapping is being initialized to a value that is never read,
> instead it is being updated to a new value in all the cases where it
> is being read afterwards, hence the initialization is redundant and
> can be removed.
>
> Cleans up clang warning:
> drivers/nvdimm/namespace_devs.c:2411:21: warning: Value stored to
> 'nd_mapping' during its initialization is never rea
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Sure, this looks good. Thanks.
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Colin King <colin.king@canonical.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
linux-nvdimm@lists.01.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libnvdimm, namespace: remove redundant initialization of 'nd_mapping'
Date: Tue, 30 Jan 2018 16:50:18 -0700 [thread overview]
Message-ID: <20180130235018.GE23836@linux.intel.com> (raw)
In-Reply-To: <20180130174707.4921-1-colin.king@canonical.com>
On Tue, Jan 30, 2018 at 05:47:07PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer nd_mapping is being initialized to a value that is never read,
> instead it is being updated to a new value in all the cases where it
> is being read afterwards, hence the initialization is redundant and
> can be removed.
>
> Cleans up clang warning:
> drivers/nvdimm/namespace_devs.c:2411:21: warning: Value stored to
> 'nd_mapping' during its initialization is never rea
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Sure, this looks good. Thanks.
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
next prev parent reply other threads:[~2018-01-30 23:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 17:47 [PATCH] libnvdimm, namespace: remove redundant initialization of 'nd_mapping' Colin King
2018-01-30 17:47 ` Colin King
2018-01-30 23:50 ` Ross Zwisler [this message]
2018-01-30 23:50 ` Ross Zwisler
2018-01-30 23:50 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180130235018.GE23836@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.