From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm: Print the pid when debug logging an ioctl error. Date: Wed, 31 Jan 2018 09:07:28 +0100 Message-ID: <20180131080728.GV25930@phenom.ffwll.local> References: <20180130215643.11016-1-eric@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 306806E0B2 for ; Wed, 31 Jan 2018 08:07:32 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id f71so6194700wmf.0 for ; Wed, 31 Jan 2018 00:07:32 -0800 (PST) Content-Disposition: inline In-Reply-To: <20180130215643.11016-1-eric@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBKYW4gMzAsIDIwMTggYXQgMDE6NTY6NDNQTSAtMDgwMCwgRXJpYyBBbmhvbHQgd3Jv dGU6Cj4gV2hlbiB3ZSBkZWJ1ZyBwcmludCB3aGF0IGlvY3RsIHdlJ3JlIGNhbGxpbmcgaW50bywg d2UgaW5jbHVkZSB0aGUgcGlkLgo+IElmIHlvdSBoYXZlIG11bHRpcGxlIHByb2Nlc3NlcyByZW5k ZXJpbmcgc2ltdWxhdGFuZW91c2x5LCB0aGUgZXJyb3IKPiByZXR1cm4gYWxzbyBuZWVkcyB0aGUg cGlkIHNvIHlvdSBjYW4gc2VlIHdoaWNoIG9mIHRoZSBpb2N0bCBjYWxscyB3YXMKPiB0aGUgb25l IHRvIGZhaWwuCj4gCj4gU2lnbmVkLW9mZi1ieTogRXJpYyBBbmhvbHQgPGVyaWNAYW5ob2x0Lm5l dD4KClJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgoK PiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9pb2N0bC5jIHwgMiArLQo+ICAxIGZpbGUgY2hh bmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2RybV9pb2N0bC5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9pb2N0bC5jCj4g aW5kZXggYTlhZTZkZDJkNTkzLi4zOGMzMDI2MDc3MzggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2RybV9pb2N0bC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9pb2N0bC5jCj4g QEAgLTg0Miw3ICs4NDIsNyBAQCBsb25nIGRybV9pb2N0bChzdHJ1Y3QgZmlsZSAqZmlscCwKPiAg CWlmIChrZGF0YSAhPSBzdGFja19rZGF0YSkKPiAgCQlrZnJlZShrZGF0YSk7Cj4gIAlpZiAocmV0 Y29kZSkKPiAtCQlEUk1fREVCVUcoInJldCA9ICVkXG4iLCByZXRjb2RlKTsKPiArCQlEUk1fREVC VUcoInBpZD0lZCwgcmV0ID0gJWRcbiIsIHRhc2tfcGlkX25yKGN1cnJlbnQpLCByZXRjb2RlKTsK PiAgCXJldHVybiByZXRjb2RlOwo+ICB9Cj4gIEVYUE9SVF9TWU1CT0woZHJtX2lvY3RsKTsKPiAt LSAKPiAyLjE1LjAKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWwKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBD b3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753239AbeAaIHe (ORCPT ); Wed, 31 Jan 2018 03:07:34 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:54941 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752412AbeAaIHc (ORCPT ); Wed, 31 Jan 2018 03:07:32 -0500 X-Google-Smtp-Source: AH8x225kzTaAGKoxhtMDrJqu3+oeCJflltc+2F4HPJNiFxsaCNLySFn0gn3jIHdzDFix0bZb3ATLKQ== Date: Wed, 31 Jan 2018 09:07:28 +0100 From: Daniel Vetter To: Eric Anholt Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: Print the pid when debug logging an ioctl error. Message-ID: <20180131080728.GV25930@phenom.ffwll.local> Mail-Followup-To: Eric Anholt , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20180130215643.11016-1-eric@anholt.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180130215643.11016-1-eric@anholt.net> X-Operating-System: Linux phenom 4.14.0-1-amd64 User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 30, 2018 at 01:56:43PM -0800, Eric Anholt wrote: > When we debug print what ioctl we're calling into, we include the pid. > If you have multiple processes rendering simulataneously, the error > return also needs the pid so you can see which of the ioctl calls was > the one to fail. > > Signed-off-by: Eric Anholt Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/drm_ioctl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c > index a9ae6dd2d593..38c302607738 100644 > --- a/drivers/gpu/drm/drm_ioctl.c > +++ b/drivers/gpu/drm/drm_ioctl.c > @@ -842,7 +842,7 @@ long drm_ioctl(struct file *filp, > if (kdata != stack_kdata) > kfree(kdata); > if (retcode) > - DRM_DEBUG("ret = %d\n", retcode); > + DRM_DEBUG("pid=%d, ret = %d\n", task_pid_nr(current), retcode); > return retcode; > } > EXPORT_SYMBOL(drm_ioctl); > -- > 2.15.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch