From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm: Check for lessee in DROP_MASTER ioctl Date: Wed, 31 Jan 2018 09:13:43 +0100 Message-ID: <20180131081343.GY25930@phenom.ffwll.local> References: <20180119015159.1606-1-keithp@keithp.com> <20180130093447.GG25930@phenom.ffwll.local> <87k1vz3ywa.fsf@keithp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x22e.google.com (mail-wm0-x22e.google.com [IPv6:2a00:1450:400c:c09::22e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 642426E7B0 for ; Wed, 31 Jan 2018 08:13:47 +0000 (UTC) Received: by mail-wm0-x22e.google.com with SMTP id v71so6094193wmv.2 for ; Wed, 31 Jan 2018 00:13:47 -0800 (PST) Content-Disposition: inline In-Reply-To: <87k1vz3ywa.fsf@keithp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Keith Packard Cc: Dave Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBKYW4gMzAsIDIwMTggYXQgMTE6NTU6MDFBTSAtMDgwMCwgS2VpdGggUGFja2FyZCB3 cm90ZToKPiBEYW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+IHdyaXRlczoKPiAKPiA+IE9u IFRodSwgSmFuIDE4LCAyMDE4IGF0IDA1OjUxOjU5UE0gLTA4MDAsIEtlaXRoIFBhY2thcmQgd3Jv dGU6Cj4gPj4gRG9uJ3QgbGV0IGEgbGVzc2VlIGNvbnRyb2wgd2hhdCB0aGUgY3VycmVudCBEUk0g bWFzdGVyIGlzIHNldCB0bzsKPiA+PiB0aGF0J3MgdGhlIGpvYiBvZiB0aGUgInJlYWwiIG1hc3Rl ci4gT3RoZXJ3aXNlLCB0aGUgbGVzc2VlIHdvdWxkCj4gPj4gZGlzYWJsZSBhbGwgYWNjZXNzIHRv IG1hc3RlciBvcGVyYXRpb25zIGZvciB0aGUgb3duZXIgYW5kIGFsbCBsZXNzZWVzCj4gPj4gdW5k ZXIgaXQuCj4gPj4gCj4gPj4gVGhpcyBtYXRjaGVzIHRoZSBzYW1lIGNoZWNrIG1hZGUgaW4gdGhl IFNFVF9NQVNURVIgaW9jdGwuCj4gPj4gCj4gPj4gU2lnbmVkLW9mZi1ieTogS2VpdGggUGFja2Fy ZCA8a2VpdGhwQGtlaXRocC5jb20+Cj4gPgo+ID4gU2ltaWxhciBjaGVjayBmb3Igc2V0bWFzdGVy IGFscmVhZHkgZXhpc3RzLCBzbyBsb29rcyBhbGwgZ29vZC4gRG8gd2UgaGF2ZQo+ID4gYW4gaWd0 IGZvciBhbGwgdGhpcz8gSWlyYyB0aGVyZSB3YXMgb25lIGZsb2F0aW5nIGFyb3VuZCwgYnV0IG5v IGlkZWEKPiA+IHdoYXQncyB0aGUgc3RhdHVzLiBNaWdodCBhbHNvIGJlIGdvb2QgdG8gcmVzdWJt aXQgdGhlbSBzbyBpOTE1IENJIGNhbiBydW4KPiA+IHRoZSB0ZXN0cyAobm93IHRoYXQgdGhlIGNv ZGUgaGFzIGxhbmRlZCkuCj4gCj4gSSd2ZSBnb3QgSUdUIHRlc3RzIGZvciBsZWFzaW5nIHdoaWNo IGhhdmUgYmVlbiBwb3N0ZWQgdG8gZHJpLWRldmVsIGJ1dCBJCj4gZG9uJ3QgdGhpbmsgdGhleSd2 ZSBiZWVuIHJldmlld2VkLiBMb29rcyBsaWtlIHRoZXkgY291bGQgdXNlIHNvbWUgbW9yZQo+IHRl c3QgY2FzZXM7IEkgZGlkbid0IGNhdGNoIHRoaXMgb25lIHVudGlsIEkgd2FzIHBsYXlpbmcgd2l0 aCBteSAneGxlYXNlJwo+IGhhY2ssIHdoaWNoIHJ1bnMgdGhlIFggc2VydmVyIG9uIGEgbGVhc2Vk IEZELgoKQ2FuIHlvdSBwbHMgcmVzdWJtaXQgKHByZWZlcnJhYmx5IHdpdGggdGhlIG5ldyBuYXN0 eSB0ZXN0cyBhZGRlZCkgdG8KaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcgKHdlIGhhdmUg YSBuZXcgbS1sIGZvciBpZ3Qgc3R1ZmYpPwoKPiA+IE9uIHRoZSBwYXRjaCBpdHNlbGYsIG1pbnVz IGxhY2sgb2YgdGVzdGNhc2VzOgo+ID4KPiA+IFJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxk YW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+IAo+IFRoYW5rcyEKClJlYWxpemVkIEkgc2hvdWxkIGJl dHRlciBhcHBseSB0aGlzLCBhbmQgZG9uZSA6LSkKLURhbmllbAotLSAKRGFuaWVsIFZldHRlcgpT b2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753522AbeAaINt (ORCPT ); Wed, 31 Jan 2018 03:13:49 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:38525 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752558AbeAaINr (ORCPT ); Wed, 31 Jan 2018 03:13:47 -0500 X-Google-Smtp-Source: AH8x224HjK/OKiwjikWUl6opoD/7CmmbkBuJ4xHzm77ljoTIDpqhTMjf8rUVCxO+DFIR9DYpR/eFuA== Date: Wed, 31 Jan 2018 09:13:43 +0100 From: Daniel Vetter To: Keith Packard Cc: Daniel Vetter , linux-kernel@vger.kernel.org, Dave Airlie , dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm: Check for lessee in DROP_MASTER ioctl Message-ID: <20180131081343.GY25930@phenom.ffwll.local> Mail-Followup-To: Keith Packard , linux-kernel@vger.kernel.org, Dave Airlie , dri-devel@lists.freedesktop.org References: <20180119015159.1606-1-keithp@keithp.com> <20180130093447.GG25930@phenom.ffwll.local> <87k1vz3ywa.fsf@keithp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87k1vz3ywa.fsf@keithp.com> X-Operating-System: Linux phenom 4.14.0-1-amd64 User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 30, 2018 at 11:55:01AM -0800, Keith Packard wrote: > Daniel Vetter writes: > > > On Thu, Jan 18, 2018 at 05:51:59PM -0800, Keith Packard wrote: > >> Don't let a lessee control what the current DRM master is set to; > >> that's the job of the "real" master. Otherwise, the lessee would > >> disable all access to master operations for the owner and all lessees > >> under it. > >> > >> This matches the same check made in the SET_MASTER ioctl. > >> > >> Signed-off-by: Keith Packard > > > > Similar check for setmaster already exists, so looks all good. Do we have > > an igt for all this? Iirc there was one floating around, but no idea > > what's the status. Might also be good to resubmit them so i915 CI can run > > the tests (now that the code has landed). > > I've got IGT tests for leasing which have been posted to dri-devel but I > don't think they've been reviewed. Looks like they could use some more > test cases; I didn't catch this one until I was playing with my 'xlease' > hack, which runs the X server on a leased FD. Can you pls resubmit (preferrably with the new nasty tests added) to igt-dev@lists.freedesktop.org (we have a new m-l for igt stuff)? > > On the patch itself, minus lack of testcases: > > > > Reviewed-by: Daniel Vetter > > Thanks! Realized I should better apply this, and done :-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch