Re: [PATCH] Staging: speakup: Fixed a multiple assignment issue

From: Greg KH <gregkh@linuxfoundation.org>
To: Shannon Booth <shannon.ml.booth@gmail.com>
Cc: devel@driverdev.osuosl.org, speakup@linux-speakup.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: speakup: Fixed a multiple assignment issue
Date: Wed, 31 Jan 2018 09:41:04 +0100	[thread overview]
Message-ID: <20180131084104.GC32583@kroah.com> (raw)
In-Reply-To: <1517379545-31318-1-git-send-email-shannon.ml.booth@gmail.com>

On Wed, Jan 31, 2018 at 07:19:05PM +1300, Shannon Booth wrote:
> Fixed a coding style issue.
> 
> Signed-off-by: Shannon Booth <shannon.ml.booth@gmail.com>
> ---
>  drivers/staging/speakup/main.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
> index cf12590..b721f41 100644
> --- a/drivers/staging/speakup/main.c
> +++ b/drivers/staging/speakup/main.c
> @@ -261,9 +261,12 @@ static unsigned char get_attributes(struct vc_data *vc, u16 *pos)
>  
>  static void speakup_date(struct vc_data *vc)
>  {
> -	spk_x = spk_cx = vc->vc_x;
> -	spk_y = spk_cy = vc->vc_y;
> -	spk_pos = spk_cp = vc->vc_pos;
> +	spk_x =  vc->vc_x;
> +	spk_cx = vc->vc_x;
> +	spk_y = vc->vc_y;
> +	spk_cy = vc->vc_y;
> +	spk_pos =  vc->vc_pos;
> +	spk_cp = vc->vc_pos;

The original code looks much better than this, don't you agree?

Coding style is just a guideline, no need to change things that don't
make sense.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel