From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] dma-fence: add comment for WARN_ON in dma_fence_release() Date: Wed, 31 Jan 2018 11:18:58 +0100 Message-ID: <20180131101741.GA3924@phenom.ffwll.local> References: <20180129154002.3287-1-oded.gabbay@gmail.com> <20180130103318.GQ25930@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4EACC6E458 for ; Wed, 31 Jan 2018 10:19:09 +0000 (UTC) Received: by mail-wm0-x241.google.com with SMTP id b21so6869677wme.4 for ; Wed, 31 Jan 2018 02:19:09 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Oded Gabbay Cc: Maling list - DRI developers List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBKYW4gMzEsIDIwMTggYXQgMTE6MDM6MzlBTSArMDIwMCwgT2RlZCBHYWJiYXkgd3Jv dGU6Cj4gT24gVHVlLCBKYW4gMzAsIDIwMTggYXQgMTI6MzMgUE0sIERhbmllbCBWZXR0ZXIgPGRh bmllbEBmZndsbC5jaD4gd3JvdGU6Cj4gPiBPbiBNb24sIEphbiAyOSwgMjAxOCBhdCAwNTo0MDow MlBNICswMjAwLCBPZGVkIEdhYmJheSB3cm90ZToKPiA+PiBJbiBkbWFfZmVuY2VfcmVsZWFzZSgp IHRoZXJlIGlzIGEgV0FSTl9PTiB3aGljaCBjb3VsZCBiZSB0cmlnZ2VyZWQgYnkKPiA+PiBzZXZl cmFsIGNhc2VzIG9mIHdyb25nIGRtYS1mZW5jZSB1c2FnZS4gVGhpcyBwYXRjaCBhZGRzIGEgY29t bWVudCB0bwo+ID4+IGV4cGxhaW4gdHdvIHVzZS1jYXNlcyB0byBoZWxwIGRyaXZlciBkZXZlbG9w ZXJzIHRoYXQgdXNlIGRtYS1mZW5jZQo+ID4+IGFuZCB0cmlnZ2VyIHRoYXQgV0FSTl9PTiB0byBi ZXR0ZXIgdW5kZXJzdGFuZCB0aGUgcmVhc29ucyBmb3IgaXQuCj4gPj4KPiA+PiBTaWduZWQtb2Zm LWJ5OiBPZGVkIEdhYmJheSA8b2RlZC5nYWJiYXlAZ21haWwuY29tPgo+ID4KPiA+IE5vdCBzdXJl IGhvdyB1c2VmdWwgdGhpcyBpcywgdHJ5aW5nIHRvIGRvIGFueXRoaW5nIHdpdGggYSBkbWFfZmVu Y2Ugd2hpbGUKPiA+IG5vdCBob2xkaW5nIGEgcmVmZXJlbmNlIGlzIGp1c3QgcGxhaW4gYnVnZ3ku IElmIHlvdSBkbyB0aGF0LCB0aGVuIGFsbAo+ID4ga2luZHMgb2YgdXNlLWFmdGVyLWZyZWUgaGls YXJpdHkgY2FuIGhhcHBlbi4gVHJ5aW5nIHRvIGVudW1lcmF0ZSBhbGwgdGhlCj4gPiB3YXlzIHlv dSBjYW4gZ2V0IHJlZmNvdW50aW5nIHdyb25nIHNlZW1zIGZ1dGlsZS4KPiA+Cj4gPiBXaGF0IHdl IG1heWJlIGNvdWxkIGRvIGlzIGEgc2ltcGxlIG9uZS1saW5lIGxpa2UKPiA+Cj4gPiAgICAgICAg IC8qIEZhaWxlZCB0byBzaWduYWwgYmVmb3JlIHJlbGVhc2UsIGNvdWxkIGJlIGEgcmVmY291bnRp bmcgaXNzdWUuICovCj4gPgo+ID4gSSB0aGluayB0aGlzIGlzIGdlbmVyYWxseSBhIHRydWUgc3Rh dGVtZW50IGFuZCBtb3JlIHVzZWZ1bCBoaW50IGZvciB0aGUKPiA+IG5leHQgY29udm9sdXRlZCBz Y2VuYXJpbyAod2hpY2ggaW4gYWxsIGxpa2VsaWhvb2Qgd2lsbCBiZSBkaWZmZXJlbnQgZnJvbQo+ ID4geW91cnMpLgo+ID4gLURhbmllbAo+ID4KPiA+PiAtLS0KPiA+PiAgZHJpdmVycy9kbWEtYnVm L2RtYS1mZW5jZS5jIHwgMzMgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gPj4g IDEgZmlsZSBjaGFuZ2VkLCAzMyBpbnNlcnRpb25zKCspCj4gPj4KPiA+PiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9kbWEtYnVmL2RtYS1mZW5jZS5jIGIvZHJpdmVycy9kbWEtYnVmL2RtYS1mZW5jZS5j Cj4gPj4gaW5kZXggNWQxMDFjNDA1M2UwLi5hNzE3MGFiMjNlYzAgMTAwNjQ0Cj4gPj4gLS0tIGEv ZHJpdmVycy9kbWEtYnVmL2RtYS1mZW5jZS5jCj4gPj4gKysrIGIvZHJpdmVycy9kbWEtYnVmL2Rt YS1mZW5jZS5jCj4gPj4gQEAgLTE3MSw2ICsxNzEsMzkgQEAgdm9pZCBkbWFfZmVuY2VfcmVsZWFz ZShzdHJ1Y3Qga3JlZiAqa3JlZikKPiA+Pgo+ID4+ICAgICAgIHRyYWNlX2RtYV9mZW5jZV9kZXN0 cm95KGZlbmNlKTsKPiA+Pgo+ID4+ICsgICAgIC8qCj4gPj4gKyAgICAgICogSWYgdGhlIFdBUk5f T04gYmVsb3cgaXMgdHJpZ2dlcmVkIGl0IGNvdWxkIGJlIGJlY2F1c2UgdGhlIGRtYSBmZW5jZQo+ ID4+ICsgICAgICAqIHdhcyBub3Qgc2lnbmFsZWQgYW5kIHRoZXJlZm9yZSwgdGhlIGNiIGxpc3Qg aXMgc3RpbGwgbm90IGVtcHR5Cj4gPj4gKyAgICAgICogYmVjYXVzZSB0aGUgY2IgZnVuY3Rpb25z IHdlcmUgbm90IGNhbGxlZC4KPiA+PiArICAgICAgKgo+ID4+ICsgICAgICAqIEEgbW9yZSBzdWJ0 bGUgY2FzZSBpcyB3aGVyZSB0aGUgZmVuY2UgZ290IHNpZ25hbGVkIGJ5IGEgdGhyZWFkIHRoYXQK PiA+PiArICAgICAgKiBkaWRuJ3QgaG9sZCBhIHJlZiB0byB0aGUgZmVuY2UuIFRoZSBmb2xsb3dp bmcgZGVzY3JpYmVzIHRoZSBzY2VuYXJpbzoKPiA+PiArICAgICAgKgo+ID4+ICsgICAgICAqICAg ICAgVGhyZWFkIEEgICAgICAgICAgICAgICAgICAgICAgICAgICAgVGhyZWFkIEIKPiA+PiArICAg ICAgKi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tICAgICAgICAtLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLQo+ID4+ICsgICAgICAqIGNhbGxzIGRtYV9mZW5jZV9zaWduYWwoKSB7Cj4gPj4gKyAg ICAgICogICAgICBzZXQgc2lnbmFsIGJpdAo+ID4+ICsgICAgICAqCj4gPj4gKyAgICAgICogICAg ICAgICAgICBzY2hlZHVsZWQgb3V0Cj4gPj4gKyAgICAgICogICAgICAtLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0+IGNhbGxzIGRtYV9mZW5jZV93YWl0X3RpbWVvdXQoKSBhbmQKPiA+PiArICAg ICAgKiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJucyBpbW1lZGlhdGVs eQo+ID4+ICsgICAgICAqCj4gPj4gKyAgICAgICogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGNhbGxzIGRtYV9mZW5jZV9wdXQoKQo+ID4+ICsgICAgICAqICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICB8Cj4gPj4gKyAgICAgICogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHx0aHJlYWQgQSBkb2Vzbid0IGhvbGQgcmVmCj4gPj4g KyAgICAgICogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHx0byBmZW5j ZSBzbyByZWYgZ29lcyB0byAwCj4gPj4gKyAgICAgICogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHxhbmQgcmVsZWFzZSBpcyBjYWxsZWQKPiA+PiArICAgICAgKiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfAo+ID4+ICsgICAgICAqICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAtPiBkbWFfZmVuY2VfcmVsZWFzZSgp Cj4gPj4gKyAgICAgICogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHwKPiA+PiArICAgICAgKiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgLT4gV0FSTl9PTiB0cmlnZ2VyZWQKPiA+PiArICAgICAgKgo+ID4+ICsgICAgICAqICAgICAg Z28gb3ZlciBDQiBsaXN0LAo+ID4+ICsgICAgICAqICAgICAgY2FsbCBlYWNoIENCIGFuZCByZW1v dmUgaXQKPiA+PiArICAgICAgKiAgICAgIH0KPiA+PiArICAgICAgKgo+ID4+ICsgICAgICAqCj4g Pj4gKyAgICAgICovCj4gPj4gICAgICAgV0FSTl9PTighbGlzdF9lbXB0eSgmZmVuY2UtPmNiX2xp c3QpKTsKPiA+Pgo+ID4+ICAgICAgIGlmIChmZW5jZS0+b3BzLT5yZWxlYXNlKQo+ID4+IC0tCj4g Pj4gMi4xNC4zCj4gPj4KPiA+Cj4gPiAtLQo+ID4gRGFuaWVsIFZldHRlcgo+ID4gU29mdHdhcmUg RW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCj4gPiBodHRwOi8vYmxvZy5mZndsbC5jaAo+IAo+ IEhpIERhbmllbCwKPiBZZWFoLCBJIGdldCB3aGF0IHlvdSBhcmUgc2F5aW5nLgo+IENhbiBJIGFk ZCB5b3VyIFJCIHRvIHRoZSBvbmUtbGluZXIgdmVyc2lvbiA/CgpTdXJlLgoKUmV2aWV3ZWQtYnk6 IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+CgpDaGVlcnMsIERhbmllbAot LSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0 cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsCg==