From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukas Wunner Subject: Re: [PATCH] Revert "apple-gmux: lock iGP IO to protect from vgaarb changes" Date: Wed, 31 Jan 2018 20:44:20 +0100 Message-ID: <20180131194420.GA5409@wunner.de> References: <3671c3081a0ea3226dbb4c04e780ad7b6be0f201.1516793407.git.lukas@wunner.de> <20180125223800.GG24122@fury> <20180131183925.GA8676@fury> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Received: from bmailout3.hostsharing.net ([176.9.242.62]:60135 "EHLO bmailout3.hostsharing.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750742AbeAaToW (ORCPT ); Wed, 31 Jan 2018 14:44:22 -0500 Content-Disposition: inline In-Reply-To: <20180131183925.GA8676@fury> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Darren Hart Cc: Andy Shevchenko , platform-driver-x86@vger.kernel.org, Petri Hodju , Bjorn Helgaas , Bruno Premont , Andy Ritger , Ronald Tschalaer , Wilfried Klaebe On Wed, Jan 31, 2018 at 10:39:25AM -0800, Darren Hart wrote: > On Thu, Jan 25, 2018 at 02:38:00PM -0800, Darren Hart wrote: > > On Wed, Jan 24, 2018 at 07:35:45PM +0100, Lukas Wunner wrote: > > > Commit 4eebd5a4e726 ("apple-gmux: lock iGP IO to protect from vgaarb > > > changes") amended this driver's ->probe hook to lock decoding of normal > > > (non-legacy) I/O space accesses to the integrated GPU on dual-GPU > > > MacBook Pros. The lock stays in place until the driver is unbound. > > > > > ... > > > > > > So let's revert commit 4eebd5a4e726 please. Users experiencing the > > > issue with the proprietary nvidia driver can comment out the above- > > > quoted problematic code as a workaround (or try updating the BIOS). > > > > > > Cc: Petri Hodju > > > Cc: Bjorn Helgaas > > > Cc: Bruno Prémont > > > Cc: Andy Ritger > > > Cc: Ronald Tschalär > > > > I presume we'd like to see this applied to linux-stable as well? > > I haven't heard back I did reply to your e-mail on Jan 26, quote: "Fine by me. Can you add the stable designation when applying or would you prefer me to respin?" https://www.spinics.net/lists/platform-driver-x86/msg14690.html > but from what I've seen in this thread, this appears to me > to be in need of porting back to stable releases. > I'm pushing this to testing, and then shortly to for-next, and then to Linus. > Please let me know if this isn't what everyone is expecting. WFM, thanks! Lukas