From: "Martin Hundebøll" <mnhu@prevas.dk>
To: Jean Delvare <jdelvare@suse.com>, <linux-kernel@vger.kernel.org>
Cc: "Martin Hundebøll" <mnhu@prevas.dk>
Subject: [PATCH] firmware: dmi_scan: avoid printing error on non-efi systems
Date: Thu, 1 Feb 2018 09:08:05 +0100 [thread overview]
Message-ID: <20180201080805.8076-1-mnhu@prevas.dk> (raw)
dmi_init() rightfully checks if dmi is available at all, and errors out
if not. This leads to harmless errors being printed during boot on
non-efi systems, even when these are booted quietly.
Avoid this error-print by returning directly from dmi_init() if dmi
isn't available, instead of jumping to the err-label.
Signed-off-by: Martin Hundebøll <mnhu@prevas.dk>
---
drivers/firmware/dmi_scan.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c
index 783041964439..86c5e0625a08 100644
--- a/drivers/firmware/dmi_scan.c
+++ b/drivers/firmware/dmi_scan.c
@@ -715,10 +715,8 @@ static int __init dmi_init(void)
u8 *dmi_table;
int ret = -ENOMEM;
- if (!dmi_available) {
- ret = -ENODATA;
- goto err;
- }
+ if (!dmi_available)
+ return -ENODATA;
/*
* Set up dmi directory at /sys/firmware/dmi. This entry should stay
--
2.16.1
next reply other threads:[~2018-02-01 8:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 8:08 Martin Hundebøll [this message]
2018-02-02 7:00 ` [PATCH] firmware: dmi_scan: avoid printing error on non-efi systems Jean Delvare
2018-02-02 10:51 ` Martin Hundebøll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180201080805.8076-1-mnhu@prevas.dk \
--to=mnhu@prevas.dk \
--cc=jdelvare@suse.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.