All of lore.kernel.org
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] nvme: Fix discard buffer overrun
Date: Thu, 1 Feb 2018 08:05:34 -0700	[thread overview]
Message-ID: <20180201150533.GG27735@localhost.localdomain> (raw)
In-Reply-To: <9d61fdbe-ff60-2cf7-0d57-0bbb7133473f@oracle.com>

On Thu, Feb 01, 2018@10:55:30PM +0800, jianchao.wang wrote:
> Hi Keith
> 
> Since each discard bio merged into a request is counted as one segment,
> why not let blk_rq_nr_discard_segments return numbers of bios directly.

Right, I'm all for fixing the discard segment count. At the same time,
I don't want to depend on it's correctness to not access out-of-bounds
array indices.

  reply	other threads:[~2018-02-01 15:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-01  0:01 [PATCH] nvme: Fix discard buffer overrun Keith Busch
2018-02-01 14:55 ` jianchao.wang
2018-02-01 15:05   ` Keith Busch [this message]
2018-02-01 15:07     ` jianchao.wang
2018-02-01 15:27   ` Jens Axboe
2018-02-02  1:50     ` jianchao.wang
2018-02-02  3:19 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180201150533.GG27735@localhost.localdomain \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.