From: James Hogan <jhogan@kernel.org>
To: Luis de Bethencourt <luisbg@kernel.org>
Cc: linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>,
Ralf Baechle <ralf@linux-mips.org>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: Fix trailing semicolon
Date: Thu, 1 Feb 2018 16:08:01 +0000 [thread overview]
Message-ID: <20180201160801.GN7637@saruman> (raw)
In-Reply-To: <20180123133803.26789-1-luisbg@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1269 bytes --]
On Tue, Jan 23, 2018 at 01:38:03PM +0000, Luis de Bethencourt wrote:
> The trailing semicolon is an empty statement that does no operation.
> Removing it since it doesn't do anything.
>
> Signed-off-by: Luis de Bethencourt <luisbg@kernel.org>
Applied to my 4.16 branch,
Thanks
James
> ---
>
> Hi,
>
> After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
> suggested I fix it treewide [0].
>
> Best regards
> Luis
>
>
> [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
> [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
>
> arch/mips/include/asm/checksum.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/include/asm/checksum.h b/arch/mips/include/asm/checksum.h
> index 77cad232a1c6..e8161e4dfde7 100644
> --- a/arch/mips/include/asm/checksum.h
> +++ b/arch/mips/include/asm/checksum.h
> @@ -110,7 +110,7 @@ __wsum csum_partial_copy_nocheck(const void *src, void *dst,
> */
> static inline __sum16 csum_fold(__wsum csum)
> {
> - u32 sum = (__force u32)csum;;
> + u32 sum = (__force u32)csum;
>
> sum += (sum << 16);
> csum = (sum < csum);
> --
> 2.15.1
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-02-01 16:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 13:38 [PATCH] MIPS: Fix trailing semicolon Luis de Bethencourt
2018-02-01 16:08 ` James Hogan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180201160801.GN7637@saruman \
--to=jhogan@kernel.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=luisbg@kernel.org \
--cc=ralf@linux-mips.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.