Re: [meta-oe][PATCH 2/2] samba, openwsman, pam-ssh-agent-auth, sblim-sfcb, passwdqc, python-pam, smbnetfs: require pam in DISTRO_FEATURES

[Andreas Oberritter <obi@opendreambox.org>]

Hi Martin,

On Thu,  1 Feb 2018 14:23:40 +0000
Martin Jansa <martin.jansa@gmail.com> wrote:

> * there is explicit dependency on libpam without respecting pam in DISTRO_FEATURES
>   so add the check to prevent people building it against broken libpam

[...]
 
> --- a/meta-networking/recipes-connectivity/samba/samba_4.7.0.bb
> +++ b/meta-networking/recipes-connectivity/samba/samba_4.7.0.bb
> @@ -40,9 +40,10 @@ inherit systemd waf-samba cpan-base perlnative update-rc.d
>  # remove default added RDEPENDS on perl
>  RDEPENDS_${PN}_remove = "perl"
>  
> -#DEPENDS += "readline virtual/libiconv zlib popt libtalloc libtdb libtevent libldb libbsd libaio libpam"
> -DEPENDS += "readline virtual/libiconv zlib popt libtalloc libtdb libtevent libbsd libaio libpam"
> -DEPENDS += "libldb"
> +DEPENDS += "readline virtual/libiconv zlib popt libtalloc libtdb libtevent libldb libbsd libaio libpam"
> +
> +inherit distro_features_check
> +REQUIRED_DISTRO_FEATURES = "pam"

AFAIR, Samba doesn't build without libpam, but runs fine without a PAM
installation. Which problem you're trying to solve? I guess it's fair
to expect a dysfunctional PAM library without the 'pam' distro feature.

Regards,
Andreas