From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,5/6] dmaengine: hidma: Constify returned by device_get_match_data() value From: Andy Shevchenko Message-Id: <20180201202012.36524-5-andriy.shevchenko@linux.intel.com> Date: Thu, 1 Feb 2018 22:20:11 +0200 To: dmaengine , "Rafael J . Wysocki" , linux-acpi@vger.kernel.org Cc: Andy Shevchenko , Sinan Kaya , Sakari Ailus , Vinod Koul List-ID: VGhlIHZhbHVlIHVuZGVyIHRoZSBob29kIGlzIGNvbnN0YW50IGluIGFueSBjYXNlLgpJdCBtYWtl cyBzZW5zZSB0byBzaG93IHRoaXMgZXhwbGljaXRseS4KCkZpeGVzOiA5NWZiZmI3YWEyOGQgKCJk bWFlbmdpbmU6IHFjb21faGlkbWE6IEFkZCBzdXBwb3J0IGZvciB0aGUgbmV3IHJldmlzaW9uIikK Q2M6IFNpbmFuIEtheWEgPG9rYXlhQGNvZGVhdXJvcmEub3JnPgpDYzogU2FrYXJpIEFpbHVzIDxz YWthcmkuYWlsdXNAbGludXguaW50ZWwuY29tPgpDYzogVmlub2QgS291bCA8dmlub2Qua291bEBp bnRlbC5jb20+ClNpZ25lZC1vZmYtYnk6IEFuZHkgU2hldmNoZW5rbyA8YW5kcml5LnNoZXZjaGVu a29AbGludXguaW50ZWwuY29tPgotLS0KIGRyaXZlcnMvZG1hL3Fjb20vaGlkbWEuYyB8IDQgKyst LQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYg LS1naXQgYS9kcml2ZXJzL2RtYS9xY29tL2hpZG1hLmMgYi9kcml2ZXJzL2RtYS9xY29tL2hpZG1h LmMKaW5kZXggOTYzY2M1MjI4ZDA1Li4yNGUxNjNjZWZiN2MgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMv ZG1hL3Fjb20vaGlkbWEuYworKysgYi9kcml2ZXJzL2RtYS9xY29tL2hpZG1hLmMKQEAgLTc0Myw5 ICs3NDMsOSBAQCBzdGF0aWMgaW50IGhpZG1hX3JlcXVlc3RfbXNpKHN0cnVjdCBoaWRtYV9kZXYg KmRtYWRldiwKIAogc3RhdGljIGJvb2wgaGlkbWFfdGVzdF9jYXBhYmlsaXR5KHN0cnVjdCBkZXZp Y2UgKmRldiwgZW51bSBoaWRtYV9jYXAgdGVzdF9jYXApCiB7Ci0JZW51bSBoaWRtYV9jYXAgY2Fw OworCWNvbnN0IGVudW0gaGlkbWFfY2FwIGNhcDsKIAotCWNhcCA9IChlbnVtIGhpZG1hX2NhcCkg ZGV2aWNlX2dldF9tYXRjaF9kYXRhKGRldik7CisJY2FwID0gKGNvbnN0IGVudW0gaGlkbWFfY2Fw KSBkZXZpY2VfZ2V0X21hdGNoX2RhdGEoZGV2KTsKIAlyZXR1cm4gY2FwID8gKChjYXAgJiB0ZXN0 X2NhcCkgPiAwKSA6IDA7CiB9CiAK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: [PATCH v2 5/6] dmaengine: hidma: Constify returned by device_get_match_data() value Date: Thu, 1 Feb 2018 22:20:11 +0200 Message-ID: <20180201202012.36524-5-andriy.shevchenko@linux.intel.com> References: <20180201202012.36524-1-andriy.shevchenko@linux.intel.com> Return-path: Received: from mga07.intel.com ([134.134.136.100]:50516 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754703AbeBAUUQ (ORCPT ); Thu, 1 Feb 2018 15:20:16 -0500 In-Reply-To: <20180201202012.36524-1-andriy.shevchenko@linux.intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: dmaengine , "Rafael J . Wysocki" , linux-acpi@vger.kernel.org Cc: Andy Shevchenko , Sinan Kaya , Sakari Ailus , Vinod Koul The value under the hood is constant in any case. It makes sense to show this explicitly. Fixes: 95fbfb7aa28d ("dmaengine: qcom_hidma: Add support for the new revision") Cc: Sinan Kaya Cc: Sakari Ailus Cc: Vinod Koul Signed-off-by: Andy Shevchenko --- drivers/dma/qcom/hidma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c index 963cc5228d05..24e163cefb7c 100644 --- a/drivers/dma/qcom/hidma.c +++ b/drivers/dma/qcom/hidma.c @@ -743,9 +743,9 @@ static int hidma_request_msi(struct hidma_dev *dmadev, static bool hidma_test_capability(struct device *dev, enum hidma_cap test_cap) { - enum hidma_cap cap; + const enum hidma_cap cap; - cap = (enum hidma_cap) device_get_match_data(dev); + cap = (const enum hidma_cap) device_get_match_data(dev); return cap ? ((cap & test_cap) > 0) : 0; } -- 2.15.1