From: Greg KH <gregkh@linuxfoundation.org>
To: Wang Han <wanghan1995315@gmail.com>
Cc: stable@vger.kernel.org, davem@davemloft.net
Subject: Re: A question about commit 6c16fa backported in 3.18.93
Date: Fri, 2 Feb 2018 10:37:07 +0100 [thread overview]
Message-ID: <20180202093707.GB15060@kroah.com> (raw)
In-Reply-To: <CAFfSv_0Dq0E=FgTx92eNk1yzmNEKFRniX9YoOZjSYM+nnsgRaQ@mail.gmail.com>
On Fri, Feb 02, 2018 at 10:58:02AM +0800, Wang Han wrote:
> Hello, I am not familiar with Linux mailing, sorry for this.
>
> I am writing this mail because I am not sure about commit
> 6c16fa957e84c8b640dadc4e0264ff0d2dae7aa3 added in 3.18.93.
>
> That backport made the arp.h changes in struct __ipv4_neigh_lookup(),
> but compared with upstream commit, I think that 3 lines should be
> added in __ipv4_neigh_lookup_noref(), as I go through the context.
> Also the latter would be called unconditionally if former is called so
> it would cover more cases.
>
> Could you please check this and let me know? Though it would 90% be my derp.
You might be right, I did the backport of this by hand, and odds are I
got it wrong. Thanks for checking this and finding the issue.
Could you send me a patch to fix this up so I can apply it to the next
3.18.y release and give you the proper credit for it?
thanks,
greg k-h
next prev parent reply other threads:[~2018-02-02 9:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 2:58 A question about commit 6c16fa backported in 3.18.93 Wang Han
2018-02-02 9:37 ` Greg KH [this message]
2018-02-06 1:17 ` Wang Han
2018-02-07 23:18 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180202093707.GB15060@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=davem@davemloft.net \
--cc=stable@vger.kernel.org \
--cc=wanghan1995315@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.