From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/2] network-manager: Bump to version 1.10.2
Date: Fri, 2 Feb 2018 11:56:35 +0100 [thread overview]
Message-ID: <20180202115635.0fdaab93@windsurf.lan> (raw)
In-Reply-To: <20180201234516.5031-1-petr.vorel@gmail.com>
Hello,
On Fri, 2 Feb 2018 00:45:15 +0100, Petr Vorel wrote:
> +ifeq ($(BR2_PACKAGE_JANSSON),y)
> +NETWORK_MANAGER_CONF_OPTS += --enable-ovs
> +NETWORK_MANAGER_DEPENDENCIES += jansson
> +else
> +NETWORK_MANAGER_CONF_OPTS += --disable-ovs
> +endif
It is somewhat weird to introduce this here, and then add an explicit
option in a second patch.
Perhaps PATCH 1/2 could just do --disable-ovs unconditionally, and
PATCH 2/2 add the rest. If you agree, I can rework locally before
applying, I understand it's a lot of nitpicking for such a small
change :)
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
next prev parent reply other threads:[~2018-02-02 10:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 23:45 [Buildroot] [PATCH v2 1/2] network-manager: Bump to version 1.10.2 Petr Vorel
2018-02-01 23:45 ` [Buildroot] [PATCH v2 2/2] network-manager: Add option OpenVSwitch support Petr Vorel
2018-02-02 10:56 ` Thomas Petazzoni [this message]
2018-02-02 13:35 ` [Buildroot] [PATCH v2 1/2] network-manager: Bump to version 1.10.2 Petr Vorel
2018-02-03 22:24 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180202115635.0fdaab93@windsurf.lan \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.