From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Remove spurious DRM_ERROR for
 cancelled interrupts
Date: Fri, 2 Feb 2018 18:03:36 +0200
Message-ID: <20180202160336.GC5453@intel.com>
References: <20180202153448.23908-1-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 034FE6F064
 for <intel-gfx@lists.freedesktop.org>; Fri,  2 Feb 2018 16:03:41 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20180202153448.23908-1-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBGZWIgMDIsIDIwMTggYXQgMDM6MzQ6NDhQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy
b3RlOgo+IEFzIHdlIG91cnNlbHZlcyBjYW5jZWwgaW50ZXJydXB0cyBkdXJpbmcgcmVzZXQgYnkg
Y2xlYXJpbmcgdGhlIEdUSUlSLCBpdAo+IGlzIHBvc3NpYmxlIGZvciB0aGUgbWFzdGVyIElJUiB0
byBpbmRpY2F0ZSBhIHBlbmRpbmcgSVJRIGZvciB3aGljaCB3ZQo+IGhhdmUgYWxyZWFkeSBjbGVh
cmVkIGZyb20gdGhlIEdUSUlSLiBJbiB0aGlzIGNhc2UsIHRoZSBEUk1fRVJST1IgYXJlCj4gaW50
ZW5kZWQgYW5kIHNob3VsZCBub3QgYmUgZmxhZ2dlZCBhcyBhbiBlcnJvci4KCkkgZ3Vlc3MgYW4g
YWx0ZXJuYXRpdmUgd291bGQgYmUgdG8gbm90IGNsZWFyIElJUiBhbmQgdXNlCnN5Y2hyb25pemVf
aXJxKCkgaW5zdGVhZCBhcyBuZWVkZWQuIEJ1dCBJIHN1cHBvc2UgdGhhdCBkb2Vzbid0CnJlYWxs
eSBwcm92aWRlIGFueSByZWFsIGJlbmVmaXRzLgoKT25lIGNvbmNlcm4gaXMgdGhhdCB3ZSB3aWxs
IG5vdyBjbGFpbSB0aGF0IGFsbCBpbnRlcnJ1cHRzIGFyZSBoYW5kbGVkLAphbmQgdGh1cyBjb3Vs
ZG4ndCBkZXRlY3Qgc3B1cmlvdXMgaW50ZXJydXB0cy4gQnV0IG9uZSBtaWdodCBob3BlIHRoYXQK
TVNJIGFuZCB3aGFub3QgaGFzIG1hZGUgdGhvc2UgYSB0aGluZyBvZiB0aGUgcGFzdC4KCkkgbmV2
ZXIgY2hlY2tlZCB3aGF0IHRoZSBrZXJuZWwncyB0aHJlc2hvbGQgd2FzIGZvciBkaXNhYmxpbmcg
dGhlCmludGVycnVwdCBsaW5lIG9uIHNwdXJpb3VzIGludGVycnVwdHMuIEkgaGF2ZSBvY2Nhc2lv
bmFsbHkgdGhvdWdodCBhYm91dAppdCB0aG91Z2ggYXMgSSB0b28gaGF2ZSByZWFsaXplZCB0aGF0
IHRoZSBJSVIgY2xlYXJpbmcgY291bGQgcmVzdWx0IGluCnRoZSBpbnRlcnJ1cHQgaGFuZGxlciBo
YXZpbmcgbm90aGluZyB0byBkby4KClNvIHllYWgsIG5vdCBxdWl0ZSBzdXJlIHdoaWNoIGlzIGJl
c3QsIGFsd2F5cyBjbGFpbWluZyBJUlFfSEFORExFRCBvcgpvbmx5IHdoZW4gd2UgaGFkIHNvbWUg
SUlSIGJpdHMgdG8gY2xlYXIuIE1heWJlIGp1c3QgcmV0dXJuIElSUV9IQU5ETEVECmFsd2F5cyBm
b3IgYWxsIE1TSSBjYXBhYmxlIHBsYXRmb3Jtcz8KClJhbWJsaW5ncyBhc2lkZSwgSSB0aGluayB0
aGlzIHNob3VsZCBiZSBzYWZlIGVub3VnaDoKUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8
dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cgo+IAo+IFNpZ25lZC1vZmYtYnk6IENocmlz
IFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBKb29uYXMgTGFodGluZW4g
PGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0
dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3ly
amFsYUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IEltcmUgRGVhayA8aW1yZS5kZWFrQGludGVsLmNv
bT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYyB8IDM1ICsrKysrKysr
Ky0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA5IGluc2VydGlv
bnMoKyksIDI2IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v
aTkxNS9pOTE1X2lycS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+IGluZGV4
IDI1MmZlZmYyODkyZC4uYjg4NmJkNDU5YWNjIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2k5MTVfaXJxLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5j
Cj4gQEAgLTE0MTMsMzcgKzE0MTMsMjUgQEAgZ2VuOF9jc19pcnFfaGFuZGxlcihzdHJ1Y3QgaW50
ZWxfZW5naW5lX2NzICplbmdpbmUsIHUzMiBpaXIsIGludCB0ZXN0X3NoaWZ0KQo+ICAJCXRhc2ts
ZXRfaGlfc2NoZWR1bGUoJmV4ZWNsaXN0cy0+dGFza2xldCk7Cj4gIH0KPiAgCj4gLXN0YXRpYyBp
cnFyZXR1cm5fdCBnZW44X2d0X2lycV9hY2soc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w
cml2LAo+IC0JCQkJICAgdTMyIG1hc3Rlcl9jdGwsCj4gLQkJCQkgICB1MzIgZ3RfaWlyWzRdKQo+
ICtzdGF0aWMgdm9pZCBnZW44X2d0X2lycV9hY2soc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl
dl9wcml2LAo+ICsJCQkgICAgdTMyIG1hc3Rlcl9jdGwsIHUzMiBndF9paXJbNF0pCj4gIHsKPiAt
CWlycXJldHVybl90IHJldCA9IElSUV9OT05FOwo+IC0KPiAgCWlmIChtYXN0ZXJfY3RsICYgKEdF
TjhfR1RfUkNTX0lSUSB8IEdFTjhfR1RfQkNTX0lSUSkpIHsKPiAgCQlndF9paXJbMF0gPSBJOTE1
X1JFQURfRlcoR0VOOF9HVF9JSVIoMCkpOwo+IC0JCWlmIChndF9paXJbMF0pIHsKPiArCQlpZiAo
Z3RfaWlyWzBdKQo+ICAJCQlJOTE1X1dSSVRFX0ZXKEdFTjhfR1RfSUlSKDApLCBndF9paXJbMF0p
Owo+IC0JCQlyZXQgPSBJUlFfSEFORExFRDsKPiAtCQl9IGVsc2UKPiAtCQkJRFJNX0VSUk9SKCJU
aGUgbWFzdGVyIGNvbnRyb2wgaW50ZXJydXB0IGxpZWQgKEdUMCkhXG4iKTsKPiAgCX0KPiAgCj4g
IAlpZiAobWFzdGVyX2N0bCAmIChHRU44X0dUX1ZDUzFfSVJRIHwgR0VOOF9HVF9WQ1MyX0lSUSkp
IHsKPiAgCQlndF9paXJbMV0gPSBJOTE1X1JFQURfRlcoR0VOOF9HVF9JSVIoMSkpOwo+IC0JCWlm
IChndF9paXJbMV0pIHsKPiArCQlpZiAoZ3RfaWlyWzFdKQo+ICAJCQlJOTE1X1dSSVRFX0ZXKEdF
TjhfR1RfSUlSKDEpLCBndF9paXJbMV0pOwo+IC0JCQlyZXQgPSBJUlFfSEFORExFRDsKPiAtCQl9
IGVsc2UKPiAtCQkJRFJNX0VSUk9SKCJUaGUgbWFzdGVyIGNvbnRyb2wgaW50ZXJydXB0IGxpZWQg
KEdUMSkhXG4iKTsKPiAgCX0KPiAgCj4gIAlpZiAobWFzdGVyX2N0bCAmIEdFTjhfR1RfVkVDU19J
UlEpIHsKPiAgCQlndF9paXJbM10gPSBJOTE1X1JFQURfRlcoR0VOOF9HVF9JSVIoMykpOwo+IC0J
CWlmIChndF9paXJbM10pIHsKPiArCQlpZiAoZ3RfaWlyWzNdKQo+ICAJCQlJOTE1X1dSSVRFX0ZX
KEdFTjhfR1RfSUlSKDMpLCBndF9paXJbM10pOwo+IC0JCQlyZXQgPSBJUlFfSEFORExFRDsKPiAt
CQl9IGVsc2UKPiAtCQkJRFJNX0VSUk9SKCJUaGUgbWFzdGVyIGNvbnRyb2wgaW50ZXJydXB0IGxp
ZWQgKEdUMykhXG4iKTsKPiAgCX0KPiAgCj4gIAlpZiAobWFzdGVyX2N0bCAmIChHRU44X0dUX1BN
X0lSUSB8IEdFTjhfR1RfR1VDX0lSUSkpIHsKPiBAQCAtMTQ1MywxMiArMTQ0MSw4IEBAIHN0YXRp
YyBpcnFyZXR1cm5fdCBnZW44X2d0X2lycV9hY2soc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl
dl9wcml2LAo+ICAJCQlJOTE1X1dSSVRFX0ZXKEdFTjhfR1RfSUlSKDIpLAo+ICAJCQkJICAgICAg
Z3RfaWlyWzJdICYgKGRldl9wcml2LT5wbV9ycHNfZXZlbnRzIHwKPiAgCQkJCQkJICAgZGV2X3By
aXYtPnBtX2d1Y19ldmVudHMpKTsKPiAtCQkJcmV0ID0gSVJRX0hBTkRMRUQ7Cj4gLQkJfSBlbHNl
Cj4gLQkJCURSTV9FUlJPUigiVGhlIG1hc3RlciBjb250cm9sIGludGVycnVwdCBsaWVkIChQTSkh
XG4iKTsKPiArCQl9Cj4gIAl9Cj4gLQo+IC0JcmV0dXJuIHJldDsKPiAgfQo+ICAKPiAgc3RhdGlj
IHZvaWQgZ2VuOF9ndF9pcnFfaGFuZGxlcihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By
aXYsCj4gQEAgLTI2OTUsNyArMjY3OSw2IEBAIHN0YXRpYyBpcnFyZXR1cm5fdCBnZW44X2lycV9o
YW5kbGVyKGludCBpcnEsIHZvaWQgKmFyZykKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk
ZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPiAgCXUzMiBtYXN0ZXJfY3RsOwo+ICAJdTMyIGd0X2lp
cls0XSA9IHt9Owo+IC0JaXJxcmV0dXJuX3QgcmV0Owo+ICAKPiAgCWlmICghaW50ZWxfaXJxc19l
bmFibGVkKGRldl9wcml2KSkKPiAgCQlyZXR1cm4gSVJRX05PTkU7Cj4gQEAgLTI3MTEsMTYgKzI2
OTQsMTYgQEAgc3RhdGljIGlycXJldHVybl90IGdlbjhfaXJxX2hhbmRsZXIoaW50IGlycSwgdm9p
ZCAqYXJnKQo+ICAJZGlzYWJsZV9ycG1fd2FrZXJlZl9hc3NlcnRzKGRldl9wcml2KTsKPiAgCj4g
IAkvKiBGaW5kLCBjbGVhciwgdGhlbiBwcm9jZXNzIGVhY2ggc291cmNlIG9mIGludGVycnVwdCAq
Lwo+IC0JcmV0ID0gZ2VuOF9ndF9pcnFfYWNrKGRldl9wcml2LCBtYXN0ZXJfY3RsLCBndF9paXIp
Owo+ICsJZ2VuOF9ndF9pcnFfYWNrKGRldl9wcml2LCBtYXN0ZXJfY3RsLCBndF9paXIpOwo+ICAJ
Z2VuOF9ndF9pcnFfaGFuZGxlcihkZXZfcHJpdiwgZ3RfaWlyKTsKPiAtCXJldCB8PSBnZW44X2Rl
X2lycV9oYW5kbGVyKGRldl9wcml2LCBtYXN0ZXJfY3RsKTsKPiArCWdlbjhfZGVfaXJxX2hhbmRs
ZXIoZGV2X3ByaXYsIG1hc3Rlcl9jdGwpOwo+ICAKPiAgCUk5MTVfV1JJVEVfRlcoR0VOOF9NQVNU
RVJfSVJRLCBHRU44X01BU1RFUl9JUlFfQ09OVFJPTCk7Cj4gIAlQT1NUSU5HX1JFQURfRlcoR0VO
OF9NQVNURVJfSVJRKTsKPiAgCj4gIAllbmFibGVfcnBtX3dha2VyZWZfYXNzZXJ0cyhkZXZfcHJp
dik7Cj4gIAo+IC0JcmV0dXJuIHJldDsKPiArCXJldHVybiBJUlFfSEFORExFRDsKPiAgfQo+ICAK
PiAgc3RydWN0IHdlZGdlX21lIHsKPiAtLSAKPiAyLjE1LjEKCi0tIApWaWxsZSBTeXJqw6Rsw6QK
SW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo
dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=