From: sztsian@gmail.com
To: rostedt@goodmis.org
Cc: johannes.berg@intel.com, johannes@sipsolutions.net,
linux-kernel@vger.kernel.org, zsun@redhat.com, sztsian@gmail.com
Subject: [PATCH 1/2] trace-cmd: Fix the detection for swig
Date: Sun, 4 Feb 2018 11:20:13 +0800 [thread overview]
Message-ID: <20180204032014.6962-2-sztsian@gmail.com> (raw)
In-Reply-To: <20180204032014.6962-1-sztsian@gmail.com>
From: Zamir SUN <sztsian@gmail.com>
The current detection for swig will cause output to be
/usr/bin/swig
y
So this will never be equal to y. With this patch, the swig path is
removed from output, so the detection can work as expected.
Fixes 3bf187a43b7e6302592552ecbc294e5820249687
Signed-off-by: Zamir SUN (Red Hat) <sztsian@gmail.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index a5d2c38..7c0d1a6 100644
--- a/Makefile
+++ b/Makefile
@@ -105,7 +105,7 @@ PYTHON_GUI := ctracecmd.so ctracecmdgui.so
PYTHON_VERS ?= python
# Can build python?
-ifeq ($(shell sh -c "pkg-config --cflags $(PYTHON_VERS) > /dev/null 2>&1 && which swig && echo y"), y)
+ifeq ($(shell sh -c "pkg-config --cflags $(PYTHON_VERS) > /dev/null 2>&1 && which swig > /dev/null && echo y"), y)
PYTHON_PLUGINS := plugin_python.so
BUILD_PYTHON := $(PYTHON) $(PYTHON_PLUGINS)
PYTHON_SO_INSTALL := ctracecmd.install
--
2.14.3
next prev parent reply other threads:[~2018-02-04 3:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-04 3:20 [PATCH 0/2] trace-cmd: Improves python plugin support sztsian
2018-02-04 3:20 ` sztsian [this message]
2018-02-06 23:18 ` [PATCH 1/2] trace-cmd: Fix the detection for swig Steven Rostedt
2018-02-07 14:01 ` Zamir SUN
2018-02-07 14:40 ` Steven Rostedt
2018-02-07 15:09 ` Zamir SUN
2018-02-07 17:25 ` Vladislav Valtchev
2018-02-08 12:05 ` Zamir SUN
2018-02-08 14:04 ` Vladislav Valtchev
2018-02-04 3:20 ` [PATCH 2/2] trace-cmd: Change the way of getting python ldflags sztsian
2018-02-08 23:54 ` Steven Rostedt
2018-03-22 23:13 ` Steven Rostedt
2018-03-23 12:19 ` Zamir SUN
2018-02-06 12:31 ` [PATCH 0/2] trace-cmd: Improves python plugin support Zamir SUN
2018-02-06 14:14 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180204032014.6962-2-sztsian@gmail.com \
--to=sztsian@gmail.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=zsun@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.