From: Maxim Zhukov <mussitantesmortem@gmail.com>
To: marcel@holtmann.org
Cc: johan.hedberg@gmail.com, linux-bluetooth@vger.kernel.org,
linux-kernel@vger.kernel.org,
Maxim Zhukov <mussitantesmortem@gmail.com>
Subject: [PATCH 4/5] drivers: bluetooth: ath3k: Fix warning: quoted string split across lines
Date: Sun, 4 Feb 2018 23:59:33 +0300 [thread overview]
Message-ID: <20180204205934.12117-4-mussitantesmortem@gmail.com> (raw)
In-Reply-To: <20180204205934.12117-1-mussitantesmortem@gmail.com>
This patch avoided the warning:
WARNING: quoted string split across lines
#355: FILE: drivers/bluetooth/ath3k.c:355:
+ BT_ERR("Error in firmware loading err = %d,"
+ "len = %d, size = %d", err, len, size);
This patch fix this issue.
Signed-off-by: Maxim Zhukov <mussitantesmortem@gmail.com>
---
drivers/bluetooth/ath3k.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c
index 4df5b953a40d..8fe5ec4bb342 100644
--- a/drivers/bluetooth/ath3k.c
+++ b/drivers/bluetooth/ath3k.c
@@ -203,6 +203,12 @@ static const struct usb_device_id ath3k_blist_tbl[] = {
{ } /* Terminating entry */
};
+static inline void ath3k_log_failed_loading(int err, int len, int size)
+{
+ BT_ERR("Error in firmware loading err = %d, len = %d, size = %d",
+ err, len, size);
+}
+
#define USB_REQ_DFU_DNLOAD 1
#define BULK_SIZE 4096
#define FW_HDR_SIZE 20
@@ -251,8 +257,7 @@ static int ath3k_load_firmware(struct usb_device *udev,
&len, 3000);
if (err || (len != size)) {
- BT_ERR("Error in firmware loading err = %d,"
- "len = %d, size = %d", err, len, size);
+ ath3k_log_failed_loading(err, len, size);
goto error;
}
@@ -351,8 +356,7 @@ static int ath3k_load_fwfile(struct usb_device *udev,
err = usb_bulk_msg(udev, pipe, send_buf, size,
&len, 3000);
if (err || (len != size)) {
- BT_ERR("Error in firmware loading err = %d,"
- "len = %d, size = %d", err, len, size);
+ ath3k_log_failed_loading(err, len, size);
kfree(send_buf);
return err;
}
--
2.16.1
next prev parent reply other threads:[~2018-02-04 20:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-04 20:59 [PATCH 1/5] drivers: bluetooth: ath3k: replace hardcode numbers with define Maxim Zhukov
2018-02-04 20:59 ` [PATCH 2/5] drivers: bluetooth: ath3k: do not init variables Maxim Zhukov
2018-02-04 20:59 ` [PATCH 3/5] drivers: bluetooth: ath3k: remove blank line after if Maxim Zhukov
2018-02-04 20:59 ` Maxim Zhukov [this message]
2018-02-04 21:06 ` [PATCH 1/5] drivers: bluetooth: ath3k: replace hardcode numbers with define Maxim Zhukov
2018-02-04 21:06 ` [PATCH 2/5] drivers: bluetooth: ath3k: do not init variables Maxim Zhukov
2018-02-04 21:06 ` [PATCH 3/5] drivers: bluetooth: ath3k: remove blank line after if Maxim Zhukov
2018-02-04 21:06 ` [PATCH 4/5] drivers: bluetooth: ath3k: Fix warning: quoted string split across lines Maxim Zhukov
2018-02-04 21:06 ` [PATCH 5/5] drivers: bluetooth: ath3k: fix checkpatch warning Maxim Zhukov
2018-02-04 21:09 ` [PATCH v2 0/5] lite fixes for ath3k Maxim Zhukov
2018-02-04 21:09 ` [PATCH v2 1/5] drivers: bluetooth: ath3k: replace hardcode numbers with define Maxim Zhukov
2018-02-04 21:09 ` [PATCH v2 2/5] drivers: bluetooth: ath3k: do not init variables Maxim Zhukov
2018-02-04 21:09 ` [PATCH v2 3/5] drivers: bluetooth: ath3k: remove blank line after if Maxim Zhukov
2018-02-04 21:09 ` [PATCH v2 4/5] drivers: bluetooth: ath3k: Fix warning: quoted string split across lines Maxim Zhukov
2018-02-04 21:09 ` [PATCH v2 5/5] drivers: bluetooth: ath3k: fix checkpatch warning Maxim Zhukov
2018-02-07 8:55 ` [PATCH v2 0/5] lite fixes for ath3k Marcel Holtmann
2018-02-04 20:59 ` [PATCH 5/5] drivers: bluetooth: ath3k: fix Maxim Zhukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180204205934.12117-4-mussitantesmortem@gmail.com \
--to=mussitantesmortem@gmail.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.