All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Eric Blake" <eblake@redhat.com>,
	"Daniel P. Berrange" <berrange@redhat.com>
Subject: [Qemu-devel] [PATCH v4 1/9] char: don't silently skip tn3270 protocol init when TLS is enabled
Date: Mon,  5 Feb 2018 15:24:47 +0000	[thread overview]
Message-ID: <20180205152455.12088-2-berrange@redhat.com> (raw)
In-Reply-To: <20180205152455.12088-1-berrange@redhat.com>

From: "Daniel P. Berrange" <berrange@redhat.com>

Even if common tn3270 implementations do not support TLS, it is trivial to
have them proxied over a proxy like stunnel which adds TLS at the sockets
layer. We should thus not silently skip tn3270 protocol initialization
when TLS is enabled.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
 chardev/char-socket.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/chardev/char-socket.c b/chardev/char-socket.c
index 77cdf487eb..5c46a89200 100644
--- a/chardev/char-socket.c
+++ b/chardev/char-socket.c
@@ -634,8 +634,7 @@ static void tcp_chr_tls_handshake(QIOTask *task,
     if (qio_task_propagate_error(task, NULL)) {
         tcp_chr_disconnect(chr);
     } else {
-        /* tn3270 does not support TLS yet */
-        if (s->do_telnetopt && !s->is_tn3270) {
+        if (s->do_telnetopt) {
             tcp_chr_telnet_init(chr);
         } else {
             tcp_chr_connect(chr);
-- 
2.14.3

  reply	other threads:[~2018-02-05 15:25 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-05 15:24 [Qemu-devel] [PATCH v4 0/9] Enable passing pre-opened chardev socket FD Daniel P. Berrangé
2018-02-05 15:24 ` Daniel P. Berrangé [this message]
2018-02-05 16:10   ` [Qemu-devel] [PATCH v4 1/9] char: don't silently skip tn3270 protocol init when TLS is enabled Cornelia Huck
2018-02-05 15:24 ` [Qemu-devel] [PATCH v4 2/9] cutils: add qemu_strtoi & qemu_strtoui parsers for int/unsigned int types Daniel P. Berrangé
2018-02-05 19:37   ` Eric Blake
2018-02-07 16:29     ` Daniel P. Berrangé
2018-02-05 15:24 ` [Qemu-devel] [PATCH v4 3/9] sockets: pull code for testing IP availability out of specific test Daniel P. Berrangé
2018-02-05 15:24 ` [Qemu-devel] [PATCH v4 4/9] sockets: strengthen test suite IP protocol availability checks Daniel P. Berrangé
2018-02-05 15:24 ` [Qemu-devel] [PATCH v4 5/9] sockets: move fd_is_socket() into common sockets code Daniel P. Berrangé
2018-02-05 16:13   ` Marc-Andre Lureau
2018-02-05 15:24 ` [Qemu-devel] [PATCH v4 6/9] sockets: check that the named file descriptor is a socket Daniel P. Berrangé
2018-02-05 15:24 ` [Qemu-devel] [PATCH v4 7/9] sockets: allow SocketAddress 'fd' to reference numeric file descriptors Daniel P. Berrangé
2018-02-05 19:42   ` Eric Blake
2018-02-06  9:13     ` Daniel P. Berrangé
2018-02-06 14:48       ` Eric Blake
2018-03-12 12:44         ` Daniel P. Berrangé
2018-02-05 15:24 ` [Qemu-devel] [PATCH v4 8/9] char: refactor parsing of socket address information Daniel P. Berrangé
2018-02-05 15:24 ` [Qemu-devel] [PATCH v4 9/9] char: allow passing pre-opened socket file descriptor at startup Daniel P. Berrangé
2018-02-05 17:33 ` [Qemu-devel] [PATCH v4 0/9] Enable passing pre-opened chardev socket FD no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180205152455.12088-2-berrange@redhat.com \
    --to=berrange@redhat.com \
    --cc=armbru@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.