From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Mon, 5 Feb 2018 18:09:00 +0100 Subject: [U-Boot] [PATCH] usb: dwc2: make casts of ep->dma_buf consistent In-Reply-To: <1517842491-32421-1-git-send-email-trini@konsulko.com> References: <1517842491-32421-1-git-send-email-trini@konsulko.com> Message-ID: <20180205180900.7cf3cecc@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, 5 Feb 2018 09:54:51 -0500 Tom Rini wrote: > In most places in the code we cast this to an unsigned long, but in > one place we cast to an unsigned int. For consistency and to fix a > warning on 64bit targets, always cast this to unsigned long. For the > long term we should however change the declaration of dma_buf. > > Cc: Lukasz Majewski > Cc: Marek Vasut > Cc: Philipp Tomsich > Signed-off-by: Tom Rini > --- > drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c > b/drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c index > b6164afa9245..57dbbd5ebfa1 100644 --- > a/drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c +++ > b/drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c @@ -114,7 +114,7 @@ > static int setdma_rx(struct dwc2_ep *ep, struct dwc2_request *req) > (unsigned long) ep->dma_buf + ROUND(ep->len, > CONFIG_SYS_CACHELINE_SIZE)); > - writel((unsigned int) ep->dma_buf, > ®->out_endp[ep_num].doepdma); > + writel((unsigned long) ep->dma_buf, > ®->out_endp[ep_num].doepdma); writel(DOEPT_SIZ_PKT_CNT(pktcnt) | > DOEPT_SIZ_XFER_SIZE(length), ®->out_endp[ep_num].doeptsiz); > writel(DEPCTL_EPENA|DEPCTL_CNAK|ctrl, > ®->out_endp[ep_num].doepctl); Acked-by: Lukasz Majewski Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: