From: Chen Jingpiao <chenjingpiao@gmail.com>
To: Stefan Beller <sbeller@google.com>
Cc: git@vger.kernel.org
Subject: Re: [GSoC][PATCH] commit: add a commit.signOff config variable
Date: Tue, 6 Feb 2018 15:01:51 +0800 [thread overview]
Message-ID: <20180206070151.GA16810@ppiao> (raw)
In-Reply-To: <CAGZ79kZgqDp49McgtzWRbArsK6qVz1E9Syi5tJo73F-+T4UOiA@mail.gmail.com>
On 02/05 01:50, Stefan Beller wrote:
> On Sat, Feb 3, 2018 at 6:03 PM, Chen Jingpiao <chenjingpiao@gmail.com> wrote:
> > Add the commit.signOff configuration variable to use the -s or --signoff
> > option of git commit by default.
> >
> > Signed-off-by: Chen Jingpiao <chenjingpiao@gmail.com>
> > ---
>
> Welcome to the Git community!
>
> >
> > Though we can configure signoff using format.signOff variable. Someone like to
> > add Signed-off-by line by the committer.
>
> There is more discussion about this at
> https://public-inbox.org/git/1482946838-28779-1-git-send-email-ehabkost@redhat.com/
> specifically
> https://public-inbox.org/git/xmqqtw9m5s5m.fsf@gitster.mtv.corp.google.com/
>
> Not sure if there was any other reasons and discussions brought up
> since then, but that discussion seems to not favor patches that
> add .signoff options.
Thank you.
I agree with Johannes Schindelin once said "a signoff _has_ to be a conscious
act, or else it will lose its meaning."
I think I shouldn't add this configuration variable.
When add configuration variable for sign-off to format-patch have some discussion:
https://public-inbox.org/git/20090331204338.GA88381@macbook.lan/
https://public-inbox.org/git/20090401102610.GC26181@coredump.intra.peff.net/
https://public-inbox.org/git/7veiw69p26.fsf@gitster.siamese.dyndns.org/
--
Chen Jingpiao
prev parent reply other threads:[~2018-02-06 7:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-04 2:03 [GSoC][PATCH] commit: add a commit.signOff config variable Chen Jingpiao
2018-02-04 11:31 ` Eric Sunshine
2018-02-04 18:59 ` Ævar Arnfjörð Bjarmason
2018-02-05 21:50 ` Stefan Beller
2018-02-06 7:01 ` Chen Jingpiao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180206070151.GA16810@ppiao \
--to=chenjingpiao@gmail.com \
--cc=git@vger.kernel.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.