From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rahul Lakkireddy Subject: Re: [PATCH 3/7] cxgbe: add support to update RSS hash configuration and key Date: Tue, 6 Feb 2018 14:52:35 +0530 Message-ID: <20180206092234.GB19019@chelsio.com> References: <713e92d0143827f8af409763815cde15b9d40305.1517685185.git.rahul.lakkireddy@chelsio.com> <4e2eda5f-4697-906e-0596-84502add0af6@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "dev@dpdk.org" , Kumar A S , Surendra Mobiya , Nirranjan Kirubaharan , Indranil Choudhury To: Ferruh Yigit Return-path: Received: from stargate.chelsio.com (stargate.chelsio.com [12.32.117.8]) by dpdk.org (Postfix) with ESMTP id 865B81B697 for ; Tue, 6 Feb 2018 10:22:52 +0100 (CET) Content-Disposition: inline In-Reply-To: <4e2eda5f-4697-906e-0596-84502add0af6@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Monday, February 02/05/18, 2018 at 22:39:55 +0530, Ferruh Yigit wrote: > On 2/4/2018 6:06 AM, Rahul Lakkireddy wrote: > > From: Kumar Sanghvi > > > > Add firmware API for updating RSS hash configuration and key. Move > > RSS hash configuration from cxgb4_write_rss() to a separate function > > cxgbe_write_rss_conf(). > > > > Also, rename cxgb4_write_rss() to cxgbe_write_rss() for consistency. > > > > Original work by Surendra Mobiya > > > > Signed-off-by: Kumar Sanghvi > > Signed-off-by: Rahul Lakkireddy > > --- > > doc/guides/nics/cxgbe.rst | 2 + > > doc/guides/nics/features/cxgbe.ini | 1 + > > doc/guides/rel_notes/release_18_02.rst | 3 ++ > > drivers/net/cxgbe/base/adapter.h | 4 +- > > drivers/net/cxgbe/base/common.h | 3 ++ > > drivers/net/cxgbe/base/t4_hw.c | 73 +++++++++++++++++++++++++++ > > drivers/net/cxgbe/base/t4_regs.h | 25 +++++++++ > > drivers/net/cxgbe/base/t4fw_interface.h | 89 +++++++++++++++++++++++++++++++++ > > drivers/net/cxgbe/cxgbe.h | 2 + > > drivers/net/cxgbe/cxgbe_ethdev.c | 32 ++++++++++++ > > drivers/net/cxgbe/cxgbe_main.c | 79 ++++++++++++++++++++++------- > > 11 files changed, 295 insertions(+), 18 deletions(-) > > I tend to get driver patches even after integration deadline, mainly because of > their limited scope. > But since these are new features, submitted just before rc3, adding with > questions in first patch, I am for postponing this patchset to next release and > do more review, what do you think? Does dpdk-next-net tree work similar to linux "next" trees? I mean does it represent the next release (DPDK 18.05-rc1) merge window? Can we explicitly mention in Patch title which tree it is targeted for viz. dpdk or dpdk-next-net? Thanks, Rahul