From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suresh Reddy Subject: [PATCH net 1/2] be2net: Fix HW stall issue in Lancer Date: Tue, 6 Feb 2018 08:52:41 -0500 Message-ID: <20180206135242.22469-2-suresh.reddy@broadcom.com> References: <20180206135242.22469-1-suresh.reddy@broadcom.com> To: netdev@vger.kernel.org Return-path: Received: from relay.smtp.broadcom.com ([192.19.232.149]:38556 "EHLO relay.smtp.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751738AbeBFOAd (ORCPT ); Tue, 6 Feb 2018 09:00:33 -0500 Received: from Sathya-S84.localdomain (unknown [10.192.238.84]) by relay.smtp.broadcom.com (Postfix) with ESMTP id DC2701A1B91 for ; Tue, 6 Feb 2018 05:52:45 -0800 (PST) In-Reply-To: <20180206135242.22469-1-suresh.reddy@broadcom.com> Sender: netdev-owner@vger.kernel.org List-ID: Lancer HW cannot handle a TSO packet with a single segment. Disable TSO/GSO for such packets. Signed-off-by: Suresh Reddy --- drivers/net/ethernet/emulex/benet/be_main.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index c6e859a..130fa82 100644 --- a/drivers/net/ethernet/emulex/benet/be_main.c +++ b/drivers/net/ethernet/emulex/benet/be_main.c @@ -5097,9 +5097,12 @@ static netdev_features_t be_features_check(struct sk_buff *skb, features &= ~NETIF_F_TSO6; /* Lancer cannot handle the packet with MSS less than 256. + * Also it can't handle a TSO packet with a single segment * Disable the GSO support in such cases */ - if (lancer_chip(adapter) && skb_shinfo(skb)->gso_size < 256) + if (lancer_chip(adapter) && + (skb_shinfo(skb)->gso_size < 256 || + skb_shinfo(skb)->gso_segs == 1)) features &= ~NETIF_F_GSO_MASK; } -- 1.8.3.1