From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukas Wunner Subject: Re: [PATCH 3/3][RFC/RFT] PM / sleep: Do not delay the synchronization of MTRR during resume Date: Tue, 6 Feb 2018 15:04:17 +0100 Message-ID: <20180206140417.GA14526@wunner.de> References: <1613777.Al2QaFApID@aspire.rjw.lan> <20171213160242.GB29572@yu-chen.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20171213160242.GB29572@yu-chen.sh.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Yu Chen Cc: x86@kernel.org, Thomas Gleixner , Ingo Molnar , "Rafael J . Wysocki" , Len Brown , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Rui Zhang List-Id: linux-pm@vger.kernel.org On Thu, Dec 14, 2017 at 12:02:42AM +0800, Yu Chen wrote: > On Wed, Dec 13, 2017 at 01:31:50AM +0100, Rafael J. Wysocki wrote: > > On Tuesday, October 31, 2017 10:58:50 AM CET Yu Chen wrote: [snip] > > > In one word, with the patch applied, the cpu online time during resume > > > has decreased by about 6 seconds on a bogus MTRR platform, and decreased > > > by about 600ms on a 88 cpus Xeon platform after resumed. > > > > > > Cc: Len Brown > > > Cc: Rafael J. Wysocki > > > Cc: Rui Zhang > > > Signed-off-by: Chen Yu > > > > It will be better to combine this with patch [2/3] IMO, because that makes > > it clear why the changes in that patch are needed. > > > > Also you can define the new flag in mtrr/main.c, set it in > > arch_enable_nonboot_cpus_begin() and clear it in > > arch_enable_nonboot_cpus_end(). It is better to put it into the > > arch-specific code as the flag itself is arch-specific. > > > > Then, of course, you don't need patch [1/3] and all can be done in one > > patch. > > Ok, will rewrite the patch, thanks! Just for the record, this series cuts down resume time from system sleep by 4-5 seconds on my MacBookPro9,1. Great work, looking forward to this being respun and merged. Tested-by: Lukas Wunner Thanks, Lukas