From: "ira.weiny" <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH infiniband-diags 2/2] smpdump.c: Print number of bytes returned by umad_recv
Date: Wed, 7 Feb 2018 00:35:16 -0500 [thread overview]
Message-ID: <20180207053515.GC25132@phlsvsds.ph.intel.com> (raw)
In-Reply-To: <499f1d77-7da6-2c00-e826-bf4d0809f48a-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
On Mon, Dec 11, 2017 at 09:57:23AM -0500, Hal Rosenstock wrote:
>
> Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
> src/smpdump.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/smpdump.c b/src/smpdump.c
> index bc8559a..bb304d4 100644
> --- a/src/smpdump.c
> +++ b/src/smpdump.c
> @@ -281,6 +281,8 @@ int main(int argc, char *argv[])
> if (umad_recv(portid, umad, &length, -1) != mad_agent)
> IBPANIC("recv error: %s", strerror(errno));
>
> + printf("%d bytes received\n", length);
This seems like it is more for debugging.
How will this affect any scripts which include this command? Should we make
this debug output?
Ira
> +
> if (!dump_char) {
> xdump(stdout, 0, smp->data, 64);
> if (smp->status)
> --
> 2.8.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-02-07 5:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 14:57 [PATCH infiniband-diags 2/2] smpdump.c: Print number of bytes returned by umad_recv Hal Rosenstock
[not found] ` <499f1d77-7da6-2c00-e826-bf4d0809f48a-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2018-02-07 5:35 ` ira.weiny [this message]
[not found] ` <20180207053515.GC25132-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2018-02-07 11:46 ` Hal Rosenstock
[not found] ` <1e5e2f67-1492-cf1d-b9e7-1867b142c4ed-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2018-02-07 16:12 ` Weiny, Ira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180207053515.GC25132@phlsvsds.ph.intel.com \
--to=ira.weiny-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.