All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: "Vuille, Martin (Martin)" <vmartin@avaya.com>
Cc: "linux-perf-users@vger.kernel.org" <linux-perf-users@vger.kernel.org>
Subject: Re: Annotate is broken with --symfs option
Date: Wed, 7 Feb 2018 09:43:57 -0300	[thread overview]
Message-ID: <20180207124357.GK3451@kernel.org> (raw)
In-Reply-To: <30C2D590D16A5C46ADFE6521910377989261C1F5@AZ-US1EXMB02.global.avaya.com>

Em Tue, Feb 06, 2018 at 06:17:43PM +0000, Vuille, Martin (Martin) escreveu:
> Since commit a706670900073d236938d539d1109338d64b47bb, when using
> "perf annotate --symfs SYMFS_PATH" or "perf report --symfs SYMFS_PATH",
> annotate no longer produces any output.
> 
> Cause is an unnecessary call to __symbol__join_symfs in dso__disassemble_filename,
> which results in looking for the .build-id directory under SYMFS_PATH/SYMFS_PATH/.debug
> instead of under SYMFS_PATH/.debug.
> 
> May be able to submit a patch, not sure where to send it.

You can send it to me, I maintain the userland bits, please CC
linux-kernel@vger.kernel.org and this list, so that others can look and
help me in reviewing it.

Thanks for working on it!

- Arnaldo

      reply	other threads:[~2018-02-07 12:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-06 18:17 Annotate is broken with --symfs option Vuille, Martin (Martin)
2018-02-07 12:43 ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180207124357.GK3451@kernel.org \
    --to=acme@kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=vmartin@avaya.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.