From: Lina Iyer <ilina@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
rnayak@codeaurora.org, asathyak@codeaurora.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 2/2] dt-bindings/interrupt-controller: pdc: descibe PDC device binding
Date: Wed, 7 Feb 2018 16:50:05 +0000 [thread overview]
Message-ID: <20180207165005.GB16153@codeaurora.org> (raw)
In-Reply-To: <20180207164324.GP9465@builder>
On Wed, Feb 07 2018 at 16:43 +0000, Bjorn Andersson wrote:
>On Wed 07 Feb 07:49 PST 2018, Lina Iyer wrote:
>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
>[..]
>> +Example:
>[..]
>> + wake-device {
>> + [...]
>> + interrupt-controller = <&pdc>;
>
>Sorry for not seeing this earlier, but this should be:
>
> interrupt-parent = <&pdc>;
>
Thats right. Thanks for pointing out.
>Or as it's not unlikely that clients might use a mix of pdc and non-pdc
>interrupts the example could use the form:
>
> interrupts-extended = <&pdc 2 IRQ_TYPE_LEVEL_HIGH>;
>
OK. Will add it as another example.
>> + interrupt = <2 IRQ_TYPE_LEVEL_HIGH>;
>> + };
>
Thanks,
Lina
prev parent reply other threads:[~2018-02-07 16:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 15:49 [PATCH v4 0/2] irqchip: qcom: add support for PDC interrupt controller Lina Iyer
2018-02-07 15:49 ` [PATCH v4 1/2] drivers: irqchip: pdc: Add PDC interrupt controller for QCOM SoCs Lina Iyer
2018-02-07 16:43 ` Marc Zyngier
2018-02-07 16:52 ` Lina Iyer
2018-02-07 15:49 ` [PATCH v4 2/2] dt-bindings/interrupt-controller: pdc: descibe PDC device binding Lina Iyer
2018-02-07 16:43 ` Bjorn Andersson
2018-02-07 16:50 ` Lina Iyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180207165005.GB16153@codeaurora.org \
--to=ilina@codeaurora.org \
--cc=asathyak@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=rnayak@codeaurora.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.