From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/fb-helper: Redo fb format<->fb_bitfield mapping Date: Wed, 7 Feb 2018 19:19:53 +0200 Message-ID: <20180207171953.GA5453@intel.com> References: <20180207152445.25563-1-ville.syrjala@linux.intel.com> <20180207170830.a25suzue6jdk34ps@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9853489565 for ; Wed, 7 Feb 2018 17:19:56 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180207170830.a25suzue6jdk34ps@imgtec.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Engestrom Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBGZWIgMDcsIDIwMTggYXQgMDU6MDg6MzBQTSArMDAwMCwgRXJpYyBFbmdlc3Ryb20g d3JvdGU6Cj4gT24gV2VkbmVzZGF5LCAyMDE4LTAyLTA3IDE3OjI0OjQ1ICswMjAwLCBWaWxsZSBT eXJqYWxhIHdyb3RlOgo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbT4KPiA+IAo+ID4gUmVwbGFjZSB0aGUgc3dpdGNoIHN0YXRlbWVudHMgdGhh dCB0cnkgdG8gbWFwIGJldHdlZW4gdGhlIGZiIGZvcm1hdCBhbmQKPiA+IHRoZSBmYl9iaXRmaWVs ZCBpbmZyb21hdGlvbiB3aXRoIGEgc2luZ2xlIHRhYmxlLgo+ID4gCj4gPiBOb3RlIHRoYXQgdGhp cyBjaGFuZ2VzIHRoZSBiZWhhdmlvdXIgb2YgZHJtX2ZiX2hlbHBlcl9jaGVja192YXIoKSB0bwo+ ID4gcmV0dXJuIGFuIGVycm9yIG9mIHRoZSByZXF1ZXN0ZWQgZmJfYml0ZmllbGRzIGRvbid0IG1h dGNoIHRoZSBhY3R1YWwKPiA+IHBpeGVsIGZvcm1hdC4gUHJldmlvdXNseSB3ZSBqdXN0IHNvcnQg b2Ygc2VtaS10cnVzdGVkIHNvbWUgb2YgdGhlCj4gPiBicHAvZGVwdGggaW5mb3JtYXRpb24gdGhl IHVzZXIgd2FzIGFza2luZyBmb3IsIGFuZCBuZXZlciBhY3R1YWxseQo+ID4gY2hlY2tlZCBpZiB0 aGF0IG1hdGNoZXMgdGhlIGZiIHBpeGVsIGZvcm1hdC4KPiA+IAo+ID4gVGhpcyBwcmVwYXJlcyB1 cyB0byB1c2UgYWxsIGRpZmZlcmVudCByZ2IgZm9ybWF0IGNoYW5uZWwgbGF5b3V0cy4KPiA+IEJh c2ljYWxseSB3b3VsZCBqdXN0IG5lZWQgc29tZSBkZWNlbnQgd2F5IGZvciB0aGUgZHJpdmVyL2Nt ZGxpbmUKPiA+IHRvIHNlbGVjdCB0aGUgb25lIHlvdSB3YW50Lgo+ID4gCj4gPiBJIGRpZG4ndCB0 aGluayBhYm91dCBlbmRpYW5uZXNzIGhlcmUgYXQgYWxsLiBOb3Qgc3VyZSBob3cgZmJkZXYgaXMK PiA+IHN1cHBvc2VkIHRvIGRlYWwgd2l0aCB0aGF0IHN0dWZmIGFueXdheSwgYW5kIEkgZG9uJ3Qg dGhpbmsgd2UgZXZlcgo+ID4gcmVhY2hlZCBhIHJlYWwgY29uY2Vuc3VzIG9uIHRoZSBkcm0gZm91 cmNjIGVuZGlhbm5lc3MgZWl0aGVyLiBTbwo+ID4gSSdsbCBqdXN0IHByZXRlbmQgZXZlcnl0aGlu ZyBpcyBsaXR0bGUgZW5kaWFuIGFuZCBpZ25vcmUgZXZlcnl0aGluZwo+ID4gZWxzZS4KPiA+IAo+ ID4gQ2M6IExpbnVzIFdhbGxlaWogPGxpbnVzLndhbGxlaWpAbGluYXJvLm9yZz4KPiA+IENjOiBO b3JhbGYgVHLDuG5uZXMgPG5vcmFsZkB0cm9ubmVzLm9yZz4KPiA+IENjOiBJbGlhIE1pcmtpbiA8 aW1pcmtpbkBhbHVtLm1pdC5lZHU+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6Qg PHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUv ZHJtL2RybV9mYl9oZWxwZXIuYyB8IDI4MCArKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0t LS0tLS0tLS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDE2MyBpbnNlcnRpb25zKCspLCAxMTcgZGVs ZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hl bHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYwo+ID4gaW5kZXggMDM1Nzg0 ZGRkMTMzLi4wYzkwNmUzYTViYjEgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJt X2ZiX2hlbHBlci5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jCj4g PiBAQCAtNDAsNiArNDAsNyBAQAo+ID4gICNpbmNsdWRlIDxkcm0vZHJtX2NydGNfaGVscGVyLmg+ Cj4gPiAgI2luY2x1ZGUgPGRybS9kcm1fYXRvbWljLmg+Cj4gPiAgI2luY2x1ZGUgPGRybS9kcm1f YXRvbWljX2hlbHBlci5oPgo+ID4gKyNpbmNsdWRlIDxkcm0vZHJtX2ZvdXJjYy5oPgo+ID4gIAo+ ID4gICNpbmNsdWRlICJkcm1fY3J0Y19pbnRlcm5hbC5oIgo+ID4gICNpbmNsdWRlICJkcm1fY3J0 Y19oZWxwZXJfaW50ZXJuYWwuaCIKPiA+IEBAIC0xNTYxLDYgKzE1NjIsMTQ3IEBAIGludCBkcm1f ZmJfaGVscGVyX2lvY3RsKHN0cnVjdCBmYl9pbmZvICppbmZvLCB1bnNpZ25lZCBpbnQgY21kLAo+ ID4gIH0KPiA+ICBFWFBPUlRfU1lNQk9MKGRybV9mYl9oZWxwZXJfaW9jdGwpOwo+ID4gIAo+ID4g KyNkZWZpbmUgRkJfRk9STUFUX0MoYykgeyBcCj4gPiArCS5mb3JtYXQgPSBEUk1fRk9STUFUX0Mj I2MsICAgIFwKPiA+ICsJLmJsdWUgICA9IHsgLmxlbmd0aCA9IChjKSwgfSwgXAo+ID4gKwkuZ3Jl ZW4gID0geyAubGVuZ3RoID0gKGMpLCB9LCBcCj4gPiArCS5yZWQgICAgPSB7IC5sZW5ndGggPSAo YyksIH0sIFwKPiA+ICt9Cj4gPiArI2RlZmluZSBGQl9GT1JNQVRfUkdCKHIsIGcsIGIpIHsgXAo+ ID4gKwkuZm9ybWF0ID0gRFJNX0ZPUk1BVF9SR0IjI3IjI2cjI2IsIFwKPiA+ICsJLmJsdWUgICA9 IHsgLmxlbmd0aCA9IChiKSwgLm9mZnNldCA9IDAsIH0sIFwKPiA+ICsJLmdyZWVuICA9IHsgLmxl bmd0aCA9IChnKSwgLm9mZnNldCA9IChiKSwgfSwgXAo+ID4gKwkucmVkICAgID0geyAubGVuZ3Ro ID0gKHIpLCAub2Zmc2V0ID0gKGIpKyhnKSwgfSwgXAo+ID4gK30KPiA+ICsjZGVmaW5lIEZCX0ZP Uk1BVF9CR1IoYiwgZywgcikgeyBcCj4gPiArCS5mb3JtYXQgPSBEUk1fRk9STUFUX0JHUiMjYiMj ZyMjciwgXAo+ID4gKwkucmVkICAgID0geyAubGVuZ3RoID0gKHIpLCAub2Zmc2V0ID0gMCwgfSwg XAo+ID4gKwkuZ3JlZW4gID0geyAubGVuZ3RoID0gKGcpLCAub2Zmc2V0ID0gKHIpLCB9LCBcCj4g PiArCS5ibHVlICAgPSB7IC5sZW5ndGggPSAoYiksIC5vZmZzZXQgPSAocikrKGcpLCB9LCBcCj4g PiArfQo+ID4gKyNkZWZpbmUgRkJfRk9STUFUX1hSR0IoeCwgciwgZywgYikgeyBcCj4gPiArCS5m b3JtYXQgPSBEUk1fRk9STUFUX1hSR0IjI3gjI3IjI2cjI2IsIFwKPiA+ICsJLmJsdWUgICA9IHsg Lmxlbmd0aCA9IChiKSwgLm9mZnNldCA9IDAsIH0sIFwKPiA+ICsJLmdyZWVuICA9IHsgLmxlbmd0 aCA9IChnKSwgLm9mZnNldCA9IChiKSwgfSwgXAo+ID4gKwkucmVkICAgID0geyAubGVuZ3RoID0g KHIpLCAub2Zmc2V0ID0gKGIpKyhnKSwgfSwgXAo+ID4gK30KPiA+ICsjZGVmaW5lIEZCX0ZPUk1B VF9YQkdSKHgsIGIsIGcsIHIpIHsgXAo+ID4gKwkuZm9ybWF0ID0gRFJNX0ZPUk1BVF9YQkdSIyN4 IyNiIyNnIyNyLCBcCj4gPiArCS5yZWQgICAgPSB7IC5sZW5ndGggPSAociksIC5vZmZzZXQgPSAw LCB9LCBcCj4gPiArCS5ncmVlbiAgPSB7IC5sZW5ndGggPSAoZyksIC5vZmZzZXQgPSAociksIH0s IFwKPiA+ICsJLmJsdWUgICA9IHsgLmxlbmd0aCA9IChiKSwgLm9mZnNldCA9IChyKSsoZyksIH0s IFwKPiA+ICt9Cj4gPiArI2RlZmluZSBGQl9GT1JNQVRfUkdCWChyLCBnLCBiLCB4KSB7IFwKPiA+ ICsJLmZvcm1hdCA9IERSTV9GT1JNQVRfUkdCWCMjciMjZyMjYiMjeCwgXAo+ID4gKwkuYmx1ZSAg ID0geyAubGVuZ3RoID0gKGIpLCAub2Zmc2V0ID0gKHgpLCB9LCBcCj4gPiArCS5ncmVlbiAgPSB7 IC5sZW5ndGggPSAoZyksIC5vZmZzZXQgPSAoeCkrKGIpLCB9LCBcCj4gPiArCS5yZWQgICAgPSB7 IC5sZW5ndGggPSAociksIC5vZmZzZXQgPSAoeCkrKGIpKyhnKSwgfSwgXAo+ID4gK30KPiA+ICsj ZGVmaW5lIEZCX0ZPUk1BVF9CR1JYKGIsIGcsIHIsIHgpIHsgXAo+ID4gKwkuZm9ybWF0ID0gRFJN X0ZPUk1BVF9CR1JYIyNiIyNnIyNyIyN4LCBcCj4gPiArCS5yZWQgICAgPSB7IC5sZW5ndGggPSAo ciksIC5vZmZzZXQgPSAoeCksIH0sIFwKPiA+ICsJLmdyZWVuICA9IHsgLmxlbmd0aCA9IChnKSwg Lm9mZnNldCA9ICh4KSsociksIH0sIFwKPiA+ICsJLmJsdWUgICA9IHsgLmxlbmd0aCA9IChiKSwg Lm9mZnNldCA9ICh4KSsocikrKGcpLCB9LCBcCj4gPiArfQo+ID4gKyNkZWZpbmUgRkJfRk9STUFU X0FSR0IoYSwgciwgZywgYikgeyBcCj4gPiArCS5mb3JtYXQgPSBEUk1fRk9STUFUX0FSR0IjI2Ej I3IjI2cjI2IsIFwKPiA+ICsJLmJsdWUgICA9IHsgLmxlbmd0aCA9IChiKSwgLm9mZnNldCA9IDAs IH0sIFwKPiA+ICsJLmdyZWVuICA9IHsgLmxlbmd0aCA9IChnKSwgLm9mZnNldCA9IChiKSwgfSwg XAo+ID4gKwkucmVkICAgID0geyAubGVuZ3RoID0gKHIpLCAub2Zmc2V0ID0gKGIpKyhnKSwgfSwg XAo+ID4gKwkudHJhbnNwID0geyAubGVuZ3RoID0gKGEpLCAub2Zmc2V0ID0gKGIpKyhnKSsociks IH0sIFwKPiA+ICt9Cj4gPiArI2RlZmluZSBGQl9GT1JNQVRfQUJHUihhLCBiLCBnLCByKSB7IFwK PiA+ICsJLmZvcm1hdCA9IERSTV9GT1JNQVRfQUJHUiMjYSMjYiMjZyMjciwgXAo+ID4gKwkucmVk ICAgID0geyAubGVuZ3RoID0gKHIpLCAub2Zmc2V0ID0gMCwgfSwgXAo+ID4gKwkuZ3JlZW4gID0g eyAubGVuZ3RoID0gKGcpLCAub2Zmc2V0ID0gKHIpLCB9LCBcCj4gPiArCS5ibHVlICAgPSB7IC5s ZW5ndGggPSAoYiksIC5vZmZzZXQgPSAocikrKGcpLCB9LFwKPiA+ICsJLnRyYW5zcCA9IHsgLmxl bmd0aCA9IChhKSwgLm9mZnNldCA9IChyKSsoZykrKGIpLCB9LCBcCj4gPiArfQo+ID4gKyNkZWZp bmUgRkJfRk9STUFUX1JHQkEociwgZywgYiwgYSkgeyBcCj4gPiArCS5mb3JtYXQgPSBEUk1fRk9S TUFUX1JHQkEjI3IjI2cjI2IjI2EsIFwKPiA+ICsJLnRyYW5zcCA9IHsgLmxlbmd0aCA9IChhKSwg Lm9mZnNldCA9IDAsIH0sIFwKPiA+ICsJLmJsdWUgICA9IHsgLmxlbmd0aCA9IChiKSwgLm9mZnNl dCA9IChhKSwgfSwgXAo+ID4gKwkuZ3JlZW4gID0geyAubGVuZ3RoID0gKGcpLCAub2Zmc2V0ID0g KGEpKyhiKSwgfSwgXAo+ID4gKwkucmVkICAgID0geyAubGVuZ3RoID0gKHIpLCAub2Zmc2V0ID0g KGEpKyhiKSsoZyksIH0sIFwKPiA+ICt9Cj4gPiArI2RlZmluZSBGQl9GT1JNQVRfQkdSQShiLCBn LCByLCBhKSB7IFwKPiA+ICsJLmZvcm1hdCA9IERSTV9GT1JNQVRfQkdSQSMjYiMjZyMjciMjYSwg XAo+ID4gKwkudHJhbnNwID0geyAubGVuZ3RoID0gKGEpLCAub2Zmc2V0ID0gMCwgfSwgXAo+ID4g KwkucmVkICAgID0geyAubGVuZ3RoID0gKHIpLCAub2Zmc2V0ID0gKGEpLCB9LCBcCj4gPiArCS5n cmVlbiAgPSB7IC5sZW5ndGggPSAoZyksIC5vZmZzZXQgPSAoYSkrKHIpLCB9LCBcCj4gPiArCS5i bHVlICAgPSB7IC5sZW5ndGggPSAoYiksIC5vZmZzZXQgPSAoYSkrKHIpKyhnKSwgfSwgXAo+ID4g K30KPiA+ICsKPiA+ICtzdHJ1Y3QgZHJtX2ZiX2hlbHBlcl9mb3JtYXQgewo+ID4gKwl1MzIgZm9y bWF0Owo+ID4gKwlzdHJ1Y3QgZmJfYml0ZmllbGQgcmVkLCBncmVlbiwgYmx1ZSwgdHJhbnNwOwo+ ID4gK307Cj4gPiArCj4gPiArc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fZmJfaGVscGVyX2Zvcm1h dCBmYl9mb3JtYXRzW10gPSB7Cj4gPiArCUZCX0ZPUk1BVF9DKDgpLAo+ID4gKwo+ID4gKwlGQl9G T1JNQVRfWFJHQigxLCA1LCA1LCA1KSwKPiA+ICsJRkJfRk9STUFUX1hCR1IoMSwgNSwgNSwgNSks Cj4gPiArCUZCX0ZPUk1BVF9SR0JYKDUsIDUsIDUsIDEpLAo+ID4gKwlGQl9GT1JNQVRfQkdSWCg1 LCA1LCA1LCAxKSwKPiA+ICsKPiA+ICsJRkJfRk9STUFUX0FSR0IoMSwgNSwgNSwgNSksCj4gPiAr CUZCX0ZPUk1BVF9BQkdSKDEsIDUsIDUsIDUpLAo+ID4gKwlGQl9GT1JNQVRfUkdCQSg1LCA1LCA1 LCAxKSwKPiA+ICsJRkJfRk9STUFUX0JHUkEoNSwgNSwgNSwgMSksCj4gPiArCj4gPiArCUZCX0ZP Uk1BVF9SR0IoNSwgNiwgNSksCj4gPiArCUZCX0ZPUk1BVF9CR1IoNSwgNiwgNSksCj4gPiArCj4g PiArCUZCX0ZPUk1BVF9SR0IoOCwgOCwgOCksCj4gPiArCUZCX0ZPUk1BVF9CR1IoOCwgOCwgOCks Cj4gPiArCj4gPiArCUZCX0ZPUk1BVF9YUkdCKDgsIDgsIDgsIDgpLAo+ID4gKwlGQl9GT1JNQVRf WEJHUig4LCA4LCA4LCA4KSwKPiA+ICsJRkJfRk9STUFUX1JHQlgoOCwgOCwgOCwgOCksCj4gPiAr CUZCX0ZPUk1BVF9CR1JYKDgsIDgsIDgsIDgpLAo+ID4gKwo+ID4gKwlGQl9GT1JNQVRfQVJHQig4 LCA4LCA4LCA4KSwKPiA+ICsJRkJfRk9STUFUX0FCR1IoOCwgOCwgOCwgOCksCj4gPiArCUZCX0ZP Uk1BVF9SR0JBKDgsIDgsIDgsIDgpLAo+ID4gKwlGQl9GT1JNQVRfQkdSQSg4LCA4LCA4LCA4KSwK PiA+ICsKPiA+ICsJRkJfRk9STUFUX1hSR0IoMiwgMTAsIDEwLCAxMCksCj4gPiArCUZCX0ZPUk1B VF9YQkdSKDIsIDEwLCAxMCwgMTApLAo+ID4gKwlGQl9GT1JNQVRfUkdCWCgxMCwgMTAsIDEwLCAy KSwKPiA+ICsJRkJfRk9STUFUX0JHUlgoMTAsIDEwLCAxMCwgMiksCj4gPiArCj4gPiArCUZCX0ZP Uk1BVF9BUkdCKDIsIDEwLCAxMCwgMTApLAo+ID4gKwlGQl9GT1JNQVRfQUJHUigyLCAxMCwgMTAs IDEwKSwKPiA+ICsJRkJfRk9STUFUX1JHQkEoMTAsIDEwLCAxMCwgMiksCj4gPiArCUZCX0ZPUk1B VF9CR1JBKDEwLCAxMCwgMTAsIDIpLAo+ID4gK307Cj4gPiArCj4gPiArc3RhdGljIGJvb2wgZmJf Zm9ybWF0X21hdGNoKGNvbnN0IHN0cnVjdCBmYl92YXJfc2NyZWVuaW5mbyAqdmFyLAo+ID4gKwkJ CSAgICBjb25zdCBzdHJ1Y3QgZHJtX2ZiX2hlbHBlcl9mb3JtYXQgKmZiX2Zvcm1hdCkKPiA+ICt7 Cj4gPiArCXJldHVybiAhbWVtY21wKCZ2YXItPnJlZCwgJmZiX2Zvcm1hdC0+cmVkLAo+ID4gKwkJ ICAgICAgIHNpemVvZih2YXItPnJlZCkpICYmCj4gPiArCQkhbWVtY21wKCZ2YXItPmdyZWVuLCAm ZmJfZm9ybWF0LT5ncmVlbiwKPiA+ICsJCQlzaXplb2YodmFyLT5ncmVlbikpICYmCj4gPiArCQkh bWVtY21wKCZ2YXItPmJsdWUsICZmYl9mb3JtYXQtPmJsdWUsCj4gPiArCQkJc2l6ZW9mKHZhci0+ Ymx1ZSkpICYmCj4gPiArCQkhbWVtY21wKCZ2YXItPnRyYW5zcCwgJmZiX2Zvcm1hdC0+dHJhbnNw LAo+ID4gKwkJCXNpemVvZih2YXItPnRyYW5zcCkpOwo+IAo+IFRoaXMgcmVsaWVzIG9uIHRoZSBw YWRkaW5nIGJlaW5nIGluaXRpYWxpc2VkIHRvIDAgZXZlcnl3aGVyZSwgd2hpY2ggSSdtCj4gbm90 IHN1cmUgaXMgdHJ1ZSBldmVuIHdpdGggdGhlIHN0YXRpYyBhcnJheSBoZXJlLCBidXQgZmVlbHMg cmF0aGVyCj4gZnJhZ2lsZSByZWdhcmRsZXNzLi4uCgpUaGVyZSBzaG91bGQgYmUgbm8gcGFkZGlu ZyBpbiB0aGVzZS4gVGhleSBhcmUgcGFydCBvZiB0aGUgaW9jdGwKc3RydWN0dXJlIHNvIGFueSBw YWRkaW5nIHdvdWxkIG1lYW4gdGhleSdyZSBwcmV0dHkgbXVjaCBicm9rZW4uCgotLSAKVmlsbGUg U3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWwK