From: Petr Vorel <petr.vorel@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] ltp-testsuite: Add upstream patch to fix build numa detection
Date: Wed, 7 Feb 2018 19:05:05 +0100 [thread overview]
Message-ID: <20180207180504.GA29417@x230> (raw)
In-Reply-To: <20180203192750.pywvlwt25wlhvb4u@tarshish>
Hi Baruch,
thanks for info!
> So the behaviour of ltp-testsuite changes when its configure script detects
> libnuma, right? We want this change to be consistent whenever numactl is
> enabled in buildroot, so that ltp-testsuite would always detect libnuma when
> it is available. We don't want to leave it up to the pseudo-random packages
> build order.
Understand. I'm sorry I didn't realize that numactl is not name of binary package,
but name of the whole library. I didn't know that upstream uses it as name of the whole
project.
> > > Currently when the numactl package is enabled, ltp-testsuite would
> > > detect libnuma only if numactl happens to build before ltp-testsuite. To make
> > > builds consistent we need to make sure that numactl always build before
> > > ltp-testsuite by adding it to _DEPENDENCIES. Here is how the hwloc package
> > > does that:
> > > ifeq ($(BR2_PACKAGE_NUMACTL),y)
> > > HWLOC_CONF_OPTS += --enable-libnuma
> > > HWLOC_DEPENDENCIES += numactl
> > > else
> > > HWLOC_CONF_OPTS += --disable-libnuma
> > > endif
> > So this is not needed.
> So this is needed to make the build consistent, IMO.
This makes sense. Would you please prepare patch?
Kind regards,
Petr
prev parent reply other threads:[~2018-02-07 18:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 20:23 [Buildroot] [PATCH 1/1] ltp-testsuite: Add upstream patch to fix build numa detection Petr Vorel
2018-01-29 22:16 ` Thomas Petazzoni
2018-01-30 5:15 ` Baruch Siach
2018-02-01 22:19 ` Petr Vorel
2018-02-02 5:23 ` Baruch Siach
2018-02-02 13:59 ` Petr Vorel
2018-02-03 19:27 ` Baruch Siach
2018-02-07 18:05 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180207180504.GA29417@x230 \
--to=petr.vorel@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.