From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Kaehlcke Subject: Re: [PATCH 2/2] amdgpu/dc/dml: Support clang option for stack alignment Date: Wed, 7 Feb 2018 17:37:30 -0800 Message-ID: <20180208013730.GC116483@google.com> References: <20180208012156.165934-1-mka@chromium.org> <20180208012156.165934-2-mka@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Guenter Roeck Cc: Craig Bergstrom , Justin TerAvest , David Airlie , Felix Kuehling , linux-kernel , amd-gfx list , Guenter Roeck , Dmytro Laktyushkin , Maling list - DRI developers , Alex Deucher , Christian =?utf-8?B?S8O2bmln?= List-Id: amd-gfx.lists.freedesktop.org RWwgV2VkLCBGZWIgMDcsIDIwMTggYXQgMDU6MzQ6NDRQTSAtMDgwMCBHdWVudGVyIFJvZWNrIGhh IGRpdDoKCj4gT24gV2VkLCBGZWIgNywgMjAxOCBhdCA1OjIxIFBNLCBNYXR0aGlhcyBLYWVobGNr ZSA8bWthQGNocm9taXVtLm9yZz4gd3JvdGU6Cj4gPiBETUwgdXNlcyB0aGUgY29tcGlsZXIgb3B0 aW9uIC1tcHJlZmVycmVkLXN0YWNrLWJvdW5kYXJ5PTQgdG8gY29uZmlndXJlCj4gPiBhIHN0YWNr IGFsaWdubWVudCBvZiAxNiBieXRlcy4gQ2xhbmcgdXNlcyB0aGUgb3B0aW9uIC1tc3RhY2stYWxp Z25tZW50Cj4gPiBpbnN0ZWFkLCB3aGljaCBleHBlY3RzIGFzIHBhcmFtZXRlciB0aGUgYWxpZ25t ZW50IGluIGJ5dGVzLCBhbmQgbm90IGEKPiA+IHBvd2VyIG9mIHR3byBsaWtlIC1tcHJlZmVycmVk LXN0YWNrLWJvdW5kYXJ5Lgo+ID4KPiA+IFByb2JlIGZvciBib3RoIGNvbXBpbGVyIG9wdGlvbnMg YW5kIHVzZSB0aGUgY29ycmVjdCBvbmUsIHNpbWlsYXIgdG8KPiA+IHdoYXQgaXMgZG9uZSBpbiBh cmNoL3g4Ni9NYWtlZmlsZS4KPiA+Cj4gPiBSZXBvcnRlZC1ieTogR3VlbnRlciBSb2VjayA8Z3Jv ZWNrQGNocm9taXVtLm9yZz4KPiA+IFNpZ25lZC1vZmYtYnk6IE1hdHRoaWFzIEthZWhsY2tlIDxt a2FAY2hyb21pdW0ub3JnPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5 L2RjL2RtbC9NYWtlZmlsZSB8IDggKysrKysrKy0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgNyBpbnNl cnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gPgo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9hbWQvZGlzcGxheS9kYy9kbWwvTWFrZWZpbGUgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rp c3BsYXkvZGMvZG1sL01ha2VmaWxlCj4gPiBpbmRleCBiOGNhZGY4MzNlNzEuLjc0MDk3NTkzMWQy MSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9kYy9kbWwvTWFr ZWZpbGUKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9kYy9kbWwvTWFrZWZp bGUKPiA+IEBAIC0yNCw3ICsyNCwxMyBAQAo+ID4gICMgSXQgcHJvdmlkZXMgdGhlIGdlbmVyYWwg YmFzaWMgc2VydmljZXMgcmVxdWlyZWQgYnkgb3RoZXIgREFMCj4gPiAgIyBzdWJjb21wb25lbnRz Lgo+ID4KPiA+IC1zdWJkaXItY2NmbGFncy15ICs9IC1taGFyZC1mbG9hdCAtbXNzZSAtbXByZWZl cnJlZC1zdGFjay1ib3VuZGFyeT00Cj4gPiAraWZuZXEgKCQoY2FsbCBjYy1vcHRpb24sIC1tcHJl ZmVycmVkLXN0YWNrLWJvdW5kYXJ5PTQpLCkKPiA+ICsgICAgICAgY2Nfc3RhY2tfYWxpZ249LW1w cmVmZXJyZWQtc3RhY2stYm91bmRhcnk9NAo+ID4gK2Vsc2UgaWZuZXEgKCQoY2FsbCBjYy1vcHRp b24sIC1tc3RhY2stYWxpZ25tZW50PTE2KSwpCj4gPiArICAgICAgIGNjX3N0YWNrX2FsaWduIDo9 IC1tc3RhY2stYWxpZ25tZW50PTE2Cj4gPiArZW5kaWYKPiA+ICsKPiBBbnkgcmVhc29uIGZvciB1 c2luZyBib3RoID0gYW5kIDo9ID8KCk5vdCByZWFsbHksIHdpbGwgZml4LgoKVGhhbmtzIQpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752086AbeBHBhd (ORCPT ); Wed, 7 Feb 2018 20:37:33 -0500 Received: from mail-pl0-f67.google.com ([209.85.160.67]:38280 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751574AbeBHBhc (ORCPT ); Wed, 7 Feb 2018 20:37:32 -0500 X-Google-Smtp-Source: AH8x225u9LdOVh/9koRAKdAuZccFIknWxLqDNCQUesDfMDzGn1p1UTz0og8E5JkMSIkVnJ0gV9s0yw== Date: Wed, 7 Feb 2018 17:37:30 -0800 From: Matthias Kaehlcke To: Guenter Roeck Cc: Alex Deucher , Christian =?utf-8?B?S8O2bmln?= , David Zhou , David Airlie , Harry Wentland , Felix Kuehling , Dmytro Laktyushkin , amd-gfx list , Maling list - DRI developers , linux-kernel , Guenter Roeck , Justin TerAvest , Craig Bergstrom Subject: Re: [PATCH 2/2] amdgpu/dc/dml: Support clang option for stack alignment Message-ID: <20180208013730.GC116483@google.com> References: <20180208012156.165934-1-mka@chromium.org> <20180208012156.165934-2-mka@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org El Wed, Feb 07, 2018 at 05:34:44PM -0800 Guenter Roeck ha dit: > On Wed, Feb 7, 2018 at 5:21 PM, Matthias Kaehlcke wrote: > > DML uses the compiler option -mpreferred-stack-boundary=4 to configure > > a stack alignment of 16 bytes. Clang uses the option -mstack-alignment > > instead, which expects as parameter the alignment in bytes, and not a > > power of two like -mpreferred-stack-boundary. > > > > Probe for both compiler options and use the correct one, similar to > > what is done in arch/x86/Makefile. > > > > Reported-by: Guenter Roeck > > Signed-off-by: Matthias Kaehlcke > > --- > > drivers/gpu/drm/amd/display/dc/dml/Makefile | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/amd/display/dc/dml/Makefile b/drivers/gpu/drm/amd/display/dc/dml/Makefile > > index b8cadf833e71..740975931d21 100644 > > --- a/drivers/gpu/drm/amd/display/dc/dml/Makefile > > +++ b/drivers/gpu/drm/amd/display/dc/dml/Makefile > > @@ -24,7 +24,13 @@ > > # It provides the general basic services required by other DAL > > # subcomponents. > > > > -subdir-ccflags-y += -mhard-float -msse -mpreferred-stack-boundary=4 > > +ifneq ($(call cc-option, -mpreferred-stack-boundary=4),) > > + cc_stack_align=-mpreferred-stack-boundary=4 > > +else ifneq ($(call cc-option, -mstack-alignment=16),) > > + cc_stack_align := -mstack-alignment=16 > > +endif > > + > Any reason for using both = and := ? Not really, will fix. Thanks!