From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute2 v1] ip netns: allow negative nsid Date: Thu, 8 Feb 2018 08:01:24 -0800 Message-ID: <20180208080124.796126b8@xeon-e3> References: <20180206183931.4893-1-christian.brauner@ubuntu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Christian Brauner Return-path: Received: from mail-pf0-f180.google.com ([209.85.192.180]:33333 "EHLO mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750961AbeBHQBa (ORCPT ); Thu, 8 Feb 2018 11:01:30 -0500 Received: by mail-pf0-f180.google.com with SMTP id u15so1888135pfa.0 for ; Thu, 08 Feb 2018 08:01:30 -0800 (PST) In-Reply-To: <20180206183931.4893-1-christian.brauner@ubuntu.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 6 Feb 2018 19:39:31 +0100 Christian Brauner wrote: > If the kernel receives a negative nsid it will automatically assign the > next available nsid. In this case alloc_netid() will set min and max to > 0 for ird_alloc(). And when max == 0 idr_alloc() will interpret this as > the maxium range, i.e. specific to nsids it will try to find an id in > the range [0,INT_MAX). This is intentionally supported in the kernel for > nsids. Commit acbe9118ce8086f765ffb0da15f80c7c01a8903a regressed ip > netns in that respect although previously the use-case was either > accidentally supported or opaquely supported such that it triggered the > original commit. From what I can gather it went as follows before: > atoi() was called with a string indicating a negative value which caused > it to return -1 which was passed to the kernel. Let's make it less > opaque by introducing the keyword "auto": > > ip netns set auto > > will cause nsid to be set to -1 and the kernel will select an available > nsid. > > Signed-off-by: Christian Brauner Applied thank you. I did have to fix spelling and format of commit reference in the commit description. If you run checkpatch on patches to iproute you would have caught that.