From: "Michael S. Tsirkin" <mst@redhat.com>
To: Marcel Apfelbaum <marcel@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Eduardo Habkost <ehabkost@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
yuval.shaia@oracle.com, dotanb@mellanox.com
Subject: Re: [Qemu-devel] [PULL 0/4] RDMA patches
Date: Thu, 8 Feb 2018 15:58:26 +0200 [thread overview]
Message-ID: <20180208155418-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <51f8addc-8c6c-4532-1a59-b4c0098f6c68@redhat.com>
On Thu, Feb 08, 2018 at 03:38:59PM +0200, Marcel Apfelbaum wrote:
> We do not "use" the __u32 types, we just copied a kernel file
> for structures used for communication between the guest driver
> and the QEMU code. We had a look on how it is done and
> we use the model that adds macros __u32 -> uint32_t,
> so the "__types" do not really create such problems.
I don't think this is done like this anywhere in code.
Please take a look at how it's done for e.g. input.h
I think that whenever a rule in HACKING, coding style,
etc is ignored it should be accompanied by motivation
in code comments, so this won't spread out any more.
--
MST
next prev parent reply other threads:[~2018-02-08 13:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 10:26 [Qemu-devel] [PULL 0/4] RDMA patches Marcel Apfelbaum
2018-02-05 10:26 ` [Qemu-devel] [PULL 1/4] mem: add share parameter to memory-backend-ram Marcel Apfelbaum
2018-02-05 10:26 ` [Qemu-devel] [PULL 2/4] docs: add pvrdma device documentation Marcel Apfelbaum
2018-02-05 10:26 ` [Qemu-devel] [PULL 3/4] pvrdma: initial implementation Marcel Apfelbaum
2018-02-05 10:26 ` [Qemu-devel] [PULL 4/4] MAINTAINERS: add entry for hw/rdma Marcel Apfelbaum
2018-02-07 17:19 ` [Qemu-devel] [PULL 0/4] RDMA patches Marcel Apfelbaum
2018-02-07 17:27 ` Peter Maydell
2018-02-08 12:59 ` Peter Maydell
2018-02-08 13:38 ` Marcel Apfelbaum
2018-02-08 13:54 ` Peter Maydell
2018-02-08 14:06 ` Marcel Apfelbaum
2018-02-08 13:58 ` Michael S. Tsirkin [this message]
2018-02-08 14:07 ` Marcel Apfelbaum
2018-02-08 14:01 ` Philippe Mathieu-Daudé
2018-02-08 14:12 ` Marcel Apfelbaum
2018-02-08 13:54 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180208155418-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=dotanb@mellanox.com \
--cc=ehabkost@redhat.com \
--cc=marcel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.