From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.28.71.27 with SMTP id u27csp2517683wma; Thu, 8 Feb 2018 12:34:28 -0800 (PST) X-Google-Smtp-Source: AH8x225+aDFUgC9CMtmjVKlqShuXx4W9zYVLKyJu+zG8AfCf7j2FES9iEROIPX4JgiN62famFSIY X-Received: by 10.37.135.78 with SMTP id e14mr256153ybn.38.1518122068645; Thu, 08 Feb 2018 12:34:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518122068; cv=none; d=google.com; s=arc-20160816; b=FJfjyORwtvdMBFXu0IqVv7qm8CZLjK7ru7Enr8YVzIgtGecP89d/6nJ+8RCGzPXlEx DbMk1Yj3UW7fiMhdDJ5s+/oiBShUQ1Egao71vhsCtjfJfsABDGN9a8oG4ZTFhOAHA9Ih W/gmKRHgzXIKGtBTasD5iqNXEtZ0lB7ykIhvurTkFqFL2R1I4okyxgZmIcate3pDD009 aT//hJ8C9mxUX5n25Zfyy+8Ma6auHiU4eebDOsYu2U6rL0wlj0drvP1zchviFACzqtDN 1+XgHFaMstV2O1nVAa4/WsZgsJ4jcD3M6cuhX6+owwhevlXk7YpIefykRnZ+TIal5X0y 388g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:in-reply-to :content-disposition:mime-version:references:message-id:to:from:date :arc-authentication-results; bh=a85/6L7zHu9Cs5Zxzj/tX8OzENYjPvgKqnAeu+cBHRw=; b=hOGAe2e+v0PwJTKn/tSuOYLL6L0O4ZAmiVXOXpAMCCeR0MWrDST4Rf1mYRRgsoA/dp D2UN4//3SEyYFr5IfIAzfn2KoA0RxaT7EMgz7lwzT4wpqatuA/FBLBC7Nd2mgD76vyAh iGhxLkGmD9XSakfM4YNs0r0tlIKVRLeI7T14dgtopUrM+zP1Lazq0kUJvrelQ+QHDPU7 Ndc8u9pTENrv5tm4pKRbqTgtouSMxl8rRp+fbVtwF7UzOASPAKWwKZymFOj1IUfzYMMB 2QQf+ompfh/1Dp61LSb1n0R8HOBNv7/x2OAeNOg49NnJSn/4a0x7z4ooxkHoNYA/Ilgs JhNQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id r191si135918ywh.199.2018.02.08.12.34.28 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 08 Feb 2018 12:34:28 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:46077 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ejstn-0007qO-T8 for alex.bennee@linaro.org; Thu, 08 Feb 2018 15:34:27 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52287) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ejstU-0007nW-O7 for qemu-arm@nongnu.org; Thu, 08 Feb 2018 15:34:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ejstP-00040d-So for qemu-arm@nongnu.org; Thu, 08 Feb 2018 15:34:07 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:55388 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ejstP-000402-NR; Thu, 08 Feb 2018 15:34:03 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4E9B117CEDB; Thu, 8 Feb 2018 20:34:00 +0000 (UTC) Received: from redhat.com (ovpn-120-144.rdu2.redhat.com [10.10.120.144]) by smtp.corp.redhat.com (Postfix) with SMTP id 3EBD3B07AF; Thu, 8 Feb 2018 20:33:57 +0000 (UTC) Date: Thu, 8 Feb 2018 22:33:57 +0200 From: "Michael S. Tsirkin" To: Andrey Smirnov Message-ID: <20180208223323-mutt-send-email-mst@kernel.org> References: <20180207042438.15422-1-andrew.smirnov@gmail.com> <20180207042438.15422-11-andrew.smirnov@gmail.com> <20180208194226-mutt-send-email-mst@kernel.org> <20180208221121-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Thu, 08 Feb 2018 20:34:00 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Thu, 08 Feb 2018 20:34:00 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'mst@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: Re: [Qemu-arm] [PATCH v5 10/14] pci: Add support for Designware IP block X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Jason Wang , Marcel Apfelbaum , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , QEMU Developers , "open list:ARM" , Andrey Yurovsky Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: FLib7ky9LBHP On Thu, Feb 08, 2018 at 12:22:53PM -0800, Andrey Smirnov wrote: > On Thu, Feb 8, 2018 at 12:11 PM, Michael S. Tsirkin wrote: > > On Thu, Feb 08, 2018 at 12:03:04PM -0800, Andrey Smirnov wrote: > >> >> +#define PCIE_PORT_LINK_CONTROL 0x710 > >> >> + > >> >> +#define PCIE_PHY_DEBUG_R1 0x72C > >> >> +#define PCIE_PHY_DEBUG_R1_XMLH_LINK_UP BIT(4) > >> >> + > >> >> +#define PCIE_LINK_WIDTH_SPEED_CONTROL 0x80C > >> >> +#define PORT_LOGIC_SPEED_CHANGE (0x1 << 17) > >> >> + > >> >> +#define PCIE_MSI_ADDR_LO 0x820 > >> >> +#define PCIE_MSI_ADDR_HI 0x824 > >> >> +#define PCIE_MSI_INTR0_ENABLE 0x828 > >> >> +#define PCIE_MSI_INTR0_MASK 0x82C > >> >> +#define PCIE_MSI_INTR0_STATUS 0x830 > >> >> + > >> >> +#define PCIE_ATU_VIEWPORT 0x900 > >> >> +#define PCIE_ATU_REGION_INBOUND (0x1 << 31) > >> >> +#define PCIE_ATU_REGION_OUTBOUND (0x0 << 31) > >> >> +#define PCIE_ATU_REGION_INDEX2 (0x2 << 0) > >> >> +#define PCIE_ATU_REGION_INDEX1 (0x1 << 0) > >> >> +#define PCIE_ATU_REGION_INDEX0 (0x0 << 0) > >> >> +#define PCIE_ATU_CR1 0x904 > >> >> +#define PCIE_ATU_TYPE_MEM (0x0 << 0) > >> >> +#define PCIE_ATU_TYPE_IO (0x2 << 0) > >> >> +#define PCIE_ATU_TYPE_CFG0 (0x4 << 0) > >> >> +#define PCIE_ATU_TYPE_CFG1 (0x5 << 0) > >> >> +#define PCIE_ATU_CR2 0x908 > >> >> +#define PCIE_ATU_ENABLE (0x1 << 31) > >> >> +#define PCIE_ATU_BAR_MODE_ENABLE (0x1 << 30) > >> >> +#define PCIE_ATU_LOWER_BASE 0x90C > >> >> +#define PCIE_ATU_UPPER_BASE 0x910 > >> >> +#define PCIE_ATU_LIMIT 0x914 > >> >> +#define PCIE_ATU_LOWER_TARGET 0x918 > >> >> +#define PCIE_ATU_BUS(x) (((x) >> 24) & 0xff) > >> >> +#define PCIE_ATU_DEVFN(x) (((x) >> 16) & 0xff) > >> >> +#define PCIE_ATU_UPPER_TARGET 0x91C > > > > Can you avoid a PCIE prefix for this btw? > > > > That's how those constants were named in Linux kernel, but yeah, I'll > add a prefix to them. > > Thanks, > Andrey Smirnov In that case you should not copy it into your file. Stuff from linux kernel should be imported into standard-headers. -- MST From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52328) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ejstW-0007p3-Ua for qemu-devel@nongnu.org; Thu, 08 Feb 2018 15:34:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ejstV-00043w-Vj for qemu-devel@nongnu.org; Thu, 08 Feb 2018 15:34:10 -0500 Date: Thu, 8 Feb 2018 22:33:57 +0200 From: "Michael S. Tsirkin" Message-ID: <20180208223323-mutt-send-email-mst@kernel.org> References: <20180207042438.15422-1-andrew.smirnov@gmail.com> <20180207042438.15422-11-andrew.smirnov@gmail.com> <20180208194226-mutt-send-email-mst@kernel.org> <20180208221121-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v5 10/14] pci: Add support for Designware IP block List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrey Smirnov Cc: "open list:ARM" , Peter Maydell , Jason Wang , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Marcel Apfelbaum , QEMU Developers , Andrey Yurovsky On Thu, Feb 08, 2018 at 12:22:53PM -0800, Andrey Smirnov wrote: > On Thu, Feb 8, 2018 at 12:11 PM, Michael S. Tsirkin wrote: > > On Thu, Feb 08, 2018 at 12:03:04PM -0800, Andrey Smirnov wrote: > >> >> +#define PCIE_PORT_LINK_CONTROL 0x710 > >> >> + > >> >> +#define PCIE_PHY_DEBUG_R1 0x72C > >> >> +#define PCIE_PHY_DEBUG_R1_XMLH_LINK_UP BIT(4) > >> >> + > >> >> +#define PCIE_LINK_WIDTH_SPEED_CONTROL 0x80C > >> >> +#define PORT_LOGIC_SPEED_CHANGE (0x1 << 17) > >> >> + > >> >> +#define PCIE_MSI_ADDR_LO 0x820 > >> >> +#define PCIE_MSI_ADDR_HI 0x824 > >> >> +#define PCIE_MSI_INTR0_ENABLE 0x828 > >> >> +#define PCIE_MSI_INTR0_MASK 0x82C > >> >> +#define PCIE_MSI_INTR0_STATUS 0x830 > >> >> + > >> >> +#define PCIE_ATU_VIEWPORT 0x900 > >> >> +#define PCIE_ATU_REGION_INBOUND (0x1 << 31) > >> >> +#define PCIE_ATU_REGION_OUTBOUND (0x0 << 31) > >> >> +#define PCIE_ATU_REGION_INDEX2 (0x2 << 0) > >> >> +#define PCIE_ATU_REGION_INDEX1 (0x1 << 0) > >> >> +#define PCIE_ATU_REGION_INDEX0 (0x0 << 0) > >> >> +#define PCIE_ATU_CR1 0x904 > >> >> +#define PCIE_ATU_TYPE_MEM (0x0 << 0) > >> >> +#define PCIE_ATU_TYPE_IO (0x2 << 0) > >> >> +#define PCIE_ATU_TYPE_CFG0 (0x4 << 0) > >> >> +#define PCIE_ATU_TYPE_CFG1 (0x5 << 0) > >> >> +#define PCIE_ATU_CR2 0x908 > >> >> +#define PCIE_ATU_ENABLE (0x1 << 31) > >> >> +#define PCIE_ATU_BAR_MODE_ENABLE (0x1 << 30) > >> >> +#define PCIE_ATU_LOWER_BASE 0x90C > >> >> +#define PCIE_ATU_UPPER_BASE 0x910 > >> >> +#define PCIE_ATU_LIMIT 0x914 > >> >> +#define PCIE_ATU_LOWER_TARGET 0x918 > >> >> +#define PCIE_ATU_BUS(x) (((x) >> 24) & 0xff) > >> >> +#define PCIE_ATU_DEVFN(x) (((x) >> 16) & 0xff) > >> >> +#define PCIE_ATU_UPPER_TARGET 0x91C > > > > Can you avoid a PCIE prefix for this btw? > > > > That's how those constants were named in Linux kernel, but yeah, I'll > add a prefix to them. > > Thanks, > Andrey Smirnov In that case you should not copy it into your file. Stuff from linux kernel should be imported into standard-headers. -- MST