From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:40334 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750830AbeBIHQI (ORCPT ); Fri, 9 Feb 2018 02:16:08 -0500 Date: Fri, 9 Feb 2018 08:16:05 +0100 From: Greg Kroah-Hartman To: Horia =?utf-8?Q?Geant=C4=83?= Cc: "stable@vger.kernel.org" , Herbert Xu Subject: Re: [PATCH 4.14.y] crypto: tcrypt - fix S/G table for test_aead_speed() Message-ID: <20180209071605.GA7767@kroah.com> References: <20180208072831.29827-1-horia.geanta@nxp.com> <20180208165618.GE11540@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: stable-owner@vger.kernel.org List-ID: On Fri, Feb 09, 2018 at 06:11:59AM +0000, Horia Geantă wrote: > On 2/8/2018 6:56 PM, Greg Kroah-Hartman wrote: > > On Thu, Feb 08, 2018 at 09:28:31AM +0200, Horia Geantă wrote: > >> From: Robert Baronescu > >> > >> commit 5c6ac1d4f8fbdbed65dbeb8cf149d736409d16a1 upstream. > >> > >> In case buffer length is a multiple of PAGE_SIZE, > >> the S/G table is incorrectly generated. > >> Fix this by handling buflen = k * PAGE_SIZE separately. > >> > >> Signed-off-by: Robert Baronescu > >> Signed-off-by: Herbert Xu > >> Signed-off-by: Horia Geantă > >> --- > >> crypto/tcrypt.c | 6 ++++-- > >> 1 file changed, 4 insertions(+), 2 deletions(-) > > > > Why just 4.14.y? I also queued this up for everything else (4.15.y, > > 4.9.y, and 4.4.y). > > > The issue is not observed unless upstream commit > 7aacbfcb331c ("crypto: tcrypt - fix buffer lengths in test_aead_speed()") > is also applied. Shouldn't that patch also be applied to all of the stable trees? thanks, greg k-h