From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Dave Young <dyoung@redhat.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Petr Mladek <pmladek@suse.com>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] printk: move dump stack related code to lib/dump_stack.c
Date: Fri, 9 Feb 2018 17:42:35 +0900 [thread overview]
Message-ID: <20180209084235.GF689@jagdpanzerIV> (raw)
In-Reply-To: <20180209082743.GA14845@dhcp-128-65.nay.redhat.com>
On (02/09/18 16:27), Dave Young wrote:
> > Seems that those functions are still defined in printk header.
> > Did you test !CONFIG_PRINTK build?
Apparently dump_stack(void) is also in printk.h
extern asmlinkage void dump_stack(void) __cold;
so it's "OK" to keep those functions in printk.h, I guess. I thought
that dump_stack() had its own header file...
> !CONFIG_PRINTK will use the dummy functions in printk.h, I did not test
> the build, doing it now to double confirm..
Not sure. Please test.
-ss
next prev parent reply other threads:[~2018-02-09 8:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 8:06 [PATCH] printk: move dump stack related code to lib/dump_stack.c Dave Young
2018-02-09 8:16 ` Sergey Senozhatsky
2018-02-09 8:27 ` Dave Young
2018-02-09 8:42 ` Sergey Senozhatsky [this message]
2018-02-09 8:51 ` Dave Young
2018-02-09 9:00 ` Dave Young
2018-02-09 9:15 ` Sergey Senozhatsky
2018-02-13 7:30 ` Dave Young
2018-02-09 8:35 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180209084235.GF689@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=dyoung@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.