From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v4,5/5] dmaengine: mediatek: fix zalloc-simple.cocci warnings From: Vinod Koul Message-Id: <20180209125817.GB3666@localhost> Date: Fri, 9 Feb 2018 18:28:18 +0530 To: sean.wang@mediatek.com Cc: dan.j.williams@intel.com, robh+dt@kernel.org, mark.rutland@arm.com, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Fengguang Wu , Julia Lawall List-ID: T24gRnJpLCBGZWIgMDksIDIwMTggYXQgMDE6NTg6NTFBTSArMDgwMCwgc2Vhbi53YW5nQG1lZGlh dGVrLmNvbSB3cm90ZToKPiBGcm9tOiBGZW5nZ3VhbmcgV3UgPGZlbmdndWFuZy53dUBpbnRlbC5j b20+Cj4gCj4gIFVzZSB6ZXJvaW5nIGFsbG9jYXRvciByYXRoZXIgdGhhbiBhbGxvY2F0b3IgZm9s bG93ZWQgYnkgbWVtc2V0IHdpdGggMAo+IAo+IEdlbmVyYXRlZCBieTogc2NyaXB0cy9jb2NjaW5l bGxlL2FwaS9hbGxvYy96YWxsb2Mtc2ltcGxlLmNvY2NpCj4gCj4gRml4ZXM6IGM4ZTRiMmU0Y2Ey MSAoImRtYWVuZ2luZTogbWVkaWF0ZWs6IEFkZCBNZWRpYVRlayBIaWdoLVNwZWVkIERNQSBjb250 cm9sbGVyIGZvciBNVDc2MjIgYW5kIE1UNzYyMyBTb0MiKQo+IENjOiBTZWFuIFdhbmcgPHNlYW4u d2FuZ0BtZWRpYXRlay5jb20+Cj4gU2lnbmVkLW9mZi1ieTogRmVuZ2d1YW5nIFd1IDxmZW5nZ3Vh bmcud3VAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEp1bGlhIExhd2FsbCA8anVsaWEubGF3 YWxsQGxpcDYuZnI+Cj4gU2lnbmVkLW9mZi1ieTogU2VhbiBXYW5nIDxzZWFuLndhbmdAbWVkaWF0 ZWsuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2RtYS9tZWRpYXRlay9tdGstaHNkbWEuYyB8IDYgKyst LS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4g Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZG1hL21lZGlhdGVrL210ay1oc2RtYS5jIGIvZHJpdmVy cy9kbWEvbWVkaWF0ZWsvbXRrLWhzZG1hLmMKPiBpbmRleCA0MmI1YjIzLi5kM2I5MGZlIDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZG1hL21lZGlhdGVrL210ay1oc2RtYS5jCj4gKysrIGIvZHJpdmVy cy9kbWEvbWVkaWF0ZWsvbXRrLWhzZG1hLmMKPiBAQCAtMzI1LDEzICszMjUsMTEgQEAgc3RhdGlj IGludCBtdGtfaHNkbWFfYWxsb2NfcGNoYW4oc3RydWN0IG10a19oc2RtYV9kZXZpY2UgKmhzZG1h LAo+ICAJICogYW5kIFtNVEtfRE1BX1NJWkUgLi4uIDIgKiBNVEtfRE1BX1NJWkUgLSAxXSBpcyBm b3IgUlggcmluZy4KPiAgCSAqLwo+ICAJcGMtPnN6X3JpbmcgPSAyICogTVRLX0RNQV9TSVpFICog c2l6ZW9mKCpyaW5nLT50eGQpOwo+IC0JcmluZy0+dHhkID0gZG1hX2FsbG9jX2NvaGVyZW50KGhz ZG1hMmRldihoc2RtYSksCj4gLQkJCQkgICAgICAgcGMtPnN6X3JpbmcsICZyaW5nLT50cGh5cywK PiAtCQkJCSAgICAgICBHRlBfQVRPTUlDIHwgX19HRlBfWkVSTyk7Cj4gKwlyaW5nLT50eGQgPSBk bWFfemFsbG9jX2NvaGVyZW50KGhzZG1hMmRldihoc2RtYSksIHBjLT5zel9yaW5nLAo+ICsJCQkJ CSZyaW5nLT50cGh5cywgR0ZQX0FUT01JQyk7Cj4gIAlpZiAoIXJpbmctPnR4ZCkKPiAgCQlyZXR1 cm4gLUVOT01FTTsKPiAgCj4gLQltZW1zZXQocmluZy0+dHhkLCAwLCBwYy0+c3pfcmluZyk7CgpU aGlzIHNob3VsZCBiZSBmb2xkZWQgYmFjay4uCgo+ICAJcmluZy0+cnhkID0gJnJpbmctPnR4ZFtN VEtfRE1BX1NJWkVdOwo+ICAJcmluZy0+cnBoeXMgPSByaW5nLT50cGh5cyArIE1US19ETUFfU0la RSAqIHNpemVvZigqcmluZy0+dHhkKTsKPiAgCXJpbmctPmN1cl90cHRyID0gMDsKPiAtLSAKPiAy LjcuNAo+Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH v4 5/5] dmaengine: mediatek: fix zalloc-simple.cocci warnings Date: Fri, 9 Feb 2018 18:28:18 +0530 Message-ID: <20180209125817.GB3666@localhost> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org Cc: dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Fengguang Wu , Julia Lawall List-Id: linux-mediatek@lists.infradead.org On Fri, Feb 09, 2018 at 01:58:51AM +0800, sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org wrote: > From: Fengguang Wu > > Use zeroing allocator rather than allocator followed by memset with 0 > > Generated by: scripts/coccinelle/api/alloc/zalloc-simple.cocci > > Fixes: c8e4b2e4ca21 ("dmaengine: mediatek: Add MediaTek High-Speed DMA controller for MT7622 and MT7623 SoC") > Cc: Sean Wang > Signed-off-by: Fengguang Wu > Signed-off-by: Julia Lawall > Signed-off-by: Sean Wang > --- > drivers/dma/mediatek/mtk-hsdma.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/dma/mediatek/mtk-hsdma.c b/drivers/dma/mediatek/mtk-hsdma.c > index 42b5b23..d3b90fe 100644 > --- a/drivers/dma/mediatek/mtk-hsdma.c > +++ b/drivers/dma/mediatek/mtk-hsdma.c > @@ -325,13 +325,11 @@ static int mtk_hsdma_alloc_pchan(struct mtk_hsdma_device *hsdma, > * and [MTK_DMA_SIZE ... 2 * MTK_DMA_SIZE - 1] is for RX ring. > */ > pc->sz_ring = 2 * MTK_DMA_SIZE * sizeof(*ring->txd); > - ring->txd = dma_alloc_coherent(hsdma2dev(hsdma), > - pc->sz_ring, &ring->tphys, > - GFP_ATOMIC | __GFP_ZERO); > + ring->txd = dma_zalloc_coherent(hsdma2dev(hsdma), pc->sz_ring, > + &ring->tphys, GFP_ATOMIC); > if (!ring->txd) > return -ENOMEM; > > - memset(ring->txd, 0, pc->sz_ring); This should be folded back.. > ring->rxd = &ring->txd[MTK_DMA_SIZE]; > ring->rphys = ring->tphys + MTK_DMA_SIZE * sizeof(*ring->txd); > ring->cur_tptr = 0; > -- > 2.7.4 > -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: vinod.koul@intel.com (Vinod Koul) Date: Fri, 9 Feb 2018 18:28:18 +0530 Subject: [PATCH v4 5/5] dmaengine: mediatek: fix zalloc-simple.cocci warnings In-Reply-To: References: Message-ID: <20180209125817.GB3666@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Feb 09, 2018 at 01:58:51AM +0800, sean.wang at mediatek.com wrote: > From: Fengguang Wu > > Use zeroing allocator rather than allocator followed by memset with 0 > > Generated by: scripts/coccinelle/api/alloc/zalloc-simple.cocci > > Fixes: c8e4b2e4ca21 ("dmaengine: mediatek: Add MediaTek High-Speed DMA controller for MT7622 and MT7623 SoC") > Cc: Sean Wang > Signed-off-by: Fengguang Wu > Signed-off-by: Julia Lawall > Signed-off-by: Sean Wang > --- > drivers/dma/mediatek/mtk-hsdma.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/dma/mediatek/mtk-hsdma.c b/drivers/dma/mediatek/mtk-hsdma.c > index 42b5b23..d3b90fe 100644 > --- a/drivers/dma/mediatek/mtk-hsdma.c > +++ b/drivers/dma/mediatek/mtk-hsdma.c > @@ -325,13 +325,11 @@ static int mtk_hsdma_alloc_pchan(struct mtk_hsdma_device *hsdma, > * and [MTK_DMA_SIZE ... 2 * MTK_DMA_SIZE - 1] is for RX ring. > */ > pc->sz_ring = 2 * MTK_DMA_SIZE * sizeof(*ring->txd); > - ring->txd = dma_alloc_coherent(hsdma2dev(hsdma), > - pc->sz_ring, &ring->tphys, > - GFP_ATOMIC | __GFP_ZERO); > + ring->txd = dma_zalloc_coherent(hsdma2dev(hsdma), pc->sz_ring, > + &ring->tphys, GFP_ATOMIC); > if (!ring->txd) > return -ENOMEM; > > - memset(ring->txd, 0, pc->sz_ring); This should be folded back.. > ring->rxd = &ring->txd[MTK_DMA_SIZE]; > ring->rphys = ring->tphys + MTK_DMA_SIZE * sizeof(*ring->txd); > ring->cur_tptr = 0; > -- > 2.7.4 > -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751998AbeBIMyw (ORCPT ); Fri, 9 Feb 2018 07:54:52 -0500 Received: from mga14.intel.com ([192.55.52.115]:65319 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751052AbeBIMyu (ORCPT ); Fri, 9 Feb 2018 07:54:50 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,483,1511856000"; d="scan'208";a="17230859" Date: Fri, 9 Feb 2018 18:28:18 +0530 From: Vinod Koul To: sean.wang@mediatek.com Cc: dan.j.williams@intel.com, robh+dt@kernel.org, mark.rutland@arm.com, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Fengguang Wu , Julia Lawall Subject: Re: [PATCH v4 5/5] dmaengine: mediatek: fix zalloc-simple.cocci warnings Message-ID: <20180209125817.GB3666@localhost> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 09, 2018 at 01:58:51AM +0800, sean.wang@mediatek.com wrote: > From: Fengguang Wu > > Use zeroing allocator rather than allocator followed by memset with 0 > > Generated by: scripts/coccinelle/api/alloc/zalloc-simple.cocci > > Fixes: c8e4b2e4ca21 ("dmaengine: mediatek: Add MediaTek High-Speed DMA controller for MT7622 and MT7623 SoC") > Cc: Sean Wang > Signed-off-by: Fengguang Wu > Signed-off-by: Julia Lawall > Signed-off-by: Sean Wang > --- > drivers/dma/mediatek/mtk-hsdma.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/dma/mediatek/mtk-hsdma.c b/drivers/dma/mediatek/mtk-hsdma.c > index 42b5b23..d3b90fe 100644 > --- a/drivers/dma/mediatek/mtk-hsdma.c > +++ b/drivers/dma/mediatek/mtk-hsdma.c > @@ -325,13 +325,11 @@ static int mtk_hsdma_alloc_pchan(struct mtk_hsdma_device *hsdma, > * and [MTK_DMA_SIZE ... 2 * MTK_DMA_SIZE - 1] is for RX ring. > */ > pc->sz_ring = 2 * MTK_DMA_SIZE * sizeof(*ring->txd); > - ring->txd = dma_alloc_coherent(hsdma2dev(hsdma), > - pc->sz_ring, &ring->tphys, > - GFP_ATOMIC | __GFP_ZERO); > + ring->txd = dma_zalloc_coherent(hsdma2dev(hsdma), pc->sz_ring, > + &ring->tphys, GFP_ATOMIC); > if (!ring->txd) > return -ENOMEM; > > - memset(ring->txd, 0, pc->sz_ring); This should be folded back.. > ring->rxd = &ring->txd[MTK_DMA_SIZE]; > ring->rphys = ring->tphys + MTK_DMA_SIZE * sizeof(*ring->txd); > ring->cur_tptr = 0; > -- > 2.7.4 > -- ~Vinod