From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH rdma-core] mlx4: Fix 1<<31 expressions Date: Fri, 9 Feb 2018 09:51:38 -0700 Message-ID: <20180209165138.GA11850@ziepe.ca> References: <20180208233829.GA16128@ziepe.ca> <1518192109.2871.5.camel@wdc.com> <20180209161030.GA7584@mellanox.com> <20180209161325.GD7570@ziepe.ca> <20180209164200.GO2197@mtr-leonro.local> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20180209164200.GO2197-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Leon Romanovsky Cc: Parav Pandit , Bart Van Assche , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On Fri, Feb 09, 2018 at 06:42:00PM +0200, Leon Romanovsky wrote: > On Fri, Feb 09, 2018 at 09:13:25AM -0700, Jason Gunthorpe wrote: > > On Fri, Feb 09, 2018 at 04:12:24PM +0000, Parav Pandit wrote: > > > > > > I did a patch that will make our public headers mostly strictly conforming to C11 > > > > with -Wpedantic set, which I've been wondering if it is worth sending.. > > > > > Any reason to use open code instead of using BIT() macro from > > > include/linux/bitops.h which does the same thing? > > > > BIT only works in the kernel. This is a publich header from rdma-core > > userspace. > > ➜ rdma-core git:(master) git grep "define BIT" providers/mlx5/cq.c > providers/mlx5/cq.c:#define BIT(i) (1UL << (i)) Still can't use it in a public header. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html