From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: gadget: uvc: Missing files for configfs interface From: Bin Liu Message-Id: <20180209200242.GA32164@uda0271908> Date: Fri, 9 Feb 2018 14:02:42 -0600 To: Greg KH Cc: stable@vger.kernel.org, linux-usb@vger.kernel.org, Felipe Balbi , Petr Cvek List-ID: T24gRnJpLCBGZWIgMDksIDIwMTggYXQgMDg6NTE6MDNQTSArMDEwMCwgR3JlZyBLSCB3cm90ZToK PiBPbiBGcmksIEZlYiAwOSwgMjAxOCBhdCAwMToyMzo0M1BNIC0wNjAwLCBCaW4gTGl1IHdyb3Rl Ogo+ID4gRnJvbTogUGV0ciBDdmVrIDxwZXRyLmN2ZWtAdHVsLmN6Pgo+ID4gCj4gPiBjb21taXQg YzhjZDc1MTA2MGIxNDk5OTdiOWRlNTNhNDk0ZmIxNDkwZGVkNzJjNSB1cHN0cmVhbS4KPiA+IAo+ ID4gQ29tbWl0IDc2ZTBkYTM0YzdjZSAoInVzYi1nYWRnZXQvdXZjOiB1c2UgcGVyLWF0dHJpYnV0 ZSBzaG93IGFuZCBzdG9yZQo+ID4gbWV0aG9kcyIpIGNhdXNlZCBhIHN0cmluZ2lmaWNhdGlvbiBv ZiBhbiB1bmRlZmluZWQgbWFjcm8gYXJndW1lbnQgImFuYW1lIiwKPiA+IHNvIHRocmVlIFVWQyBw YXJhbWV0ZXJzIChzdHJlYW1pbmdfaW50ZXJ2YWwsIHN0cmVhbWluZ19tYXhwYWNrZXQgYW5kCj4g PiBzdHJlYW1pbmdfbWF4YnVyc3QpIHdlcmUgbmFtZWQgImFuYW1lIi4KPiA+IAo+ID4gQWRkIHRo ZSBkZWZpbml0aW9uIG9mICJhbmFtZSIgdG8gdGhlIG1haW4gbWFjcm8gYW5kIG5hbWUgdGhlIGZp bGVuYW1lcyBhcwo+ID4gb3JpZ2luYWx5IGludGVuZGVkLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5 OiBQZXRyIEN2ZWsgPHBldHIuY3Zla0B0dWwuY3o+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBGZWxpcGUg QmFsYmkgPGZlbGlwZS5iYWxiaUBsaW51eC5pbnRlbC5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBC aW4gTGl1IDxiLWxpdUB0aS5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL3VzYi9nYWRnZXQvZnVu Y3Rpb24vdXZjX2NvbmZpZ2ZzLmMgfCAxNiArKysrKysrKy0tLS0tLS0tCj4gPiAgMSBmaWxlIGNo YW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKPiAKPiBXaGF0IHN0YWJsZSBr ZXJuZWwocykgZG8geW91IHdhbnQgdGhpcyBhcHBsaWVkIHRvPwoKVGhlIGNvbW1pdCA3NmUwZGEz NGM3Y2Ugd2hpY2ggY2F1c2VzIHRoZSByZWdyZXNzaW9uIGlzIGludHJvZHVjZWQgaW4KdjQuNCwg c28gSSB3b3VsZCB0aGluayB0aGlzIHBhdGNoIGhhdmUgdG8gYmUgYXBwbGllZCBkb3duIHRvIHY0 LjQuCgpGWUksIEkgdGVzdGVkIHRoaXMgcGF0Y2ggb24gdjQuNCBhbmQgdjQuOS4KClRoYW5rcywK LUJpbi4KLS0tClRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1 bnN1YnNjcmliZSBsaW51eC11c2IiIGluCnRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpvcmRv bW9Admdlci5rZXJuZWwub3JnCk1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2VyLmtl cm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lelnx193.ext.ti.com ([198.47.27.77]:44777 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750993AbeBIUCr (ORCPT ); Fri, 9 Feb 2018 15:02:47 -0500 Date: Fri, 9 Feb 2018 14:02:42 -0600 From: Bin Liu To: Greg KH CC: , , Felipe Balbi , Petr Cvek Subject: Re: [PATCH] usb: gadget: uvc: Missing files for configfs interface Message-ID: <20180209200242.GA32164@uda0271908> References: <1518204223-17325-1-git-send-email-b-liu@ti.com> <20180209195103.GA24306@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20180209195103.GA24306@kroah.com> Sender: stable-owner@vger.kernel.org List-ID: On Fri, Feb 09, 2018 at 08:51:03PM +0100, Greg KH wrote: > On Fri, Feb 09, 2018 at 01:23:43PM -0600, Bin Liu wrote: > > From: Petr Cvek > > > > commit c8cd751060b149997b9de53a494fb1490ded72c5 upstream. > > > > Commit 76e0da34c7ce ("usb-gadget/uvc: use per-attribute show and store > > methods") caused a stringification of an undefined macro argument "aname", > > so three UVC parameters (streaming_interval, streaming_maxpacket and > > streaming_maxburst) were named "aname". > > > > Add the definition of "aname" to the main macro and name the filenames as > > originaly intended. > > > > Signed-off-by: Petr Cvek > > Signed-off-by: Felipe Balbi > > Signed-off-by: Bin Liu > > --- > > drivers/usb/gadget/function/uvc_configfs.c | 16 ++++++++-------- > > 1 file changed, 8 insertions(+), 8 deletions(-) > > What stable kernel(s) do you want this applied to? The commit 76e0da34c7ce which causes the regression is introduced in v4.4, so I would think this patch have to be applied down to v4.4. FYI, I tested this patch on v4.4 and v4.9. Thanks, -Bin.