From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Kaehlcke Subject: Re: [PATCH] amdgpu/dc: Add missing cast in dce_clock_set_min_clocks_state() Date: Fri, 9 Feb 2018 14:19:41 -0800 Message-ID: <20180209221941.GA79106@google.com> References: <20180209212834.72129-1-mka@chromium.org> <95c4b316-ee97-d7c9-a9d8-f2a7e0daa9e3@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <95c4b316-ee97-d7c9-a9d8-f2a7e0daa9e3@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Harry Wentland Cc: Craig Bergstrom , Justin TerAvest , David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Guenter Roeck , Dmytro Laktyushkin , dri-devel@lists.freedesktop.org, Alex Deucher , Tony Cheng , Christian =?utf-8?B?S8O2bmln?= List-Id: amd-gfx.lists.freedesktop.org RWwgRnJpLCBGZWIgMDksIDIwMTggYXQgMDQ6NTU6NTdQTSAtMDUwMCBIYXJyeSBXZW50bGFuZCBo YSBkaXQ6Cgo+IE9uIDIwMTgtMDItMDkgMDQ6MjggUE0sIE1hdHRoaWFzIEthZWhsY2tlIHdyb3Rl Ogo+ID4gZGNlX2Nsb2NrX3NldF9taW5fY2xvY2tzX3N0YXRlKCkgYXNzaWducyAoaW50ZW50aW9u YWxseSkgYSB2YWx1ZSBvZiB0eXBlCj4gPiAnZW51bSBkbV9wcF9jbG9ja3Nfc3RhdGUnIHRvIGEg dmFyaWFibGUgb2YgdHlwZSAnZW51bSBkbV9wcF9wb3dlcl9sZXZlbCcKPiA+IHdpdGhvdXQgYW4g ZXhwbGljaXQgY2FzdC4gVGhpcyBjYXVzZXMgY2xhbmcgdG8gcmFpc2UgdGhlIGZvbGxvd2luZwo+ ID4gd2FybmluZzoKPiA+IAo+ID4gZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvLi4vZGlzcGxh eS9kYy9kY2UvZGNlX2Nsb2Nrcy5jOjMwODo0OiBlcnJvcjoKPiA+ICAgaW1wbGljaXQgY29udmVy c2lvbiBmcm9tIGVudW1lcmF0aW9uIHR5cGUgJ2VudW0gZG1fcHBfY2xvY2tzX3N0YXRlJwo+ID4g ICB0byBkaWZmZXJlbnQgZW51bWVyYXRpb24gdHlwZSAnZW51bSBkbV9wcF9wb3dlcl9sZXZlbCcg Wy1XZXJyb3IsLVdlbnVtLWNvbnZlcnNpb25dCj4gPiAgICAgY2xvY2tzX3N0YXRlIH07Cj4gPiAK PiA+IE1ha2UgdGhlIGNhc3QgZXhwbGljaXQuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IE1hdHRo aWFzIEthZWhsY2tlIDxta2FAY2hyb21pdW0ub3JnPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUv ZHJtL2FtZC9kaXNwbGF5L2RjL2RjZS9kY2VfY2xvY2tzLmMgfCAzICsrLQo+ID4gIDEgZmlsZSBj aGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiA+IAo+ID4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9kYy9kY2UvZGNlX2Nsb2Nrcy5jIGIvZHJp dmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2RjL2RjZS9kY2VfY2xvY2tzLmMKPiA+IGluZGV4IDll OThhNWYzOWE2ZC4uZGIzY2ViMjgzMjU1IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2FtZC9kaXNwbGF5L2RjL2RjZS9kY2VfY2xvY2tzLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9hbWQvZGlzcGxheS9kYy9kY2UvZGNlX2Nsb2Nrcy5jCj4gPiBAQCAtMzA0LDcgKzMwNCw4IEBA IHN0YXRpYyBib29sIGRjZV9jbG9ja19zZXRfbWluX2Nsb2Nrc19zdGF0ZSgKPiA+ICAJZW51bSBk bV9wcF9jbG9ja3Nfc3RhdGUgY2xvY2tzX3N0YXRlKQo+ID4gIHsKPiA+ICAJc3RydWN0IGRtX3Bw X3Bvd2VyX2xldmVsX2NoYW5nZV9yZXF1ZXN0IGxldmVsX2NoYW5nZV9yZXEgPSB7Cj4gPiAtCQkJ Y2xvY2tzX3N0YXRlIH07Cj4gPiArCQkucG93ZXJfbGV2ZWwgPSAoZW51bSBkbV9wcF9wb3dlcl9s ZXZlbCljbG9ja3Nfc3RhdGUKPiAKPiBUaGFua3MgZm9yIHNwb3R0aW5nIHRoaXMuIExvb2tzIGxp a2UgYm90aCBlbnVtcyBhcmUgZXhhY3RseSB0aGUgc2FtZSBzbyBubyBuZWVkIHRvIGtlZXAgYm90 aC4gSSBzZW50IGEgcGF0Y2ggdG8gcmVtb3ZlIHRoZSBkbV9wcF9wb3dlcl9sZXZlbCBlbnVtIHRv IGFtZC1nZnggYW5kIENDJ2QgeW91IG9uIGl0LgoKRXZlbiBiZXR0ZXIsIHRoYW5rcyEKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxp bmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753084AbeBIWTp (ORCPT ); Fri, 9 Feb 2018 17:19:45 -0500 Received: from mail-pl0-f68.google.com ([209.85.160.68]:37879 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753006AbeBIWTn (ORCPT ); Fri, 9 Feb 2018 17:19:43 -0500 X-Google-Smtp-Source: AH8x2255dveqpPoGyzozqx4r/lVvOB8NQMuSCy7kd9+ZTgTl9p7g2iJdF0C3F5oyjjed3Bh19eX46w== Date: Fri, 9 Feb 2018 14:19:41 -0800 From: Matthias Kaehlcke To: Harry Wentland Cc: Alex Deucher , Christian =?utf-8?B?S8O2bmln?= , David Zhou , David Airlie , Tony Cheng , Dmytro Laktyushkin , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Guenter Roeck , Justin TerAvest , Craig Bergstrom Subject: Re: [PATCH] amdgpu/dc: Add missing cast in dce_clock_set_min_clocks_state() Message-ID: <20180209221941.GA79106@google.com> References: <20180209212834.72129-1-mka@chromium.org> <95c4b316-ee97-d7c9-a9d8-f2a7e0daa9e3@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <95c4b316-ee97-d7c9-a9d8-f2a7e0daa9e3@amd.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org El Fri, Feb 09, 2018 at 04:55:57PM -0500 Harry Wentland ha dit: > On 2018-02-09 04:28 PM, Matthias Kaehlcke wrote: > > dce_clock_set_min_clocks_state() assigns (intentionally) a value of type > > 'enum dm_pp_clocks_state' to a variable of type 'enum dm_pp_power_level' > > without an explicit cast. This causes clang to raise the following > > warning: > > > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_clocks.c:308:4: error: > > implicit conversion from enumeration type 'enum dm_pp_clocks_state' > > to different enumeration type 'enum dm_pp_power_level' [-Werror,-Wenum-conversion] > > clocks_state }; > > > > Make the cast explicit. > > > > Signed-off-by: Matthias Kaehlcke > > --- > > drivers/gpu/drm/amd/display/dc/dce/dce_clocks.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_clocks.c b/drivers/gpu/drm/amd/display/dc/dce/dce_clocks.c > > index 9e98a5f39a6d..db3ceb283255 100644 > > --- a/drivers/gpu/drm/amd/display/dc/dce/dce_clocks.c > > +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_clocks.c > > @@ -304,7 +304,8 @@ static bool dce_clock_set_min_clocks_state( > > enum dm_pp_clocks_state clocks_state) > > { > > struct dm_pp_power_level_change_request level_change_req = { > > - clocks_state }; > > + .power_level = (enum dm_pp_power_level)clocks_state > > Thanks for spotting this. Looks like both enums are exactly the same so no need to keep both. I sent a patch to remove the dm_pp_power_level enum to amd-gfx and CC'd you on it. Even better, thanks!