All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Jerry Hoemann <jerry.hoemann@hpe.com>
Cc: wim@linux-watchdog.org, linux-watchdog@vger.kernel.org,
	linux-kernel@vger.kernel.org, rwright@hpe.com,
	maurice.a.saldivar@hpe.com
Subject: Re: [01/10] watchdog/hpwdt: Remove legacy NMI sourcing.
Date: Sun, 11 Feb 2018 09:56:25 -0800	[thread overview]
Message-ID: <20180211175625.GA22035@roeck-us.net> (raw)
In-Reply-To: <20180206225855.30582-2-jerry.hoemann@hpe.com>

On Tue, Feb 06, 2018 at 03:58:46PM -0700, Jerry Hoemann wrote:
> Gen8 and prior Proliant systems supported the "CRU" interface
> to firmware.  This interfaces allows linux to "call back" into firmware
> to source the cause of an NMI.  This feature isn't fully utilized
> as the actual source of the NMI isn't printed, the driver only
> indicates that the source couldn't be determined when the call
> fails.
> 
> With the advent of Gen9, iCRU replaces the CRU. The call back
> feature is no longer available in firmware.  To be compatible and
> not attempt to call back into firmware on system not supporting CRU,
> the SMBIOS table is consulted to determine if it is safe to
> make the call back or not.
> 
> This results in about half of the driver code being devoted
> to either making CRU calls or determing if it is safe to make
> CRU calls.  As noted, the driver isn't really using the results of
> the CRU calls.
> 
> As the CRU sourcing of the NMI isn't required for handling the
> NMI, remove the legacy (pre Gen9) NMI sourcing and the DMI code to
> determine if the system had the CRU interface.
> 
> Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Spoke too early. This fails to compile if CONFIG_HPWDT_NMI_DECODING
is disabled. Please fix and resubmit the series, and please make sure
that each patch compiles on its own.

Thanks,
Guenter

  parent reply	other threads:[~2018-02-11 17:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-06 22:58 [PATCH 00/10] watchdog/hpwdt: Update driver to use watchdog core Jerry Hoemann
2018-02-06 22:58 ` [PATCH 01/10] watchdog/hpwdt: Remove legacy NMI sourcing Jerry Hoemann
2018-02-11 17:52   ` [01/10] " Guenter Roeck
2018-02-11 17:56   ` Guenter Roeck [this message]
2018-02-06 22:58 ` [PATCH 02/10] watchdog/hpwdt: remove include files no longer needed Jerry Hoemann
2018-02-06 22:58 ` [PATCH 03/10] watchdog/hpwdt: Update nmi_panic message Jerry Hoemann
2018-02-06 22:58 ` [PATCH 04/10] watchdog/hpwdt: white space changes Jerry Hoemann
2018-02-06 22:58 ` [PATCH 05/10] watchdog/hpwdt: Update Module info Jerry Hoemann
2018-02-06 22:58 ` [PATCH 06/10] watchdog/hpwdt: Modify to use watchdog core Jerry Hoemann
2018-02-06 22:58 ` [PATCH 07/10] watchdog/hpwdt: Select WATCHDOG_CORE Jerry Hoemann
2018-02-06 22:58 ` [PATCH 08/10] watchdog/hpwdt: Programable Pretimeout NMI Jerry Hoemann
2018-02-06 22:58 ` [PATCH 09/10] watchdog/hpwdt: condition early return of NMI handler on iLO5 Jerry Hoemann
2018-02-06 22:58 ` [PATCH 10/10] watchdog/hpwdt: remove allow_kdump module parameter Jerry Hoemann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180211175625.GA22035@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=jerry.hoemann@hpe.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=maurice.a.saldivar@hpe.com \
    --cc=rwright@hpe.com \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.