From: Luiz Capitulino <lcapitulino@redhat.com>
To: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, qemu-s390x@nongnu.org,
ehabkost@redhat.com, pbonzini@redhat.com,
crosthwaite.peter@gmail.com, dgilbert@redhat.com,
rth@twiddle.net, cohuck@redhat.com, borntraeger@de.ibm.com,
agraf@suse.de, david@redhat.com, eblake@redhat.com,
armbru@redhat.com, berrange@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/3] qmp: expose s390-specific CPU info
Date: Mon, 12 Feb 2018 13:03:01 -0500 [thread overview]
Message-ID: <20180212130301.1714d393@redhat.com> (raw)
In-Reply-To: <1518437672-7724-2-git-send-email-mihajlov@linux.vnet.ibm.com>
On Mon, 12 Feb 2018 13:14:30 +0100
Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com> wrote:
> Presently s390x is the only architecture not exposing specific
> CPU information via QMP query-cpus. Upstream discussion has shown
> that it could make sense to report the architecture specific CPU
> state, e.g. to detect that a CPU has been stopped.
>
> With this change the output of query-cpus will look like this on
> s390:
>
> [
> {"arch": "s390", "current": true,
> "props": {"core-id": 0}, "cpu-state": "operating", "CPU": 0,
> "qom_path": "/machine/unattached/device[0]",
> "halted": false, "thread_id": 63115},
> {"arch": "s390", "current": false,
> "props": {"core-id": 1}, "cpu-state": "stopped", "CPU": 1,
> "qom_path": "/machine/unattached/device[1]",
> "halted": true, "thread_id": 63116}
> ]
We're adding the same information to query-cpus-fast. Why do we
need to duplicate this into query-cpus? Do you plan to keep using
query-cpus? If yes, why?
Libvirt for one, should move away from it. We don't want to run
into the risk of having the same issue we had with x86 in other
archs.
>
> Signed-off-by: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>
> Acked-by: Eric Blake <eblake@redhat.com>
> ---
> cpus.c | 6 ++++++
> hmp.c | 4 ++++
> hw/intc/s390_flic.c | 4 ++--
> hw/s390x/s390-virtio-ccw.c | 2 +-
> qapi-schema.json | 28 +++++++++++++++++++++++++++-
> target/s390x/cpu.c | 24 ++++++++++++------------
> target/s390x/cpu.h | 7 ++-----
> target/s390x/kvm.c | 8 ++++----
> target/s390x/sigp.c | 38 +++++++++++++++++++-------------------
> 9 files changed, 77 insertions(+), 44 deletions(-)
>
> diff --git a/cpus.c b/cpus.c
> index f298b65..6006931 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -2100,6 +2100,9 @@ CpuInfoList *qmp_query_cpus(Error **errp)
> #elif defined(TARGET_TRICORE)
> TriCoreCPU *tricore_cpu = TRICORE_CPU(cpu);
> CPUTriCoreState *env = &tricore_cpu->env;
> +#elif defined(TARGET_S390X)
> + S390CPU *s390_cpu = S390_CPU(cpu);
> + CPUS390XState *env = &s390_cpu->env;
> #endif
>
> cpu_synchronize_state(cpu);
> @@ -2127,6 +2130,9 @@ CpuInfoList *qmp_query_cpus(Error **errp)
> #elif defined(TARGET_TRICORE)
> info->value->arch = CPU_INFO_ARCH_TRICORE;
> info->value->u.tricore.PC = env->PC;
> +#elif defined(TARGET_S390X)
> + info->value->arch = CPU_INFO_ARCH_S390;
> + info->value->u.s390.cpu_state = env->cpu_state;
> #else
> info->value->arch = CPU_INFO_ARCH_OTHER;
> #endif
> diff --git a/hmp.c b/hmp.c
> index 7870d6a..a6b94b7 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -392,6 +392,10 @@ void hmp_info_cpus(Monitor *mon, const QDict *qdict)
> case CPU_INFO_ARCH_TRICORE:
> monitor_printf(mon, " PC=0x%016" PRIx64, cpu->value->u.tricore.PC);
> break;
> + case CPU_INFO_ARCH_S390:
> + monitor_printf(mon, " state=%s",
> + CpuS390State_str(cpu->value->u.s390.cpu_state));
> + break;
> default:
> break;
> }
> diff --git a/hw/intc/s390_flic.c b/hw/intc/s390_flic.c
> index a85a149..5f8168f 100644
> --- a/hw/intc/s390_flic.c
> +++ b/hw/intc/s390_flic.c
> @@ -192,8 +192,8 @@ static void qemu_s390_flic_notify(uint32_t type)
> cs->interrupt_request |= CPU_INTERRUPT_HARD;
>
> /* ignore CPUs that are not sleeping */
> - if (s390_cpu_get_state(cpu) != CPU_STATE_OPERATING &&
> - s390_cpu_get_state(cpu) != CPU_STATE_LOAD) {
> + if (s390_cpu_get_state(cpu) != S390_CPU_STATE_OPERATING &&
> + s390_cpu_get_state(cpu) != S390_CPU_STATE_LOAD) {
> continue;
> }
>
> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
> index 4abbe89..4d0c3de 100644
> --- a/hw/s390x/s390-virtio-ccw.c
> +++ b/hw/s390x/s390-virtio-ccw.c
> @@ -368,7 +368,7 @@ static void s390_machine_reset(void)
>
> /* all cpus are stopped - configure and start the ipl cpu only */
> s390_ipl_prepare_cpu(ipl_cpu);
> - s390_cpu_set_state(CPU_STATE_OPERATING, ipl_cpu);
> + s390_cpu_set_state(S390_CPU_STATE_OPERATING, ipl_cpu);
> }
>
> static void s390_machine_device_plug(HotplugHandler *hotplug_dev,
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 5c06745..66e0927 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -410,10 +410,12 @@
> # An enumeration of cpu types that enable additional information during
> # @query-cpus.
> #
> +# @s390: since 2.12
> +#
> # Since: 2.6
> ##
> { 'enum': 'CpuInfoArch',
> - 'data': ['x86', 'sparc', 'ppc', 'mips', 'tricore', 'other' ] }
> + 'data': ['x86', 'sparc', 'ppc', 'mips', 'tricore', 's390', 'other' ] }
>
> ##
> # @CpuInfo:
> @@ -452,6 +454,7 @@
> 'ppc': 'CpuInfoPPC',
> 'mips': 'CpuInfoMIPS',
> 'tricore': 'CpuInfoTricore',
> + 's390': 'CpuInfoS390',
> 'other': 'CpuInfoOther' } }
>
> ##
> @@ -522,6 +525,29 @@
> { 'struct': 'CpuInfoOther', 'data': { } }
>
> ##
> +# @CpuS390State:
> +#
> +# An enumeration of cpu states that can be assumed by a virtual
> +# S390 CPU
> +#
> +# Since: 2.12
> +##
> +{ 'enum': 'CpuS390State',
> + 'prefix': 'S390_CPU_STATE',
> + 'data': [ 'uninitialized', 'stopped', 'check-stop', 'operating', 'load' ] }
> +
> +##
> +# @CpuInfoS390:
> +#
> +# Additional information about a virtual S390 CPU
> +#
> +# @cpu-state: the virtual CPU's state
> +#
> +# Since: 2.12
> +##
> +{ 'struct': 'CpuInfoS390', 'data': { 'cpu-state': 'CpuS390State' } }
> +
> +##
> # @query-cpus:
> #
> # Returns a list of information about each virtual CPU.
> diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c
> index da7cb9c..52b74ed 100644
> --- a/target/s390x/cpu.c
> +++ b/target/s390x/cpu.c
> @@ -58,8 +58,8 @@ static bool s390_cpu_has_work(CPUState *cs)
> S390CPU *cpu = S390_CPU(cs);
>
> /* STOPPED cpus can never wake up */
> - if (s390_cpu_get_state(cpu) != CPU_STATE_LOAD &&
> - s390_cpu_get_state(cpu) != CPU_STATE_OPERATING) {
> + if (s390_cpu_get_state(cpu) != S390_CPU_STATE_LOAD &&
> + s390_cpu_get_state(cpu) != S390_CPU_STATE_OPERATING) {
> return false;
> }
>
> @@ -77,7 +77,7 @@ static void s390_cpu_load_normal(CPUState *s)
> S390CPU *cpu = S390_CPU(s);
> cpu->env.psw.addr = ldl_phys(s->as, 4) & PSW_MASK_ESA_ADDR;
> cpu->env.psw.mask = PSW_MASK_32 | PSW_MASK_64;
> - s390_cpu_set_state(CPU_STATE_OPERATING, cpu);
> + s390_cpu_set_state(S390_CPU_STATE_OPERATING, cpu);
> }
> #endif
>
> @@ -92,7 +92,7 @@ static void s390_cpu_reset(CPUState *s)
> env->bpbc = false;
> scc->parent_reset(s);
> cpu->env.sigp_order = 0;
> - s390_cpu_set_state(CPU_STATE_STOPPED, cpu);
> + s390_cpu_set_state(S390_CPU_STATE_STOPPED, cpu);
> }
>
> /* S390CPUClass::initial_reset() */
> @@ -135,7 +135,7 @@ static void s390_cpu_full_reset(CPUState *s)
>
> scc->parent_reset(s);
> cpu->env.sigp_order = 0;
> - s390_cpu_set_state(CPU_STATE_STOPPED, cpu);
> + s390_cpu_set_state(S390_CPU_STATE_STOPPED, cpu);
>
> memset(env, 0, offsetof(CPUS390XState, end_reset_fields));
>
> @@ -247,7 +247,7 @@ static void s390_cpu_initfn(Object *obj)
> env->tod_basetime = 0;
> env->tod_timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, s390x_tod_timer, cpu);
> env->cpu_timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, s390x_cpu_timer, cpu);
> - s390_cpu_set_state(CPU_STATE_STOPPED, cpu);
> + s390_cpu_set_state(S390_CPU_STATE_STOPPED, cpu);
> #endif
> }
>
> @@ -275,8 +275,8 @@ static unsigned s390_count_running_cpus(void)
>
> CPU_FOREACH(cpu) {
> uint8_t state = S390_CPU(cpu)->env.cpu_state;
> - if (state == CPU_STATE_OPERATING ||
> - state == CPU_STATE_LOAD) {
> + if (state == S390_CPU_STATE_OPERATING ||
> + state == S390_CPU_STATE_LOAD) {
> if (!disabled_wait(cpu)) {
> nr_running++;
> }
> @@ -315,13 +315,13 @@ unsigned int s390_cpu_set_state(uint8_t cpu_state, S390CPU *cpu)
> trace_cpu_set_state(CPU(cpu)->cpu_index, cpu_state);
>
> switch (cpu_state) {
> - case CPU_STATE_STOPPED:
> - case CPU_STATE_CHECK_STOP:
> + case S390_CPU_STATE_STOPPED:
> + case S390_CPU_STATE_CHECK_STOP:
> /* halt the cpu for common infrastructure */
> s390_cpu_halt(cpu);
> break;
> - case CPU_STATE_OPERATING:
> - case CPU_STATE_LOAD:
> + case S390_CPU_STATE_OPERATING:
> + case S390_CPU_STATE_LOAD:
> /*
> * Starting a CPU with a PSW WAIT bit set:
> * KVM: handles this internally and triggers another WAIT exit.
> diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h
> index 21ce40d..66baa7a 100644
> --- a/target/s390x/cpu.h
> +++ b/target/s390x/cpu.h
> @@ -141,12 +141,9 @@ struct CPUS390XState {
> * architectures, there is a difference between a halt and a stop on s390.
> * If all cpus are either stopped (including check stop) or in the disabled
> * wait state, the vm can be shut down.
> + * The acceptable cpu_state values are defined in the CpuInfoS390State
> + * enum.
> */
> -#define CPU_STATE_UNINITIALIZED 0x00
> -#define CPU_STATE_STOPPED 0x01
> -#define CPU_STATE_CHECK_STOP 0x02
> -#define CPU_STATE_OPERATING 0x03
> -#define CPU_STATE_LOAD 0x04
> uint8_t cpu_state;
>
> /* currently processed sigp order */
> diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c
> index 0301e9d..45dd1c5 100644
> --- a/target/s390x/kvm.c
> +++ b/target/s390x/kvm.c
> @@ -1881,16 +1881,16 @@ int kvm_s390_set_cpu_state(S390CPU *cpu, uint8_t cpu_state)
> }
>
> switch (cpu_state) {
> - case CPU_STATE_STOPPED:
> + case S390_CPU_STATE_STOPPED:
> mp_state.mp_state = KVM_MP_STATE_STOPPED;
> break;
> - case CPU_STATE_CHECK_STOP:
> + case S390_CPU_STATE_CHECK_STOP:
> mp_state.mp_state = KVM_MP_STATE_CHECK_STOP;
> break;
> - case CPU_STATE_OPERATING:
> + case S390_CPU_STATE_OPERATING:
> mp_state.mp_state = KVM_MP_STATE_OPERATING;
> break;
> - case CPU_STATE_LOAD:
> + case S390_CPU_STATE_LOAD:
> mp_state.mp_state = KVM_MP_STATE_LOAD;
> break;
> default:
> diff --git a/target/s390x/sigp.c b/target/s390x/sigp.c
> index ac3f8e7..5a7a9c4 100644
> --- a/target/s390x/sigp.c
> +++ b/target/s390x/sigp.c
> @@ -46,13 +46,13 @@ static void sigp_sense(S390CPU *dst_cpu, SigpInfo *si)
> }
>
> /* sensing without locks is racy, but it's the same for real hw */
> - if (state != CPU_STATE_STOPPED && !ext_call) {
> + if (state != S390_CPU_STATE_STOPPED && !ext_call) {
> si->cc = SIGP_CC_ORDER_CODE_ACCEPTED;
> } else {
> if (ext_call) {
> status |= SIGP_STAT_EXT_CALL_PENDING;
> }
> - if (state == CPU_STATE_STOPPED) {
> + if (state == S390_CPU_STATE_STOPPED) {
> status |= SIGP_STAT_STOPPED;
> }
> set_sigp_status(si, status);
> @@ -94,12 +94,12 @@ static void sigp_start(CPUState *cs, run_on_cpu_data arg)
> S390CPU *cpu = S390_CPU(cs);
> SigpInfo *si = arg.host_ptr;
>
> - if (s390_cpu_get_state(cpu) != CPU_STATE_STOPPED) {
> + if (s390_cpu_get_state(cpu) != S390_CPU_STATE_STOPPED) {
> si->cc = SIGP_CC_ORDER_CODE_ACCEPTED;
> return;
> }
>
> - s390_cpu_set_state(CPU_STATE_OPERATING, cpu);
> + s390_cpu_set_state(S390_CPU_STATE_OPERATING, cpu);
> si->cc = SIGP_CC_ORDER_CODE_ACCEPTED;
> }
>
> @@ -108,14 +108,14 @@ static void sigp_stop(CPUState *cs, run_on_cpu_data arg)
> S390CPU *cpu = S390_CPU(cs);
> SigpInfo *si = arg.host_ptr;
>
> - if (s390_cpu_get_state(cpu) != CPU_STATE_OPERATING) {
> + if (s390_cpu_get_state(cpu) != S390_CPU_STATE_OPERATING) {
> si->cc = SIGP_CC_ORDER_CODE_ACCEPTED;
> return;
> }
>
> /* disabled wait - sleeping in user space */
> if (cs->halted) {
> - s390_cpu_set_state(CPU_STATE_STOPPED, cpu);
> + s390_cpu_set_state(S390_CPU_STATE_STOPPED, cpu);
> } else {
> /* execute the stop function */
> cpu->env.sigp_order = SIGP_STOP;
> @@ -130,17 +130,17 @@ static void sigp_stop_and_store_status(CPUState *cs, run_on_cpu_data arg)
> SigpInfo *si = arg.host_ptr;
>
> /* disabled wait - sleeping in user space */
> - if (s390_cpu_get_state(cpu) == CPU_STATE_OPERATING && cs->halted) {
> - s390_cpu_set_state(CPU_STATE_STOPPED, cpu);
> + if (s390_cpu_get_state(cpu) == S390_CPU_STATE_OPERATING && cs->halted) {
> + s390_cpu_set_state(S390_CPU_STATE_STOPPED, cpu);
> }
>
> switch (s390_cpu_get_state(cpu)) {
> - case CPU_STATE_OPERATING:
> + case S390_CPU_STATE_OPERATING:
> cpu->env.sigp_order = SIGP_STOP_STORE_STATUS;
> cpu_inject_stop(cpu);
> /* store will be performed in do_stop_interrup() */
> break;
> - case CPU_STATE_STOPPED:
> + case S390_CPU_STATE_STOPPED:
> /* already stopped, just store the status */
> cpu_synchronize_state(cs);
> s390_store_status(cpu, S390_STORE_STATUS_DEF_ADDR, true);
> @@ -156,7 +156,7 @@ static void sigp_store_status_at_address(CPUState *cs, run_on_cpu_data arg)
> uint32_t address = si->param & 0x7ffffe00u;
>
> /* cpu has to be stopped */
> - if (s390_cpu_get_state(cpu) != CPU_STATE_STOPPED) {
> + if (s390_cpu_get_state(cpu) != S390_CPU_STATE_STOPPED) {
> set_sigp_status(si, SIGP_STAT_INCORRECT_STATE);
> return;
> }
> @@ -186,7 +186,7 @@ static void sigp_store_adtl_status(CPUState *cs, run_on_cpu_data arg)
> }
>
> /* cpu has to be stopped */
> - if (s390_cpu_get_state(cpu) != CPU_STATE_STOPPED) {
> + if (s390_cpu_get_state(cpu) != S390_CPU_STATE_STOPPED) {
> set_sigp_status(si, SIGP_STAT_INCORRECT_STATE);
> return;
> }
> @@ -229,17 +229,17 @@ static void sigp_restart(CPUState *cs, run_on_cpu_data arg)
> SigpInfo *si = arg.host_ptr;
>
> switch (s390_cpu_get_state(cpu)) {
> - case CPU_STATE_STOPPED:
> + case S390_CPU_STATE_STOPPED:
> /* the restart irq has to be delivered prior to any other pending irq */
> cpu_synchronize_state(cs);
> /*
> * Set OPERATING (and unhalting) before loading the restart PSW.
> * load_psw() will then properly halt the CPU again if necessary (TCG).
> */
> - s390_cpu_set_state(CPU_STATE_OPERATING, cpu);
> + s390_cpu_set_state(S390_CPU_STATE_OPERATING, cpu);
> do_restart_interrupt(&cpu->env);
> break;
> - case CPU_STATE_OPERATING:
> + case S390_CPU_STATE_OPERATING:
> cpu_inject_restart(cpu);
> break;
> }
> @@ -285,7 +285,7 @@ static void sigp_set_prefix(CPUState *cs, run_on_cpu_data arg)
> }
>
> /* cpu has to be stopped */
> - if (s390_cpu_get_state(cpu) != CPU_STATE_STOPPED) {
> + if (s390_cpu_get_state(cpu) != S390_CPU_STATE_STOPPED) {
> set_sigp_status(si, SIGP_STAT_INCORRECT_STATE);
> return;
> }
> @@ -318,7 +318,7 @@ static void sigp_cond_emergency(S390CPU *src_cpu, S390CPU *dst_cpu,
> p_asn = dst_cpu->env.cregs[4] & 0xffff; /* Primary ASN */
> s_asn = dst_cpu->env.cregs[3] & 0xffff; /* Secondary ASN */
>
> - if (s390_cpu_get_state(dst_cpu) != CPU_STATE_STOPPED ||
> + if (s390_cpu_get_state(dst_cpu) != S390_CPU_STATE_STOPPED ||
> (psw_mask & psw_int_mask) != psw_int_mask ||
> (idle && psw_addr != 0) ||
> (!idle && (asn == p_asn || asn == s_asn))) {
> @@ -435,7 +435,7 @@ static int sigp_set_architecture(S390CPU *cpu, uint32_t param,
> if (cur_cpu == cpu) {
> continue;
> }
> - if (s390_cpu_get_state(cur_cpu) != CPU_STATE_STOPPED) {
> + if (s390_cpu_get_state(cur_cpu) != S390_CPU_STATE_STOPPED) {
> all_stopped = false;
> }
> }
> @@ -492,7 +492,7 @@ void do_stop_interrupt(CPUS390XState *env)
> {
> S390CPU *cpu = s390_env_get_cpu(env);
>
> - if (s390_cpu_set_state(CPU_STATE_STOPPED, cpu) == 0) {
> + if (s390_cpu_set_state(S390_CPU_STATE_STOPPED, cpu) == 0) {
> qemu_system_shutdown_request(SHUTDOWN_CAUSE_GUEST_SHUTDOWN);
> }
> if (cpu->env.sigp_order == SIGP_STOP_STORE_STATUS) {
next prev parent reply other threads:[~2018-02-12 18:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 12:14 [Qemu-devel] [PATCH 0/3] add query-cpu-fast and related s390 changes Viktor Mihajlovski
2018-02-12 12:14 ` [Qemu-devel] [PATCH 1/3] qmp: expose s390-specific CPU info Viktor Mihajlovski
2018-02-12 15:52 ` Cornelia Huck
2018-02-12 16:20 ` Viktor Mihajlovski
2018-02-12 18:03 ` Luiz Capitulino [this message]
2018-02-13 11:16 ` [Qemu-devel] [qemu-s390x] " David Hildenbrand
2018-02-13 12:20 ` Viktor Mihajlovski
2018-02-13 15:10 ` Eric Blake
2018-02-12 20:30 ` [Qemu-devel] " David Hildenbrand
2018-02-12 12:14 ` [Qemu-devel] [PATCH 2/3] qmp: add query-cpus-fast Viktor Mihajlovski
2018-02-12 16:06 ` Cornelia Huck
2018-02-12 16:50 ` Dr. David Alan Gilbert
2018-02-13 15:14 ` Viktor Mihajlovski
2018-02-12 20:35 ` David Hildenbrand
2018-02-12 12:14 ` [Qemu-devel] [PATCH 3/3] qmp: add architecture specific cpu data for query-cpus-fast Viktor Mihajlovski
2018-02-12 16:23 ` Cornelia Huck
2018-02-13 16:12 ` Viktor Mihajlovski
2018-02-13 16:17 ` Cornelia Huck
2018-02-12 18:15 ` Luiz Capitulino
2018-02-13 12:30 ` Viktor Mihajlovski
2018-02-13 13:41 ` Luiz Capitulino
2018-02-12 15:38 ` [Qemu-devel] [PATCH 0/3] add query-cpu-fast and related s390 changes Cornelia Huck
2018-02-12 16:26 ` Viktor Mihajlovski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180212130301.1714d393@redhat.com \
--to=lcapitulino@redhat.com \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=crosthwaite.peter@gmail.com \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=mihajlov@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.