From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [COMMITTED 1/1] Replace __BEGIN_DECLS and __END_DECLS to with expanded macros
Date: Mon, 12 Feb 2018 16:52:20 +0100 [thread overview]
Message-ID: <20180212155220.GA1105@x230> (raw)
In-Reply-To: <20180212104745.GA9342@rei.lan>
Hi Cyril,
> > > > testcases/kernel/syscalls/epoll2/include/epoll.h | 8 +-
> > > > utils/ffsb-6.0-rc2/config.h.in | 49 +-
> > > > utils/ffsb-6.0-rc2/configure | 5937 ++++++++++------------
> > > ^
> > > This does not look like intended change, can you please revert the
> > > patch and apply clean version?
> > > (Have you used git commit -a by mistake?)
> > I'm sorry for mistake. I reverted it and commit again.
> No problem at all.
> > I wish there was a commit of ffsb configure files with recent/common autotools version
> > as I keep reverting them often. But it's a question, what is common autotools version.
> Looked shortly into the problem, it looks like the problem is Makefile
> generated by automake decides to regenerate configure script because
> timestamps are not preserved on git checkout and the build system thinks
> that configure script is out of date since it's older than the files it
> has been generated from. Looks like this is a common problem see:
> https://www.gnu.org/software/automake/manual/html_node/CVS.html
> One of the solutions would be to regenerate the configure with
> AM_MAINTAINER_MODE() which should disable the automagic regeneration.
Thanks for investigation! I'm for using it (better than have some scripts like gcc folks
as mentioned there as an alternative).
> Also side note, I've learned not to use git commit -a after one of the
> screw ups or at least check the resulting patch for unintended changes.
Well, I wasn't using '-a' switch. Custom function is sometimes even worse than '-a' switch :-).
Kind regards,
Petr
next prev parent reply other threads:[~2018-02-12 15:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 14:05 [LTP] [COMMITTED 1/1] Replace __BEGIN_DECLS and __END_DECLS to with expanded macros Petr Vorel
2018-02-09 15:51 ` Cyril Hrubis
2018-02-09 18:20 ` Petr Vorel
2018-02-12 10:47 ` Cyril Hrubis
2018-02-12 15:52 ` Petr Vorel [this message]
2018-02-14 22:38 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180212155220.GA1105@x230 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.