From: Tejun Heo <tj@kernel.org>
To: Eric Biggers <ebiggers3@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
syzkaller-bugs@googlegroups.com,
Vinayak Kale <vinayak.kale@seagate.com>,
Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH] libata: don't try to pass through NCQ commands to non-NCQ devices
Date: Mon, 12 Feb 2018 09:21:56 -0800 [thread overview]
Message-ID: <20180212172156.GD695913@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <20180204043351.16812-1-ebiggers3@gmail.com>
On Sat, Feb 03, 2018 at 08:33:51PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> syzkaller hit a WARN() in ata_bmdma_qc_issue() when writing to /dev/sg0.
> This happened because it issued an ATA pass-through command (ATA_16)
> where the protocol field indicated that NCQ should be used -- but the
> device did not support NCQ.
>
> We could just remove the WARN() from libata-sff.c, but the real problem
> seems to be that the SCSI -> ATA translation code passes through NCQ
> commands without verifying that the device actually supports NCQ.
>
> Fix this by adding the appropriate check to ata_scsi_pass_thru().
Applied to libata/for-4.16-fixes.
Thanks.
--
tejun
prev parent reply other threads:[~2018-02-12 17:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 10:06 WARNING in ata_bmdma_qc_issue syzbot
2018-02-04 4:33 ` [PATCH] libata: don't try to pass through NCQ commands to non-NCQ devices Eric Biggers
2018-02-12 17:21 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180212172156.GD695913@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=syzkaller-bugs@googlegroups.com \
--cc=vinayak.kale@seagate.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.