Re: [PATCH] fpga-manager: altera-ps-spi: enable usage on non-dt platforms

[Anatolij Gustschin <agust@denx.de>]

Hi Alan,

On Mon, 12 Feb 2018 10:19:06 -0600
Alan Tull atull@kernel.org wrote:
...
>> +       if (spi->dev.of_node) {
>> +               of_id = of_match_device(of_ef_match, &spi->dev);
>> +               if (!of_id)
>> +                       return -ENODEV;
>> +
>> +               conf->data = of_id->data;
>> +       } else {
>> +               id = spi_get_device_id(spi);
>> +               if (!id)
>> +                       return -ENODEV;  
>
>Is it actually possible for !id at this point?  Seems like if we are
>in this probe function and we get this far, this would always succeed.

Yes, !id should be always false here. I'll drop this check then.

Thanks,

Anatolij