From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v4,5/5] dmaengine: mediatek: fix zalloc-simple.cocci warnings From: Vinod Koul Message-Id: <20180213064659.GD3666@localhost> Date: Tue, 13 Feb 2018 12:16:59 +0530 To: Julia Lawall Cc: sean.wang@mediatek.com, dan.j.williams@intel.com, robh+dt@kernel.org, mark.rutland@arm.com, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Fengguang Wu List-ID: T24gRnJpLCBGZWIgMDksIDIwMTggYXQgMDM6NTU6NThQTSArMDEwMCwgSnVsaWEgTGF3YWxsIHdy b3RlOgo+IAo+ID4gPiAtCXJpbmctPnR4ZCA9IGRtYV9hbGxvY19jb2hlcmVudChoc2RtYTJkZXYo aHNkbWEpLAo+ID4gPiAtCQkJCSAgICAgICBwYy0+c3pfcmluZywgJnJpbmctPnRwaHlzLAo+ID4g PiAtCQkJCSAgICAgICBHRlBfQVRPTUlDIHwgX19HRlBfWkVSTyk7Cj4gPiA+ICsJcmluZy0+dHhk ID0gZG1hX3phbGxvY19jb2hlcmVudChoc2RtYTJkZXYoaHNkbWEpLCBwYy0+c3pfcmluZywKPiA+ ID4gKwkJCQkJJnJpbmctPnRwaHlzLCBHRlBfQVRPTUlDKTsKPiA+ID4gIAlpZiAoIXJpbmctPnR4 ZCkKPiA+ID4gIAkJcmV0dXJuIC1FTk9NRU07Cj4gPiA+Cj4gPiA+IC0JbWVtc2V0KHJpbmctPnR4 ZCwgMCwgcGMtPnN6X3JpbmcpOwo+ID4KPiA+IFRoaXMgc2hvdWxkIGJlIGZvbGRlZCBiYWNrLi4K PiAKPiBTb3JyeSwgSSdtIG5vdCBzdXJlIHdoYXQgeW91IG1lYW4gYnkgImZvbGRlZCBiYWNrIi4K ClNpbmNlIHRoZSBvcmlnaW5hbCBwYXRjaCBpcyBhbHNvIHVwIGZvciByZXZpZXcgaW4gdGhpcyBz ZXJpZXMsIGl0IGRvZXNuJ3QKaGVscCBtdWNoIHRvIGFkZCBhIGNoYW5nZSBhbmQgZml4IG9uIHRv cCBpbiBhIHNlcmllcy4gVGhlIGZpeCBzaG91bGQgYmUKZm9sZGVkIGJhY2sgaW50byB0aGUgb3Jp Z2luYWwgY29tbWl0LiBJSVJDIEZlbmdndWFuZydzIGJvdCBhbHNvIHJlY29tbWVuZHMKc28uLgo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH v4 5/5] dmaengine: mediatek: fix zalloc-simple.cocci warnings Date: Tue, 13 Feb 2018 12:16:59 +0530 Message-ID: <20180213064659.GD3666@localhost> References: <20180209125817.GB3666@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Julia Lawall Cc: sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Fengguang Wu List-Id: linux-mediatek@lists.infradead.org On Fri, Feb 09, 2018 at 03:55:58PM +0100, Julia Lawall wrote: > > > > - ring->txd = dma_alloc_coherent(hsdma2dev(hsdma), > > > - pc->sz_ring, &ring->tphys, > > > - GFP_ATOMIC | __GFP_ZERO); > > > + ring->txd = dma_zalloc_coherent(hsdma2dev(hsdma), pc->sz_ring, > > > + &ring->tphys, GFP_ATOMIC); > > > if (!ring->txd) > > > return -ENOMEM; > > > > > > - memset(ring->txd, 0, pc->sz_ring); > > > > This should be folded back.. > > Sorry, I'm not sure what you mean by "folded back". Since the original patch is also up for review in this series, it doesn't help much to add a change and fix on top in a series. The fix should be folded back into the original commit. IIRC Fengguang's bot also recommends so.. -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: vinod.koul@intel.com (Vinod Koul) Date: Tue, 13 Feb 2018 12:16:59 +0530 Subject: [PATCH v4 5/5] dmaengine: mediatek: fix zalloc-simple.cocci warnings In-Reply-To: References: <20180209125817.GB3666@localhost> Message-ID: <20180213064659.GD3666@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Feb 09, 2018 at 03:55:58PM +0100, Julia Lawall wrote: > > > > - ring->txd = dma_alloc_coherent(hsdma2dev(hsdma), > > > - pc->sz_ring, &ring->tphys, > > > - GFP_ATOMIC | __GFP_ZERO); > > > + ring->txd = dma_zalloc_coherent(hsdma2dev(hsdma), pc->sz_ring, > > > + &ring->tphys, GFP_ATOMIC); > > > if (!ring->txd) > > > return -ENOMEM; > > > > > > - memset(ring->txd, 0, pc->sz_ring); > > > > This should be folded back.. > > Sorry, I'm not sure what you mean by "folded back". Since the original patch is also up for review in this series, it doesn't help much to add a change and fix on top in a series. The fix should be folded back into the original commit. IIRC Fengguang's bot also recommends so.. -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933478AbeBMGna (ORCPT ); Tue, 13 Feb 2018 01:43:30 -0500 Received: from mga11.intel.com ([192.55.52.93]:1764 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933366AbeBMGn2 (ORCPT ); Tue, 13 Feb 2018 01:43:28 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,506,1511856000"; d="scan'208";a="30967152" Date: Tue, 13 Feb 2018 12:16:59 +0530 From: Vinod Koul To: Julia Lawall Cc: sean.wang@mediatek.com, dan.j.williams@intel.com, robh+dt@kernel.org, mark.rutland@arm.com, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Fengguang Wu Subject: Re: [PATCH v4 5/5] dmaengine: mediatek: fix zalloc-simple.cocci warnings Message-ID: <20180213064659.GD3666@localhost> References: <20180209125817.GB3666@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 09, 2018 at 03:55:58PM +0100, Julia Lawall wrote: > > > > - ring->txd = dma_alloc_coherent(hsdma2dev(hsdma), > > > - pc->sz_ring, &ring->tphys, > > > - GFP_ATOMIC | __GFP_ZERO); > > > + ring->txd = dma_zalloc_coherent(hsdma2dev(hsdma), pc->sz_ring, > > > + &ring->tphys, GFP_ATOMIC); > > > if (!ring->txd) > > > return -ENOMEM; > > > > > > - memset(ring->txd, 0, pc->sz_ring); > > > > This should be folded back.. > > Sorry, I'm not sure what you mean by "folded back". Since the original patch is also up for review in this series, it doesn't help much to add a change and fix on top in a series. The fix should be folded back into the original commit. IIRC Fengguang's bot also recommends so.. -- ~Vinod