From: Yuanhan Liu <yliu@fridaylinux.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Bruce Richardson <bruce.richardson@intel.com>,
DPDK <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] doc: coding style: use linux kernel style for indentation
Date: Tue, 13 Feb 2018 21:12:16 +0800 [thread overview]
Message-ID: <20180213131216.GH2156@yliu-mob> (raw)
In-Reply-To: <cbcc161b-f1ba-079d-282d-b64f3a12ce7f@intel.com>
On Tue, Feb 13, 2018 at 12:51:57PM +0000, Ferruh Yigit wrote:
> On 1/13/2016 4:49 PM, stephen at networkplumber.org (Stephen Hemminger) wrote:
> > On Wed, 13 Jan 2016 15:07:08 +0000
> > Bruce Richardson <bruce.richardson at intel.com> wrote:
> >
> >> So, while the two-tab indent may look "a bit weird" it does solve the two issues
> >> above. I believe practical benefits should override initial impressions. [It took
> >> me a while to get used to also, but now I very much like it as a style.]
> >
> > I don't think that deviating from kernel style for this case is justified.
>
> This is very old patch still sitting in patchwork, re-visiting it mainly to be
> able to clean the patchwork.
Just drop it, there is no reason to revisit it.
--yliu
>
> This is a syntax change request and although I have my personal preferences I
> would be OK with whatever decided.
>
> Currently there is already a decided syntax, changing it after this point will
> cause either mixed usage or a big syntax cleanup patch. I think both are not good.
>
> I am for continue whatever documented in current DPDK coding style doc, hence
> NAK from my side.
>
> Thanks,
> ferruh
prev parent reply other threads:[~2018-02-13 13:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 7:58 [PATCH] doc: coding style: use linux kernel style for indentation Yuanhan Liu
2016-01-13 15:07 ` Bruce Richardson
2016-01-13 16:49 ` Stephen Hemminger
2018-02-13 12:51 ` Ferruh Yigit
2018-02-13 13:12 ` Yuanhan Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213131216.GH2156@yliu-mob \
--to=yliu@fridaylinux.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.