From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [RFC] drm/atomic: Abuse legacy cursor update flag for legacy gamma update too
Date: Tue, 13 Feb 2018 15:29:26 +0200 [thread overview]
Message-ID: <20180213132926.GE5453@intel.com> (raw)
In-Reply-To: <59070564-40db-7a17-6812-38ab9a9653b3@linux.intel.com>
On Tue, Feb 13, 2018 at 10:33:28AM +0100, Maarten Lankhorst wrote:
> Hey,
>
> Op 13-02-18 om 10:16 schreef Chris Wilson:
> > Quoting Maarten Lankhorst (2018-02-13 09:12:01)
> >> Programs like redshift set the legacy gamma for X.org every 5 seconds.
> >> Because atomic commits wait for vblank completion, we get a frame drop
> >> every 5 seconds because of the legacy gamma update.
> >>
> >> Work around this by setting the legacy_cursor_update flag, to force
> >> legacy gamma updates not to be synced against vblank.
> >>
> >> Reported-by: Tholin #intel-gfx
> >> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Reminiscing: Remember the time we had all those vblank workers patches,
> > one of which was to do async gamma updates (apply the last one on the
> > vblank). Motivated by gnome-shell and the ilk doing a gamma animation
> > for fade-out on logout (which I guess they gave up on since it happened
> > to be so slow as to extend logout ;).
>
> That special case could be handled by userspace with atomic commits, I don't
> think it's worth optimizing it further..
We need to eventually move the gamma updates (and other single buffered
registers) to a vblank worker or something similar. Otherwise they will
tear.
--
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-02-13 13:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 9:12 [RFC] drm/atomic: Abuse legacy cursor update flag for legacy gamma update too Maarten Lankhorst
2018-02-13 9:16 ` Chris Wilson
2018-02-13 9:33 ` Maarten Lankhorst
2018-02-13 13:29 ` Ville Syrjälä [this message]
2018-02-19 14:34 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213132926.GE5453@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.